Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Heidelberg <markus.heidelberg@web.de>
To: buildroot@busybox.net
Subject: [Buildroot] VLC media player patched + some libraries added
Date: Fri, 10 Jul 2009 23:05:40 +0200	[thread overview]
Message-ID: <200907102305.40933.markus.heidelberg@web.de> (raw)
In-Reply-To: <87a5b0800907100326m537a6e0exdf355d217eaa308@mail.gmail.com>

Will Newton, 10.07.2009:
> On Fri, Jul 10, 2009 at 10:31 AM, Roeland Van Praet<roelvp@mind.be> wrote:
> > Hi all,
> >
> > In March I already submitted this patch but apparantly it hasn't been
> > accepted yet, even after a reminder.
> > Can someone please review this patch and tell me if it is missing something
> > or not.
> >
> > Thank you very much,
> 
> It would be helpful to submit this patch as a number of entries in the
> bugzilla, one per package

Personally I find working with the bug tracker extremely annoying. I
only look at those patches, if they are of direct interest to me.

> - that way if things do get missed on the
> mailing list then someone is more likely to pick them up later.

I'm not totally sure about that. Resending as it's done in several other
projects as well, should raise more attention.

But it's right, you should send one patch for one package. And inline in
the mail. It would also be more attractive for review.

> I notice VLC 1.0.0 is out. Is there a reason why you are using an older version?

True. It also seems that vlc.patch is already applied in a somewhat
different form, which makes VLC work with older libavcodec versions as
well.

> Also it appears that the version of ffmpeg is a snapshot which changes
> daily. Is that the case? It would seem useful to have an option to
> pick a particular snapshot so builds are more reproducible.

It's also possible to use snapshots from Gentoo for example:
http://distfiles.gentoo.org/distfiles/ffmpeg-0.5.tar.bz2

Have you sent your changes in ffmpeg.patch upstream? Patches in
Buildroot normally only make sense for bug fixes, not for improvements.

Markus

  reply	other threads:[~2009-07-10 21:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-10  9:31 [Buildroot] VLC media player patched + some libraries added Roeland Van Praet
2009-07-10 10:26 ` Will Newton
2009-07-10 21:05   ` Markus Heidelberg [this message]
2009-10-25 22:06 ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2009-03-23 15:36 Roeland Van Praet
2009-03-27  9:01 ` Roeland Van Praet
2009-03-29 20:34   ` Peter Korsgaard
2009-03-30 19:08     ` Roeland Van Praet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200907102305.40933.markus.heidelberg@web.de \
    --to=markus.heidelberg@web.de \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox