[Buildroot] VLC media player patched + some libraries added

[Buildroot] VLC media player patched + some libraries added

[Roeland Van Praet]

Hi all,

In March I already submitted this patch but apparantly it hasn't been
accepted yet, even after a reminder.
Can someone please review this patch and tell me if it is missing
something or not.

Thank you very much,


Roeland Van Praet

Embedded Software Developer
Mind - an ESSENSIUM nv division
Gaston Geenslaan 9 - B 3001 Leuven - Belgium
web : www.mind.be
mail: roelvp at mind.be
tel : +32 16 28 65 34
fax : +32 16 28 65 01 
BE 872 984 063 RPR Leuven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090710/fab8eb2e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-ffmpeg-libmpeg2-libdc1394.patch
Type: text/x-patch
Size: 17438 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090710/fab8eb2e/attachment-0001.bin>

[Buildroot] VLC media player patched + some libraries added

[Will Newton]

On Fri, Jul 10, 2009 at 10:31 AM, Roeland Van Praet<roelvp@mind.be> wrote:
> Hi all,
>
> In March I already submitted this patch but apparantly it hasn't been
> accepted yet, even after a reminder.
> Can someone please review this patch and tell me if it is missing something
> or not.
>
> Thank you very much,

It would be helpful to submit this patch as a number of entries in the
bugzilla, one per package - that way if things do get missed on the
mailing list then someone is more likely to pick them up later.

I notice VLC 1.0.0 is out. Is there a reason why you are using an older version?

Also it appears that the version of ffmpeg is a snapshot which changes
daily. Is that the case? It would seem useful to have an option to
pick a particular snapshot so builds are more reproducible.

[Buildroot] VLC media player patched + some libraries added

[Markus Heidelberg]

Will Newton, 10.07.2009:
> On Fri, Jul 10, 2009 at 10:31 AM, Roeland Van Praet<roelvp@mind.be> wrote:
> > Hi all,
> >
> > In March I already submitted this patch but apparantly it hasn't been
> > accepted yet, even after a reminder.
> > Can someone please review this patch and tell me if it is missing something
> > or not.
> >
> > Thank you very much,
> 
> It would be helpful to submit this patch as a number of entries in the
> bugzilla, one per package

Personally I find working with the bug tracker extremely annoying. I
only look at those patches, if they are of direct interest to me.

> - that way if things do get missed on the
> mailing list then someone is more likely to pick them up later.

I'm not totally sure about that. Resending as it's done in several other
projects as well, should raise more attention.

But it's right, you should send one patch for one package. And inline in
the mail. It would also be more attractive for review.

> I notice VLC 1.0.0 is out. Is there a reason why you are using an older version?

True. It also seems that vlc.patch is already applied in a somewhat
different form, which makes VLC work with older libavcodec versions as
well.

> Also it appears that the version of ffmpeg is a snapshot which changes
> daily. Is that the case? It would seem useful to have an option to
> pick a particular snapshot so builds are more reproducible.

It's also possible to use snapshots from Gentoo for example:
http://distfiles.gentoo.org/distfiles/ffmpeg-0.5.tar.bz2

Have you sent your changes in ffmpeg.patch upstream? Patches in
Buildroot normally only make sense for bug fixes, not for improvements.

Markus

[Buildroot] VLC media player patched + some libraries added

[Peter Korsgaard]

>>>>> "Roeland" == Roeland Van Praet <roelvp@mind.be> writes:

 Roeland> Hi all,
 Roeland> In March I already submitted this patch but apparantly it hasn't been accepted
 Roeland> yet, even after a reminder.
 Roeland> Can someone please review this patch and tell me if it is missing something or
 Roeland> not.

 Roeland> Thank you very much,


Care to splitup the patches per package and resend? It would be nice to
finally get these integrated.

-- 
Bye, Peter Korsgaard

[Buildroot] VLC media player patched + some libraries added

[Roeland Van Praet]

Hi,

Here I have a patch for VLC + several libraries I required and added to
the packages.
The file attached is a patch for the current SVN.

Let me know if something is missing.

Regards,


Roeland Van Praet

Embedded Software Developer
Mind - an ESSENSIUM nv division
Gaston Geenslaan 9 - B 3001 Leuven - Belgium
web : www.mind.be
mail: roelvp at mind.be
tel : +32 16 28 65 34
fax : +32 16 28 65 01 
BE 872 984 063 RPR Leuven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090323/70b72484/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vlc-ffmpeg-libmpeg2-libdc1394.patch
Type: text/x-patch
Size: 17438 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090323/70b72484/attachment-0001.bin>

[Buildroot] VLC media player patched + some libraries added

[Roeland Van Praet]

Hi all,

Since I still haven't read about any response concerning my path, I'm
wondering if somebody is testing this or not?
I hope it doesn't go by unnoticed since there are some nice multimedia
libraries included in the patch.

Please let me know :)

Regards
On Mon, 2009-03-23 at 16:36 +0100, Roeland Van Praet wrote:

> Hi,
> 
> Here I have a patch for VLC + several libraries I required and added
> to the packages.
> The file attached is a patch for the current SVN.
> 
> Let me know if something is missing.
> 
> Regards,
> 
> 
> Roeland Van Praet
> 
> Embedded Software Developer
> Mind - an ESSENSIUM nv division
> Gaston Geenslaan 9 - B 3001 Leuven - Belgium
> web : www.mind.be
> mail: roelvp at mind.be
> tel : +32 16 28 65 34
> fax : +32 16 28 65 01 
> BE 872 984 063 RPR Leuven
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot



Roeland Van Praet

Embedded Software Developer
Mind - an ESSENSIUM nv division
Gaston Geenslaan 9 - B 3001 Leuven - Belgium
web : www.mind.be
mail: roelvp at mind.be
tel : +32 16 28 65 34
fax : +32 16 28 65 01 
BE 872 984 063 RPR Leuven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090327/91b7b273/attachment-0001.htm>

[Buildroot] VLC media player patched + some libraries added

[Peter Korsgaard]

>>>>> "Roeland" == Roeland Van Praet <roelvp@mind.be> writes:

 Roeland> Hi all,

 Roeland> Since I still haven't read about any response concerning my
 Roeland> path, I'm wondering if somebody is testing this or not?

I haven't heard any testing reports here or on IRC ..

 Roeland> I hope it doesn't go by unnoticed since there are some nice
 Roeland> multimedia libraries included in the patch.

Definately not. It's still on my todo list, but my time is
unfortunately quite limited at the moment.

I will try to find time for it this coming week. Thanks for the patch.

-- 
Bye, Peter Korsgaard

[Buildroot] VLC media player patched + some libraries added

[Roeland Van Praet]

Thanks, I'll read the outcome on the mailing list :)


On Sun, 2009-03-29 at 22:34 +0200, Peter Korsgaard wrote:

> >>>>> "Roeland" == Roeland Van Praet <roelvp@mind.be> writes:
> 
>  Roeland> Hi all,
> 
>  Roeland> Since I still haven't read about any response concerning my
>  Roeland> path, I'm wondering if somebody is testing this or not?
> 
> I haven't heard any testing reports here or on IRC ..
> 
>  Roeland> I hope it doesn't go by unnoticed since there are some nice
>  Roeland> multimedia libraries included in the patch.
> 
> Definately not. It's still on my todo list, but my time is
> unfortunately quite limited at the moment.
> 
> I will try to find time for it this coming week. Thanks for the patch.
> 



Roeland Van Praet

Embedded Software Developer
Mind - an ESSENSIUM nv division
Gaston Geenslaan 9 - B 3001 Leuven - Belgium
web : www.mind.be
mail: roelvp at mind.be
tel : +32 16 28 65 34
fax : +32 16 28 65 01 
BE 872 984 063 RPR Leuven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20090330/3ce26d07/attachment.htm>