Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Fix autotools instalation with symbols
@ 2010-01-19 19:32 Paulius Zaleckas
  2010-01-20  0:32 ` [Buildroot] [PATCH] package: fix unstripped binary installation llandwerlin at gmail.com
  2010-01-20  0:35 ` [Buildroot] [PATCH] Fix autotools instalation with symbols Lionel Landwerlin
  0 siblings, 2 replies; 3+ messages in thread
From: Paulius Zaleckas @ 2010-01-19 19:32 UTC (permalink / raw)
  To: buildroot

When installing without symbols install-strip is used,
with symbols - install-exec.
Since install-exec installs only executables, we should use
simple install, to install other needed files also
(like files in /usr/shared) as install-strip does.

Signed-off-by: Paulius Zaleckas <paulius.zaleckas@gmail.com>
---

 package/Makefile.autotools.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
index 7114bba..a8dd051 100644
--- a/package/Makefile.autotools.in
+++ b/package/Makefile.autotools.in
@@ -60,7 +60,7 @@ $(2)_LIBTOOL_PATCH		?= YES
 $(2)_USE_CONFIG_CACHE           ?= $(if $(BR2_CONFIG_CACHE),YES,NO)
 $(2)_INSTALL_STAGING_OPT	?= DESTDIR=$$(STAGING_DIR) install
 ifeq ($(BR2_ENABLE_DEBUG),y)
-$(2)_INSTALL_TARGET_OPT		?= DESTDIR=$$(TARGET_DIR)  install-exec
+$(2)_INSTALL_TARGET_OPT		?= DESTDIR=$$(TARGET_DIR)  install
 else
 $(2)_INSTALL_TARGET_OPT		?= DESTDIR=$$(TARGET_DIR)  install-strip
 endif

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package: fix unstripped binary installation
  2010-01-19 19:32 [Buildroot] [PATCH] Fix autotools instalation with symbols Paulius Zaleckas
@ 2010-01-20  0:32 ` llandwerlin at gmail.com
  2010-01-20  0:35 ` [Buildroot] [PATCH] Fix autotools instalation with symbols Lionel Landwerlin
  1 sibling, 0 replies; 3+ messages in thread
From: llandwerlin at gmail.com @ 2010-01-20  0:32 UTC (permalink / raw)
  To: buildroot

From: Lionel Landwerlin <llandwerlin@gmail.com>

Signed-off-by: Lionel Landwerlin <llandwerlin@gmail.com>
---
 package/Makefile.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/Makefile.in b/package/Makefile.in
index e643577..bc0ac7c 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -163,7 +163,7 @@ TARGET_STRIP=$(STAGING_DIR)/usr/bin/$(REAL_GNU_TARGET_NAME)-sstrip
 STRIPCMD=$(TARGET_STRIP)
 endif
 ifeq ($(BR2_STRIP_none),y)
-TARGET_STRIP=true Not_stripping
+TARGET_STRIP=true
 STRIPCMD=$(TARGET_STRIP)
 endif
 INSTALL:=$(shell which install || type -p install)
-- 
1.6.5.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] Fix autotools instalation with symbols
  2010-01-19 19:32 [Buildroot] [PATCH] Fix autotools instalation with symbols Paulius Zaleckas
  2010-01-20  0:32 ` [Buildroot] [PATCH] package: fix unstripped binary installation llandwerlin at gmail.com
@ 2010-01-20  0:35 ` Lionel Landwerlin
  1 sibling, 0 replies; 3+ messages in thread
From: Lionel Landwerlin @ 2010-01-20  0:35 UTC (permalink / raw)
  To: buildroot

Le mardi 19 janvier 2010 ? 21:32 +0200, Paulius Zaleckas a ?crit :
> When installing without symbols install-strip is used,
> with symbols - install-exec.
> Since install-exec installs only executables, we should use
> simple install, to install other needed files also
> (like files in /usr/shared) as install-strip does.

Fully agree !

As well libraries' plugins aren't installed with install-exec (directfb
gfxdrivers for examples). So we really need install-strip or install
instead of install-exec.

Acked-by: Lionel Landwerlin <llandwerlin@gmail.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-20  0:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-19 19:32 [Buildroot] [PATCH] Fix autotools instalation with symbols Paulius Zaleckas
2010-01-20  0:32 ` [Buildroot] [PATCH] package: fix unstripped binary installation llandwerlin at gmail.com
2010-01-20  0:35 ` [Buildroot] [PATCH] Fix autotools instalation with symbols Lionel Landwerlin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox