From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch]matchbox: convert to autotools
Date: Thu, 25 Mar 2010 23:49:20 +0100 [thread overview]
Message-ID: <20100325234920.5dae5e04@surf> (raw)
In-Reply-To: <4BA7C9D6.8060208@carallon.com>
Hello William,
Thanks a lot for doing this work! Next time, to ease the review process,
could you send your patch inline ? git send-email will do it for you.
A few minor comments below :
On Mon, 22 Mar 2010 19:49:42 +0000
William Wagner <will_wagner@carallon.com> wrote:
> +++ b/package/matchbox/matchbox-common/matchbox-common.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# MatchBox Common
> +#
> +#############################################################
> +
> +MATCHBOX_COMMON_VERSION = 0.9.1
> +MATCHBOX_COMMON_SOURCE = matchbox-common-$(MATCHBOX_COMMON_VERSION).tar.bz2
> +MATCHBOX_COMMON_SITE = http://matchbox-project.org/sources/matchbox-common/$(MATCHBOX_COMMON_VERSION)
> +MATCHBOX_COMMON_AUTORECONF = NO
Unneeded, this is the default value.
> +MATCHBOX_COMMON_DEPENDENCIES = matchbox-lib
> +MATCHBOX_COMMON_CONF_OPT =
Unneeded empty definition.
> +#############################################################
> +#
> +# MatchBox Desktop
> +#
> +#############################################################
> +
> +MATCHBOX_DESKTOP_VERSION = 0.9.1
> +MATCHBOX_DESKTOP_SOURCE = matchbox-desktop-$(MATCHBOX_DESKTOP_VERSION).tar.bz2
> +MATCHBOX_DESKTOP_SITE = http://matchbox-project.org/sources/matchbox-desktop/$(MATCHBOX_DESKTOP_VERSION)
> +MATCHBOX_DESKTOP_AUTORECONF = NO
Unneeded, this is the default value.
> +++ b/package/matchbox/matchbox-fakekey/matchbox-fakekey.mk
> @@ -0,0 +1,25 @@
> +#############################################################
> +#
> +# MatchBox Fakekey
> +#
> +#############################################################
> +
> +MATCHBOX_FAKEKEY_VERSION = 0.1
> +MATCHBOX_FAKEKEY_SOURCE = libfakekey-$(MATCHBOX_FAKEKEY_VERSION).tar.bz2
> +MATCHBOX_FAKEKEY_SITE = http://matchbox-project.org/sources/libfakekey/$(MATCHBOX_FAKEKEY_VERSION)
> +MATCHBOX_FAKEKEY_AUTORECONF = NO
This is the default value.
> --- /dev/null
> +++ b/package/matchbox/matchbox-keyboard/matchbox-keyboard.mk
> @@ -0,0 +1,30 @@
> +#############################################################
> +#
> +# MatchBox Keyboard
> +#
> +#############################################################
> +
> +MATCHBOX_KEYBOARD_VERSION = 0.1
> +MATCHBOX_KEYBOARD_SOURCE = matchbox-keyboard-$(MATCHBOX_KEYBOARD_VERSION).tar.bz2
> +MATCHBOX_KEYBOARD_SITE = http://matchbox-project.org/sources/matchbox-keyboard/$(MATCHBOX_KEYBOARD_VERSION)
> +MATCHBOX_KEYBOARD_AUTORECONF = NO
Same thing.
> +++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
> @@ -0,0 +1,59 @@
> +#############################################################
> +#
> +# MatchBox LIB
> +#
> +#############################################################
Is it expected that this package isn't associated with any
configuration option ?
> +MATCHBOX_LIB_VERSION = 1.9
> +MATCHBOX_LIB_SOURCE = libmatchbox-$(MATCHBOX_LIB_VERSION).tar.bz2
> +MATCHBOX_LIB_SITE = http://matchbox-project.org/sources/libmatchbox/$(MATCHBOX_LIB_VERSION)
> +MATCHBOX_LIB_AUTORECONF = NO
Default value.
> +++ b/package/matchbox/matchbox-panel/matchbox-panel.mk
> @@ -0,0 +1,25 @@
> +#############################################################
> +#
> +# MatchBox Panel
> +#
> +#############################################################
> +
> +MATCHBOX_PANEL_VERSION = 0.9.3
> +MATCHBOX_PANEL_SOURCE = matchbox-panel-$(MATCHBOX_PANEL_VERSION).tar.bz2
> +MATCHBOX_PANEL_SITE = http://matchbox-project.org/sources/matchbox-panel/$(MATCHBOX_PANEL_VERSION)
> +MATCHBOX_PANEL_AUTORECONF = NO
Same thing :-)
> +MATCHBOX_STARTUP_MONITOR_VERSION = 0.1
> +MATCHBOX_STARTUP_MONITOR_SOURCE = mb-applet-startup-monitor-$(MATCHBOX_STARTUP_MONITOR_VERSION).tar.bz2
> +MATCHBOX_STARTUP_MONITOR_SITE = http://matchbox-project.org/sources/mb-applet-startup-monitor/$(MATCHBOX_STARTUP_MONITOR_VERSION)
> +MATCHBOX_STARTUP_MONITOR_AUTORECONF = NO
Ditto.
> +MATCHBOX_STARTUP_MONITOR_LIBTOOL_PATCH = NO
> +MATCHBOX_STARTUP_MONITOR_DEPENDENCIES = matchbox-lib startup-notification
> +MATCHBOX_STARTUP_MONITOR_CONF_OPT =
Ditto.
> +MATCHBOX_WM_AUTORECONF = NO
Ditto.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-03-25 22:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 19:49 [Buildroot] [Patch]matchbox: convert to autotools William Wagner
2010-03-25 22:49 ` Thomas Petazzoni [this message]
2010-03-26 12:17 ` William Wagner
2010-04-01 10:10 ` [Buildroot] [PATCH] matchbox: convert to autotools, fix build with start-notification, fix build with libxft Will Wagner
2010-04-01 10:35 ` Peter Korsgaard
2010-04-03 11:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325234920.5dae5e04@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox