From: William Wagner <will_wagner@carallon.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch]matchbox: convert to autotools
Date: Fri, 26 Mar 2010 12:17:51 +0000 [thread overview]
Message-ID: <4BACA5EF.3000400@carallon.com> (raw)
In-Reply-To: <20100325234920.5dae5e04@surf>
On 25/03/2010 22:49, Thomas Petazzoni wrote:
> Hello William,
>
> Thanks a lot for doing this work! Next time, to ease the review process,
> could you send your patch inline ? git send-email will do it for you.
>
Will give git send-email a try. have to resolve some dependency problems
on my debian box before I can install it, but I'm sure it shouldn't be
too hard.
> A few minor comments below :
>
> On Mon, 22 Mar 2010 19:49:42 +0000
> William Wagner<will_wagner@carallon.com> wrote:
>
>
>> +++ b/package/matchbox/matchbox-common/matchbox-common.mk
>> @@ -0,0 +1,16 @@
>> +#############################################################
>> +#
>> +# MatchBox Common
>> +#
>> +#############################################################
>> +
>> +MATCHBOX_COMMON_VERSION = 0.9.1
>> +MATCHBOX_COMMON_SOURCE = matchbox-common-$(MATCHBOX_COMMON_VERSION).tar.bz2
>> +MATCHBOX_COMMON_SITE = http://matchbox-project.org/sources/matchbox-common/$(MATCHBOX_COMMON_VERSION)
>> +MATCHBOX_COMMON_AUTORECONF = NO
>>
> Unneeded, this is the default value.
>
Wasn't aware that was the default. Will update accordingly and resubmit
patch.
>> +++ b/package/matchbox/matchbox-lib/matchbox-lib.mk
>> @@ -0,0 +1,59 @@
>> +#############################################################
>> +#
>> +# MatchBox LIB
>> +#
>> +#############################################################
>>
> Is it expected that this package isn't associated with any
> configuration option ?
>
>
I have just copied how matchbox worked before. By adding the window
manager the library is automatically build, so it's not visible in the
config menu. Not difficult to change, nut the library is very unlikely
to be of use on it's own.
--
------------------------------------------------------------------------
Will Wagner will_wagner at carallon.com
Development Manager Office Tel: +44 (0)20 7371 2032
Carallon Ltd, Studio G20, Shepherds Building, Rockley Rd, London W14 0DA
------------------------------------------------------------------------
next prev parent reply other threads:[~2010-03-26 12:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 19:49 [Buildroot] [Patch]matchbox: convert to autotools William Wagner
2010-03-25 22:49 ` Thomas Petazzoni
2010-03-26 12:17 ` William Wagner [this message]
2010-04-01 10:10 ` [Buildroot] [PATCH] matchbox: convert to autotools, fix build with start-notification, fix build with libxft Will Wagner
2010-04-01 10:35 ` Peter Korsgaard
2010-04-03 11:46 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BACA5EF.3000400@carallon.com \
--to=will_wagner@carallon.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox