Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] xkeyboard-config: Depends on intltool
Date: Sat, 5 Jun 2010 17:30:38 +0200	[thread overview]
Message-ID: <20100605173038.1734bd81@surf> (raw)
In-Reply-To: <000f01caf97b$a06e5780$e14b0680$@pauljones.id.au>

Hello Paul,

I still think this is wrong. intltool is required on the host, no on
the target. So:

 * There should be no modification in the Config.in file

 * The dependency in the .mk should be on host-intltool instead

Cheers,

Thomas

On Sat, 22 May 2010 16:54:27 +1000
"Paul Jones" <paul@pauljones.id.au> wrote:

> diff --git a/package/x11r7/xkeyboard-config/Config.in b/package/x11r7/xkeyboard-config/Config.in
> index 8e27dac..a84679c 100644
> --- a/package/x11r7/xkeyboard-config/Config.in
> +++ b/package/x11r7/xkeyboard-config/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_XKEYBOARD_CONFIG
>  	bool "xkeyboard-config"
>  	select BR2_PACKAGE_XAPP_XKBCOMP
> +	select BR2_PACKAGE_INTLTOOL
>  	help
>  	  keyboard configuration database for X
>  
> diff --git a/package/x11r7/xkeyboard-config/xkeyboard-config.mk b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> index 9c9c8b5..3cbfba2 100644
> --- a/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> +++ b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> @@ -10,6 +10,7 @@ XKEYBOARD_CONFIG_AUTORECONF = NO
>  XKEYBOARD_CONFIG_INSTALL_STAGING = NO
>  XKEYBOARD_CONFIG_INSTALL_TARGET = YES
>  XKEYBOARD_CONFIG_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
> +XKEYBOARD_CONFIG_DEPENDENCIES = intltool
>  
>  XKEYBOARD_CONFIG_CONF_OPT = GMSGFMT=/usr/bin/msgfmt
>  


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2010-06-05 15:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-22  6:54 [Buildroot] [PATCH] xkeyboard-config: Depends on intltool Paul Jones
2010-06-05 15:30 ` Thomas Petazzoni [this message]
2010-06-05 23:01   ` Paul Jones
  -- strict thread matches above, loose matches on Subject: below --
2010-05-22  6:44 Paul Jones
2010-05-22  7:48 ` Thomas Petazzoni
2010-05-22  8:02   ` Paul Jones
2010-05-22  6:25 Paul Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100605173038.1734bd81@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox