[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Paul Jones]

From: Paul Jones <peejay@peejay-ubuntu.(none)>

Signed-off-by: Paul Jones <paul@pauljones.id.au>
---
 package/x11r7/xkeyboard-config/Config.in           |    1 +
 package/x11r7/xkeyboard-config/xkeyboard-config.mk |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/package/x11r7/xkeyboard-config/Config.in b/package/x11r7/xkeyboard-config/Config.in
index 8e27dac..a84679c 100644
--- a/package/x11r7/xkeyboard-config/Config.in
+++ b/package/x11r7/xkeyboard-config/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XKEYBOARD_CONFIG
 	bool "xkeyboard-config"
 	select BR2_PACKAGE_XAPP_XKBCOMP
+	select BR2_PACKAGE_INTLTOOL
 	help
 	  keyboard configuration database for X
 
diff --git a/package/x11r7/xkeyboard-config/xkeyboard-config.mk b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
index 9c9c8b5..3cbfba2 100644
--- a/package/x11r7/xkeyboard-config/xkeyboard-config.mk
+++ b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
@@ -10,6 +10,7 @@ XKEYBOARD_CONFIG_AUTORECONF = NO
 XKEYBOARD_CONFIG_INSTALL_STAGING = NO
 XKEYBOARD_CONFIG_INSTALL_TARGET = YES
 XKEYBOARD_CONFIG_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
+XKEYBOARD_CONFIG_DEPENDENCIES = intltool
 
 XKEYBOARD_CONFIG_CONF_OPT = GMSGFMT=/usr/bin/msgfmt
 
-- 
1.7.0.4

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Paul Jones]

Signed-off-by: Paul Jones <paul@pauljones.id.au>
---
 package/x11r7/xkeyboard-config/Config.in           |    1 +
 package/x11r7/xkeyboard-config/xkeyboard-config.mk |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/package/x11r7/xkeyboard-config/Config.in b/package/x11r7/xkeyboard-config/Config.in
index 8e27dac..a84679c 100644
--- a/package/x11r7/xkeyboard-config/Config.in
+++ b/package/x11r7/xkeyboard-config/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_XKEYBOARD_CONFIG
 	bool "xkeyboard-config"
 	select BR2_PACKAGE_XAPP_XKBCOMP
+	select BR2_PACKAGE_INTLTOOL
 	help
 	  keyboard configuration database for X
 
diff --git a/package/x11r7/xkeyboard-config/xkeyboard-config.mk b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
index 9c9c8b5..3cbfba2 100644
--- a/package/x11r7/xkeyboard-config/xkeyboard-config.mk
+++ b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
@@ -10,6 +10,7 @@ XKEYBOARD_CONFIG_AUTORECONF = NO
 XKEYBOARD_CONFIG_INSTALL_STAGING = NO
 XKEYBOARD_CONFIG_INSTALL_TARGET = YES
 XKEYBOARD_CONFIG_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
+XKEYBOARD_CONFIG_DEPENDENCIES = intltool
 
 XKEYBOARD_CONFIG_CONF_OPT = GMSGFMT=/usr/bin/msgfmt
 
-- 
1.7.0.4

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Paul Jones]

Sorry for sending this as an attachment but git send-email wasn't making it
to the list.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100522/262ed7c9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-xkeyboard-config-Depends-on-intltool.patch
Type: application/octet-stream
Size: 1418 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100522/262ed7c9/attachment-0001.obj>

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Thomas Petazzoni]

On Sat, 22 May 2010 16:44:36 +1000
Paul Jones <paul@pauljones.id.au> wrote:

> +XKEYBOARD_CONFIG_DEPENDENCIES = intltool

Are you sure it's intltool on the the target that is needed ? I think
it's probably intltool on the host that is needed, isn't it ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Paul Jones]

> -----Original Message-----
> From: buildroot-bounces at busybox.net [mailto:buildroot-
> bounces at busybox.net] On Behalf Of Thomas Petazzoni
> Sent: Saturday, 22 May 2010 5:49 PM
> To: buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH] xkeyboard-config: Depends on intltool
> 
> On Sat, 22 May 2010 16:44:36 +1000
> Paul Jones <paul@pauljones.id.au> wrote:
> 
> > +XKEYBOARD_CONFIG_DEPENDENCIES = intltool
> 
> Are you sure it's intltool on the the target that is needed ? I think it's
probably
> intltool on the host that is needed, isn't it ?

Umm...
 
Oops! Why didn't I think of that?

Ok disregard this patch!



Paul.

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Thomas Petazzoni]

Hello Paul,

I still think this is wrong. intltool is required on the host, no on
the target. So:

 * There should be no modification in the Config.in file

 * The dependency in the .mk should be on host-intltool instead

Cheers,

Thomas

On Sat, 22 May 2010 16:54:27 +1000
"Paul Jones" <paul@pauljones.id.au> wrote:

> diff --git a/package/x11r7/xkeyboard-config/Config.in b/package/x11r7/xkeyboard-config/Config.in
> index 8e27dac..a84679c 100644
> --- a/package/x11r7/xkeyboard-config/Config.in
> +++ b/package/x11r7/xkeyboard-config/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_XKEYBOARD_CONFIG
>  	bool "xkeyboard-config"
>  	select BR2_PACKAGE_XAPP_XKBCOMP
> +	select BR2_PACKAGE_INTLTOOL
>  	help
>  	  keyboard configuration database for X
>  
> diff --git a/package/x11r7/xkeyboard-config/xkeyboard-config.mk b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> index 9c9c8b5..3cbfba2 100644
> --- a/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> +++ b/package/x11r7/xkeyboard-config/xkeyboard-config.mk
> @@ -10,6 +10,7 @@ XKEYBOARD_CONFIG_AUTORECONF = NO
>  XKEYBOARD_CONFIG_INSTALL_STAGING = NO
>  XKEYBOARD_CONFIG_INSTALL_TARGET = YES
>  XKEYBOARD_CONFIG_INSTALL_TARGET_OPT = DESTDIR=$(TARGET_DIR) install
> +XKEYBOARD_CONFIG_DEPENDENCIES = intltool
>  
>  XKEYBOARD_CONFIG_CONF_OPT = GMSGFMT=/usr/bin/msgfmt
>  


-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] xkeyboard-config: Depends on intltool

[Paul Jones]

> -----Original Message-----
> From: buildroot-bounces at busybox.net [mailto:buildroot- 
> bounces at busybox.net] On Behalf Of Thomas Petazzoni
> Sent: Sunday, 6 June 2010 1:31 AM
> To: buildroot at busybox.net
> Subject: Re: [Buildroot] [PATCH] xkeyboard-config: Depends on intltool
> 
> Hello Paul,
> 
> I still think this is wrong. intltool is required on the host, no on
the target. So:
> 
>  * There should be no modification in the Config.in file
> 
>  * The dependency in the .mk should be on host-intltool instead

Yes, you're right. On further investigation I think what happened was I
tested the patch on a different system without realising. Depending on where
I am and what I'm doing I use either Ubuntu or Gentoo build hosts.
The problem occurred on Ubuntu so I made that patch but I tested it later on
the Gentoo system which has intltool already so it looked like I fixed the
problem.

I've modified the patch and tested it on the right system this time...


Regards,
Paul.