Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
@ 2010-06-03  5:36 Baruch Siach
  2010-06-07  4:33 ` Baruch Siach
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Baruch Siach @ 2010-06-03  5:36 UTC (permalink / raw)
  To: buildroot

The lo interface is marked auto in /etc/network/interfaces, so the
configuration of the loopback network interface is part of the
S40network init script. This causes the "RTNETLINK answers: File exists" error
message to appear at startup time.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 .../Atmel/root/target_busybox_skeleton/etc/inittab |    2 --
 .../device/Atmel/root/target_skeleton/etc/inittab  |    2 --
 target/device/xtensa/skeleton-patch/etc/inittab    |    2 --
 target/generic/target_busybox_skeleton/etc/inittab |    2 --
 target/generic/target_skeleton/etc/inittab         |    2 --
 5 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/target/device/Atmel/root/target_busybox_skeleton/etc/inittab b/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
index bb18305..b394548 100644
--- a/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
+++ b/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
@@ -24,8 +24,6 @@
 ::sysinit:/bin/mount -o remount,rw /
 ::sysinit:/bin/mount -a
 ::sysinit:/bin/hostname -F /etc/hostname
-::sysinit:/sbin/ifconfig lo 127.0.0.1 up
-::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
diff --git a/target/device/Atmel/root/target_skeleton/etc/inittab b/target/device/Atmel/root/target_skeleton/etc/inittab
index 69e4df1..2e3b9a4 100644
--- a/target/device/Atmel/root/target_skeleton/etc/inittab
+++ b/target/device/Atmel/root/target_skeleton/etc/inittab
@@ -18,8 +18,6 @@ null::sysinit:/bin/mount -o remount,rw /
 null::sysinit:/bin/mount -t proc proc /proc
 null::sysinit:/bin/mount -a
 null::sysinit:/bin/hostname -F /etc/hostname
-null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
-null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
diff --git a/target/device/xtensa/skeleton-patch/etc/inittab b/target/device/xtensa/skeleton-patch/etc/inittab
index b336ff6..de3ce70 100644
--- a/target/device/xtensa/skeleton-patch/etc/inittab
+++ b/target/device/xtensa/skeleton-patch/etc/inittab
@@ -18,8 +18,6 @@ null::sysinit:/bin/mount -t proc proc /proc
 null::sysinit:/bin/mount -o remount,rw /
 null::sysinit:/bin/mount -a
 null::sysinit:/bin/hostname -F /etc/hostname
-null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
-null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
diff --git a/target/generic/target_busybox_skeleton/etc/inittab b/target/generic/target_busybox_skeleton/etc/inittab
index 7c7bf7a..bd3912b 100644
--- a/target/generic/target_busybox_skeleton/etc/inittab
+++ b/target/generic/target_busybox_skeleton/etc/inittab
@@ -24,8 +24,6 @@
 ::sysinit:/bin/mount -o remount,rw /
 ::sysinit:/bin/mount -a
 ::sysinit:/bin/hostname -F /etc/hostname
-::sysinit:/sbin/ifconfig lo 127.0.0.1 up
-::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
diff --git a/target/generic/target_skeleton/etc/inittab b/target/generic/target_skeleton/etc/inittab
index 2949c91..4be14b8 100644
--- a/target/generic/target_skeleton/etc/inittab
+++ b/target/generic/target_skeleton/etc/inittab
@@ -19,8 +19,6 @@ null::sysinit:/bin/mount -t proc proc /proc
 null::sysinit:/bin/mkdir -p /dev/pts
 null::sysinit:/bin/mount -a
 null::sysinit:/bin/hostname -F /etc/hostname
-null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
-null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
 # now run any rc scripts
 ::sysinit:/etc/init.d/rcS
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
  2010-06-03  5:36 [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab Baruch Siach
@ 2010-06-07  4:33 ` Baruch Siach
  2010-06-07  7:23 ` Thomas Petazzoni
  2010-06-09 11:39 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Baruch Siach @ 2010-06-07  4:33 UTC (permalink / raw)
  To: buildroot

Hi Buildroot list,

Ping?
Any comment on this?

baruch

On Thu, Jun 03, 2010 at 08:36:50AM +0300, Baruch Siach wrote:
> The lo interface is marked auto in /etc/network/interfaces, so the
> configuration of the loopback network interface is part of the
> S40network init script. This causes the "RTNETLINK answers: File exists" error
> message to appear at startup time.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  .../Atmel/root/target_busybox_skeleton/etc/inittab |    2 --
>  .../device/Atmel/root/target_skeleton/etc/inittab  |    2 --
>  target/device/xtensa/skeleton-patch/etc/inittab    |    2 --
>  target/generic/target_busybox_skeleton/etc/inittab |    2 --
>  target/generic/target_skeleton/etc/inittab         |    2 --
>  5 files changed, 0 insertions(+), 10 deletions(-)
> 
> diff --git a/target/device/Atmel/root/target_busybox_skeleton/etc/inittab b/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
> index bb18305..b394548 100644
> --- a/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
> +++ b/target/device/Atmel/root/target_busybox_skeleton/etc/inittab
> @@ -24,8 +24,6 @@
>  ::sysinit:/bin/mount -o remount,rw /
>  ::sysinit:/bin/mount -a
>  ::sysinit:/bin/hostname -F /etc/hostname
> -::sysinit:/sbin/ifconfig lo 127.0.0.1 up
> -::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> diff --git a/target/device/Atmel/root/target_skeleton/etc/inittab b/target/device/Atmel/root/target_skeleton/etc/inittab
> index 69e4df1..2e3b9a4 100644
> --- a/target/device/Atmel/root/target_skeleton/etc/inittab
> +++ b/target/device/Atmel/root/target_skeleton/etc/inittab
> @@ -18,8 +18,6 @@ null::sysinit:/bin/mount -o remount,rw /
>  null::sysinit:/bin/mount -t proc proc /proc
>  null::sysinit:/bin/mount -a
>  null::sysinit:/bin/hostname -F /etc/hostname
> -null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
> -null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> diff --git a/target/device/xtensa/skeleton-patch/etc/inittab b/target/device/xtensa/skeleton-patch/etc/inittab
> index b336ff6..de3ce70 100644
> --- a/target/device/xtensa/skeleton-patch/etc/inittab
> +++ b/target/device/xtensa/skeleton-patch/etc/inittab
> @@ -18,8 +18,6 @@ null::sysinit:/bin/mount -t proc proc /proc
>  null::sysinit:/bin/mount -o remount,rw /
>  null::sysinit:/bin/mount -a
>  null::sysinit:/bin/hostname -F /etc/hostname
> -null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
> -null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> diff --git a/target/generic/target_busybox_skeleton/etc/inittab b/target/generic/target_busybox_skeleton/etc/inittab
> index 7c7bf7a..bd3912b 100644
> --- a/target/generic/target_busybox_skeleton/etc/inittab
> +++ b/target/generic/target_busybox_skeleton/etc/inittab
> @@ -24,8 +24,6 @@
>  ::sysinit:/bin/mount -o remount,rw /
>  ::sysinit:/bin/mount -a
>  ::sysinit:/bin/hostname -F /etc/hostname
> -::sysinit:/sbin/ifconfig lo 127.0.0.1 up
> -::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> diff --git a/target/generic/target_skeleton/etc/inittab b/target/generic/target_skeleton/etc/inittab
> index 2949c91..4be14b8 100644
> --- a/target/generic/target_skeleton/etc/inittab
> +++ b/target/generic/target_skeleton/etc/inittab
> @@ -19,8 +19,6 @@ null::sysinit:/bin/mount -t proc proc /proc
>  null::sysinit:/bin/mkdir -p /dev/pts
>  null::sysinit:/bin/mount -a
>  null::sysinit:/bin/hostname -F /etc/hostname
> -null::sysinit:/sbin/ifconfig lo 127.0.0.1 up
> -null::sysinit:/sbin/route add -net 127.0.0.0 netmask 255.0.0.0 lo
>  # now run any rc scripts
>  ::sysinit:/etc/init.d/rcS
>  
> -- 
> 1.7.1
> 

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
  2010-06-03  5:36 [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab Baruch Siach
  2010-06-07  4:33 ` Baruch Siach
@ 2010-06-07  7:23 ` Thomas Petazzoni
  2010-06-09  1:58   ` Baruch Siach
  2010-06-09 11:39 ` Peter Korsgaard
  2 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2010-06-07  7:23 UTC (permalink / raw)
  To: buildroot

On Thu,  3 Jun 2010 08:36:50 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> The lo interface is marked auto in /etc/network/interfaces, so the
> configuration of the loopback network interface is part of the
> S40network init script. This causes the "RTNETLINK answers: File exists" error
> message to appear at startup time.

Not tested, but I think it's ok.

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
  2010-06-07  7:23 ` Thomas Petazzoni
@ 2010-06-09  1:58   ` Baruch Siach
  2010-06-09  6:31     ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Baruch Siach @ 2010-06-09  1:58 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On Mon, Jun 07, 2010 at 09:23:12AM +0200, Thomas Petazzoni wrote:
> On Thu,  3 Jun 2010 08:36:50 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
> 
> > The lo interface is marked auto in /etc/network/interfaces, so the
> > configuration of the loopback network interface is part of the
> > S40network init script. This causes the "RTNETLINK answers: File exists" error
> > message to appear at startup time.
> 
> Not tested, but I think it's ok.
> 
> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thanks.

Any chance of this being accepted upstream?

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
  2010-06-09  1:58   ` Baruch Siach
@ 2010-06-09  6:31     ` Thomas Petazzoni
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2010-06-09  6:31 UTC (permalink / raw)
  To: buildroot

On Wed, 9 Jun 2010 04:58:35 +0300
Baruch Siach <baruch@tkos.co.il> wrote:

> > > The lo interface is marked auto in /etc/network/interfaces, so the
> > > configuration of the loopback network interface is part of the
> > > S40network init script. This causes the "RTNETLINK answers: File
> > > exists" error message to appear at startup time.
> > 
> > Not tested, but I think it's ok.
> > 
> > Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Thanks.
> 
> Any chance of this being accepted upstream?

Yes. Just wait for Peter (Buildroot's maintainer) to pick up your
patch. It may take a few days for this to happen. If we haven't merged
your patch in one week from now, then ping us again.

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab
  2010-06-03  5:36 [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab Baruch Siach
  2010-06-07  4:33 ` Baruch Siach
  2010-06-07  7:23 ` Thomas Petazzoni
@ 2010-06-09 11:39 ` Peter Korsgaard
  2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2010-06-09 11:39 UTC (permalink / raw)
  To: buildroot

>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 Baruch> The lo interface is marked auto in /etc/network/interfaces, so the
 Baruch> configuration of the loopback network interface is part of the
 Baruch> S40network init script. This causes the "RTNETLINK answers: File exists" error
 Baruch> message to appear at startup time.

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-06-09 11:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-03  5:36 [Buildroot] [PATCH] skeleton: remove loopback interface configuration from inittab Baruch Siach
2010-06-07  4:33 ` Baruch Siach
2010-06-07  7:23 ` Thomas Petazzoni
2010-06-09  1:58   ` Baruch Siach
2010-06-09  6:31     ` Thomas Petazzoni
2010-06-09 11:39 ` Peter Korsgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox