Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] CTRL+C in menuconfig deletes .config
Date: Tue, 16 Nov 2010 15:48:22 +0100	[thread overview]
Message-ID: <20101116154822.56bea50f@surf> (raw)
In-Reply-To: <201011160923.42622.vapier@gentoo.org>

Hello,

On Tue, 16 Nov 2010 09:23:42 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> i dont know why the menuconfig target has this logic:
>     @if ! $(COMMON_CONFIG_ENV) $< $(CONFIG_CONFIG_IN); then \
>         test -f $(CONFIG_DIR)/.config.cmd || rm -f $(CONFIG_DIR)/.config; \
>     fi
> 
> but it causes severely undesirable behavior.  if i do:
> 	make menuconfig
> 	<change some things & save>
> 	make menuconfig
> 	<change some things but change my mind and hit CTRL+C>
> 
> the build system deletes the .config file.

After a quick dig in Buildroot git history, I found the commit that
introduced this:

commit 153b1beaeb02e1d4780428c0387b7003644e402b
Author: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Date:   Fri Jul 27 12:37:30 2007 +0000

    - fix building mconf with curses flags
    - make sure to rm .config when the first 'make menuconfig' was
      interrupted and thus no .config.cmd was created.

The test "test -f $(CONFIG_DIR)/.config.cmd" is supposed to prevent the
behaviour you're seeing, but the thing is that this file no longer
seems to be generated. I haven't had the time to understand why.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101116/a024cf3b/attachment.pgp>

  reply	other threads:[~2010-11-16 14:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-16 14:23 [Buildroot] CTRL+C in menuconfig deletes .config Mike Frysinger
2010-11-16 14:48 ` Thomas Petazzoni [this message]
2010-11-24 14:33   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101116154822.56bea50f@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox