[Buildroot] CTRL+C in menuconfig deletes .config

[Buildroot] CTRL+C in menuconfig deletes .config

[Mike Frysinger]

i dont know why the menuconfig target has this logic:
    @if ! $(COMMON_CONFIG_ENV) $< $(CONFIG_CONFIG_IN); then \
        test -f $(CONFIG_DIR)/.config.cmd || rm -f $(CONFIG_DIR)/.config; \
    fi

but it causes severely undesirable behavior.  if i do:
	make menuconfig
	<change some things & save>
	make menuconfig
	<change some things but change my mind and hit CTRL+C>

the build system deletes the .config file.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101116/01daa3ba/attachment.pgp>

[Buildroot] CTRL+C in menuconfig deletes .config

[Thomas Petazzoni]

Hello,

On Tue, 16 Nov 2010 09:23:42 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> i dont know why the menuconfig target has this logic:
>     @if ! $(COMMON_CONFIG_ENV) $< $(CONFIG_CONFIG_IN); then \
>         test -f $(CONFIG_DIR)/.config.cmd || rm -f $(CONFIG_DIR)/.config; \
>     fi
> 
> but it causes severely undesirable behavior.  if i do:
> 	make menuconfig
> 	<change some things & save>
> 	make menuconfig
> 	<change some things but change my mind and hit CTRL+C>
> 
> the build system deletes the .config file.

After a quick dig in Buildroot git history, I found the commit that
introduced this:

commit 153b1beaeb02e1d4780428c0387b7003644e402b
Author: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Date:   Fri Jul 27 12:37:30 2007 +0000

    - fix building mconf with curses flags
    - make sure to rm .config when the first 'make menuconfig' was
      interrupted and thus no .config.cmd was created.

The test "test -f $(CONFIG_DIR)/.config.cmd" is supposed to prevent the
behaviour you're seeing, but the thing is that this file no longer
seems to be generated. I haven't had the time to understand why.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101116/a024cf3b/attachment.pgp>

[Buildroot] CTRL+C in menuconfig deletes .config

[Peter Korsgaard]

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

 Thomas> After a quick dig in Buildroot git history, I found the commit that
 Thomas> introduced this:

 Thomas> commit 153b1beaeb02e1d4780428c0387b7003644e402b
 Thomas> Author: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
 Thomas> Date:   Fri Jul 27 12:37:30 2007 +0000

 Thomas>     - fix building mconf with curses flags
 Thomas>     - make sure to rm .config when the first 'make menuconfig' was
 Thomas>       interrupted and thus no .config.cmd was created.

 Thomas> The test "test -f $(CONFIG_DIR)/.config.cmd" is supposed to prevent the
 Thomas> behaviour you're seeing, but the thing is that this file no longer
 Thomas> seems to be generated. I haven't had the time to understand why.

I believe it was from one of the mconf changes Bernhard did that we're
not using anymore. I've removed it in git.

-- 
Bye, Peter Korsgaard