From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: drop LDFLAGS override
Date: Wed, 17 Nov 2010 10:44:36 +0100 [thread overview]
Message-ID: <20101117104436.3114edb1@surf> (raw)
In-Reply-To: <1289985078-3333-1-git-send-email-vapier@gentoo.org>
On Wed, 17 Nov 2010 04:11:18 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> The current linux code overrides LDFLAGS that the kernel itself might
> be setting up. Looking at the history, there doesn't seem to be any
> reason for this override. It was added in ea8b1fa6a60705 without any
> logic.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
The code in linux/linux.mk was more or less loosely inspired from the
old Linux compilation code, which (I checked) already had this LDFLAGS
thing, from the very beginning (commit
453dca995ee437b2f6fc3e0a6e4e2b4317346dae from october 2007). Obviously,
I don't see why passing TARGET_LDFLAGS is needed, so:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-11-17 9:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 9:11 [Buildroot] [PATCH] linux: drop LDFLAGS override Mike Frysinger
2010-11-17 9:44 ` Thomas Petazzoni [this message]
2010-12-07 22:02 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101117104436.3114edb1@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox