* [Buildroot] [PATCH] linux: drop LDFLAGS override
@ 2010-11-17 9:11 Mike Frysinger
2010-11-17 9:44 ` Thomas Petazzoni
2010-12-07 22:02 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Mike Frysinger @ 2010-11-17 9:11 UTC (permalink / raw)
To: buildroot
The current linux code overrides LDFLAGS that the kernel itself might be
setting up. Looking at the history, there doesn't seem to be any reason
for this override. It was added in ea8b1fa6a60705 without any logic.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
linux/linux.mk | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/linux/linux.mk b/linux/linux.mk
index 17c4b48..67b68ce 100644
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -31,7 +31,6 @@ LINUX26_MAKE_FLAGS = \
ARCH=$(KERNEL_ARCH) \
INSTALL_MOD_PATH=$(TARGET_DIR) \
CROSS_COMPILE=$(TARGET_CROSS) \
- LDFLAGS="$(TARGET_LDFLAGS)" \
LZMA="$(LZMA)"
ifneq ($(LINUX26_SOURCE_DIR),$(LINUX26_BUILD_DIR))
LINUX26_MAKE_FLAGS += O="$(LINUX26_BUILD_DIR)"
--
1.7.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] linux: drop LDFLAGS override
2010-11-17 9:11 [Buildroot] [PATCH] linux: drop LDFLAGS override Mike Frysinger
@ 2010-11-17 9:44 ` Thomas Petazzoni
2010-12-07 22:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2010-11-17 9:44 UTC (permalink / raw)
To: buildroot
On Wed, 17 Nov 2010 04:11:18 -0500
Mike Frysinger <vapier@gentoo.org> wrote:
> The current linux code overrides LDFLAGS that the kernel itself might
> be setting up. Looking at the history, there doesn't seem to be any
> reason for this override. It was added in ea8b1fa6a60705 without any
> logic.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
The code in linux/linux.mk was more or less loosely inspired from the
old Linux compilation code, which (I checked) already had this LDFLAGS
thing, from the very beginning (commit
453dca995ee437b2f6fc3e0a6e4e2b4317346dae from october 2007). Obviously,
I don't see why passing TARGET_LDFLAGS is needed, so:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] linux: drop LDFLAGS override
2010-11-17 9:11 [Buildroot] [PATCH] linux: drop LDFLAGS override Mike Frysinger
2010-11-17 9:44 ` Thomas Petazzoni
@ 2010-12-07 22:02 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2010-12-07 22:02 UTC (permalink / raw)
To: buildroot
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> The current linux code overrides LDFLAGS that the kernel itself might be
Mike> setting up. Looking at the history, there doesn't seem to be any reason
Mike> for this override. It was added in ea8b1fa6a60705 without any logic.
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-07 22:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-17 9:11 [Buildroot] [PATCH] linux: drop LDFLAGS override Mike Frysinger
2010-11-17 9:44 ` Thomas Petazzoni
2010-12-07 22:02 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox