[Buildroot] [PATCH] gdb: drop local stripping in favor of top level

[Buildroot] [PATCH] gdb: drop local stripping in favor of top level

[Mike Frysinger]

Since the top level takes care of stripping for us, and some file formats
cannot be stripped safely (like FLAT which will error out), simply punt
the manual stripping from the gdb package.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 toolchain/gdb/gdb.mk |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/toolchain/gdb/gdb.mk b/toolchain/gdb/gdb.mk
index c4fef89..54c3905 100644
--- a/toolchain/gdb/gdb.mk
+++ b/toolchain/gdb/gdb.mk
@@ -97,7 +97,6 @@ $(GDB_TARGET_DIR)/gdb/gdb: $(GDB_TARGET_DIR)/.configured
 	gdb_cv_var_elf=yes \
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_TARGET_DIR)
-	$(STRIPCMD) $(GDB_TARGET_DIR)/gdb/gdb
 
 $(TARGET_DIR)/usr/bin/gdb: $(GDB_TARGET_DIR)/gdb/gdb
 	install -c -D $(GDB_TARGET_DIR)/gdb/gdb $(TARGET_DIR)/usr/bin/gdb
@@ -152,7 +151,6 @@ $(GDB_SERVER_DIR)/.configured: $(GDB_DIR)/.unpacked
 $(GDB_SERVER_DIR)/gdbserver: $(GDB_SERVER_DIR)/.configured
 	$(MAKE) CC="$(TARGET_CC)" MT_CFLAGS="$(TARGET_CFLAGS)" \
 		-C $(GDB_SERVER_DIR)
-	$(STRIPCMD) $(GDB_SERVER_DIR)/gdbserver
 
 $(TARGET_DIR)/usr/bin/gdbserver: $(GDB_SERVER_DIR)/gdbserver
 ifeq ($(BR2_CROSS_TOOLCHAIN_TARGET_UTILS),y)
-- 
1.7.3.2

[Buildroot] [PATCH] gdb: drop local stripping in favor of top level

[Thomas Petazzoni]

On Thu, 18 Nov 2010 05:26:51 -0500
Mike Frysinger <vapier@gentoo.org> wrote:

> Since the top level takes care of stripping for us, and some file
> formats cannot be stripped safely (like FLAT which will error out),
> simply punt the manual stripping from the gdb package.
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

BTW, since you're using the FLAT binary format, I suspect that you're
using Buildroot on non-MMU systems. Do you have working non-MMU
configurations that we could use for some build tests and potentially
runtime tests ?

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] gdb: drop local stripping in favor of top level

[Peter Korsgaard]

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

 Mike> Since the top level takes care of stripping for us, and some file formats
 Mike> cannot be stripped safely (like FLAT which will error out), simply punt
 Mike> the manual stripping from the gdb package.

Committed, thanks.

-- 
Bye, Peter Korsgaard