Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] New package: fbgrab
@ 2010-12-07 23:22 Daniel Nyström
  2010-12-08 19:30 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Nyström @ 2010-12-07 23:22 UTC (permalink / raw)
  To: buildroot

FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

Signed-off-by: Daniel Nystr?m <daniel.nystrom@timeterminal.se>
---
 package/Config.in                           |    1 +
 package/fbgrab/Config.in                    |    8 ++++++++
 package/fbgrab/fbgrab-proper_makefile.patch |   16 ++++++++++++++++
 package/fbgrab/fbgrab.mk                    |   16 ++++++++++++++++
 4 files changed, 41 insertions(+), 0 deletions(-)
 create mode 100644 package/fbgrab/Config.in
 create mode 100644 package/fbgrab/fbgrab-proper_makefile.patch
 create mode 100644 package/fbgrab/fbgrab.mk

diff --git a/package/Config.in b/package/Config.in
index 08ffda6..2618ecb 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -94,6 +94,7 @@ source "package/directfb/Config.in"
 source "package/directfb-examples/Config.in"
 source "package/divine/Config.in"
 source "package/fbdump/Config.in"
+source "package/fbgrab/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/fbset/Config.in"
 endif
diff --git a/package/fbgrab/Config.in b/package/fbgrab/Config.in
new file mode 100644
index 0000000..0ede91e
--- /dev/null
+++ b/package/fbgrab/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_FBGRAB
+	bool "fbgrab"
+	select BR2_PACKAGE_LIBPNG
+        select BR2_PACKAGE_ZLIB
+	help
+	  FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.
+
+	  http://hem.bredband.net/gmogmo/fbgrab
diff --git a/package/fbgrab/fbgrab-proper_makefile.patch b/package/fbgrab/fbgrab-proper_makefile.patch
new file mode 100644
index 0000000..8f7919e
--- /dev/null
+++ b/package/fbgrab/fbgrab-proper_makefile.patch
@@ -0,0 +1,16 @@
+--- fbgrab-1.0.orig/Makefile	2010-12-07 22:57:24.000000000 +0100
++++ fbgrab-1.0/Makefile	2010-12-07 22:58:36.000000000 +0100
+@@ -3,9 +3,10 @@
+ ### modular. So this is a simple gnu Makefile...
+ ###
+ 
+-fbgrab: fbgrab.c
+-	splint +posixlib fbgrab.c
+-	gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
++LDFLAGS += -lpng -lz
++
++fbgrab: fbgrab.o
++	$(CC) $(LDFLAGS) fbgrab.o -o $@
+ 
+ install:
+ 	strip fbgrab
diff --git a/package/fbgrab/fbgrab.mk b/package/fbgrab/fbgrab.mk
new file mode 100644
index 0000000..459fd37
--- /dev/null
+++ b/package/fbgrab/fbgrab.mk
@@ -0,0 +1,16 @@
+FBGRAB_VERSION = 1.0
+FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
+FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
+FBGRAB_DEPENDENCIES = libpng zlib
+
+define FBGRAB_BUILD_CMDS
+	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
+		LDFLAGS="$(TARGET_LDFLAGS)" \
+		$(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
+endef
+
+define FBGRAB_INSTALL_TARGET_CMDS
+	$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(call GENTARGETS,package,fbgrab))
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] New package: fbgrab
  2010-12-07 23:22 [Buildroot] [PATCH] New package: fbgrab Daniel Nyström
@ 2010-12-08 19:30 ` Thomas Petazzoni
  2010-12-09 15:32   ` Daniel Nyström
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2010-12-08 19:30 UTC (permalink / raw)
  To: buildroot

Hello,

Thanks for proposing this package!

On Wed,  8 Dec 2010 00:22:50 +0100
Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:

> FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

The git commit log should be wrapped at a reasonable limit (~ 80
columns).

> diff --git a/package/fbgrab/Config.in b/package/fbgrab/Config.in
> new file mode 100644
> index 0000000..0ede91e
> --- /dev/null
> +++ b/package/fbgrab/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_FBGRAB
> +	bool "fbgrab"
> +	select BR2_PACKAGE_LIBPNG
> +        select BR2_PACKAGE_ZLIB

Indentation issue. It should be one tab before bool/select/help, and
the help message itself should be indented with one tab + 2 spaces.

> +	help
> +	  FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.

Should be wrapped at a reasonable limit as well.

> diff --git a/package/fbgrab/fbgrab-proper_makefile.patch b/package/fbgrab/fbgrab-proper_makefile.patch
> new file mode 100644
> index 0000000..8f7919e
> --- /dev/null
> +++ b/package/fbgrab/fbgrab-proper_makefile.patch

Peter wants each patch to have a description and an author here.

> @@ -0,0 +1,16 @@
> +--- fbgrab-1.0.orig/Makefile	2010-12-07 22:57:24.000000000 +0100
> ++++ fbgrab-1.0/Makefile	2010-12-07 22:58:36.000000000 +0100
> +@@ -3,9 +3,10 @@
> + ### modular. So this is a simple gnu Makefile...
> + ###
> + 
> +-fbgrab: fbgrab.c
> +-	splint +posixlib fbgrab.c
> +-	gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
> ++LDFLAGS += -lpng -lz
> ++
> ++fbgrab: fbgrab.o
> ++	$(CC) $(LDFLAGS) fbgrab.o -o $@
> + 
> + install:
> + 	strip fbgrab
> diff --git a/package/fbgrab/fbgrab.mk b/package/fbgrab/fbgrab.mk
> new file mode 100644
> index 0000000..459fd37
> --- /dev/null
> +++ b/package/fbgrab/fbgrab.mk
> @@ -0,0 +1,16 @@
> +FBGRAB_VERSION = 1.0
> +FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
> +FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
> +FBGRAB_DEPENDENCIES = libpng zlib
> +
> +define FBGRAB_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
> +		LDFLAGS="$(TARGET_LDFLAGS)" \
> +		$(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
> +endef

Can you try to see if using $(TARGET_CONFIGURE_OPTS) is possible to
pass CFLAGS/LDFLAGS/CC/LD ?

> +define FBGRAB_INSTALL_TARGET_CMDS
> +	$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
> +endef

This will install "fbgrab" as a file named "bin" in $(TARGET_DIR)/usr.
So the line should be :

$(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin/fbgrab

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] New package: fbgrab
  2010-12-08 19:30 ` Thomas Petazzoni
@ 2010-12-09 15:32   ` Daniel Nyström
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Nyström @ 2010-12-09 15:32 UTC (permalink / raw)
  To: buildroot

Thanks for your constructive comments! A new patch has been submitted.

2010/12/8 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> Hello,
>
> Thanks for proposing this package!
>
> On Wed, ?8 Dec 2010 00:22:50 +0100
> Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:
>
>> FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.
>
> The git commit log should be wrapped at a reasonable limit (~ 80
> columns).
>
>> diff --git a/package/fbgrab/Config.in b/package/fbgrab/Config.in
>> new file mode 100644
>> index 0000000..0ede91e
>> --- /dev/null
>> +++ b/package/fbgrab/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_FBGRAB
>> + ? ? bool "fbgrab"
>> + ? ? select BR2_PACKAGE_LIBPNG
>> + ? ? ? ?select BR2_PACKAGE_ZLIB
>
> Indentation issue. It should be one tab before bool/select/help, and
> the help message itself should be indented with one tab + 2 spaces.
>
>> + ? ? help
>> + ? ? ? FBGrab is a framebuffer screenshot program, capturing the linux frambuffer and converting it to a png-picture.
>
> Should be wrapped at a reasonable limit as well.
>
>> diff --git a/package/fbgrab/fbgrab-proper_makefile.patch b/package/fbgrab/fbgrab-proper_makefile.patch
>> new file mode 100644
>> index 0000000..8f7919e
>> --- /dev/null
>> +++ b/package/fbgrab/fbgrab-proper_makefile.patch
>
> Peter wants each patch to have a description and an author here.
>
>> @@ -0,0 +1,16 @@
>> +--- fbgrab-1.0.orig/Makefile 2010-12-07 22:57:24.000000000 +0100
>> ++++ fbgrab-1.0/Makefile ? ? ?2010-12-07 22:58:36.000000000 +0100
>> +@@ -3,9 +3,10 @@
>> + ### modular. So this is a simple gnu Makefile...
>> + ###
>> +
>> +-fbgrab: fbgrab.c
>> +- ? ?splint +posixlib fbgrab.c
>> +- ? ?gcc -g -Wall fbgrab.c -lpng -lz -o fbgrab
>> ++LDFLAGS += -lpng -lz
>> ++
>> ++fbgrab: fbgrab.o
>> ++ ? ?$(CC) $(LDFLAGS) fbgrab.o -o $@
>> +
>> + install:
>> + ? ? strip fbgrab
>> diff --git a/package/fbgrab/fbgrab.mk b/package/fbgrab/fbgrab.mk
>> new file mode 100644
>> index 0000000..459fd37
>> --- /dev/null
>> +++ b/package/fbgrab/fbgrab.mk
>> @@ -0,0 +1,16 @@
>> +FBGRAB_VERSION = 1.0
>> +FBGRAB_SOURCE = fbgrab-$(FBGRAB_VERSION).tar.gz
>> +FBGRAB_SITE = http://hem.bredband.net/gmogmo/fbgrab
>> +FBGRAB_DEPENDENCIES = libpng zlib
>> +
>> +define FBGRAB_BUILD_CMDS
>> + ? ? $(TARGET_MAKE_ENV) CFLAGS="$(TARGET_CFLAGS)" \
>> + ? ? ? ? ? ? LDFLAGS="$(TARGET_LDFLAGS)" \
>> + ? ? ? ? ? ? $(MAKE) -C $(@D) CC="$(TARGET_CC)" LD="$(TARGET_LD)"
>> +endef
>
> Can you try to see if using $(TARGET_CONFIGURE_OPTS) is possible to
> pass CFLAGS/LDFLAGS/CC/LD ?
>
>> +define FBGRAB_INSTALL_TARGET_CMDS
>> + ? ? $(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin
>> +endef
>
> This will install "fbgrab" as a file named "bin" in $(TARGET_DIR)/usr.
> So the line should be :
>
> $(INSTALL) -m 0755 -D $(@D)/fbgrab $(TARGET_DIR)/usr/bin/fbgrab
>
> Regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-09 15:32 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-07 23:22 [Buildroot] [PATCH] New package: fbgrab Daniel Nyström
2010-12-08 19:30 ` Thomas Petazzoni
2010-12-09 15:32   ` Daniel Nyström

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox