[Buildroot] [PATCH] Add libmodbus to buildroot.

[Buildroot] [PATCH] Add libmodbus to buildroot.

[Marek Belisko]

Following patch add compilation of libmodbus use for communication
over modbus protocol.

Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
---
 package/Config.in              |    1 +
 package/libmodbus/Config.in    |    9 +++++++++
 package/libmodbus/libmodbus.mk |    8 ++++++++
 3 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 package/libmodbus/Config.in
 create mode 100644 package/libmodbus/libmodbus.mk

diff --git a/package/Config.in b/package/Config.in
index 80aca2a..b29113c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -203,6 +203,7 @@ source "package/usbmount/Config.in"
 source "package/usbutils/Config.in"
 source "package/wipe/Config.in"
 source "package/xfsprogs/Config.in"
+source "package/libmodbus/Config.in"
 endmenu
 
 menu "Interpreter languages and scripting"
diff --git a/package/libmodbus/Config.in b/package/libmodbus/Config.in
new file mode 100644
index 0000000..99e8952
--- /dev/null
+++ b/package/libmodbus/Config.in
@@ -0,0 +1,9 @@
+config BR2_PACKAGE_LIBMODBUS
+	bool "libmodbus"
+	help
+	  libmodbus is a free software library to send/receive data with
+	  a device which respects the Modbus protocol. This library can
+	  use a serial port or an Ethernet connection.
+
+	  http://http://libmodbus.org
+
diff --git a/package/libmodbus/libmodbus.mk b/package/libmodbus/libmodbus.mk
new file mode 100644
index 0000000..eb03c84
--- /dev/null
+++ b/package/libmodbus/libmodbus.mk
@@ -0,0 +1,8 @@
+############################################################
+# libmodbus
+#############################################################
+LIBMODBUS_VERSION:=2.0.3
+LIBMODBUS_SOURCE:=libmodbus-$(LIBMODBUS_VERSION).tar.gz
+LIBMODBUS_SITE:=http://github.com/downloads/stephane/libmodbus/$(LIBMODBUS_SOURCE)
+
+$(eval $(call AUTOTARGETS,package,libmodbus))
-- 
1.7.1

[Buildroot] [PATCH] Add libmodbus to buildroot.

[Thomas Petazzoni]

Hello Marek,

Thanks for proposing this package! I have a few comments below.

On Tue, 21 Dec 2010 14:15:54 +0100
Marek Belisko <marek.belisko@open-nandra.com> wrote:

> diff --git a/package/Config.in b/package/Config.in
> index 80aca2a..b29113c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -203,6 +203,7 @@ source "package/usbmount/Config.in"
>  source "package/usbutils/Config.in"
>  source "package/wipe/Config.in"
>  source "package/xfsprogs/Config.in"
> +source "package/libmodbus/Config.in"
>  endmenu

libmodbus sounds like a networking library rather than a hardware
handling utility. Therefore, could you move it to "Libraries ->
Networking" ?

Moreover, the entries in each category are alphabetically sorted, so
please put libmodbus at the right location.

> +LIBMODBUS_VERSION:=2.0.3
> +LIBMODBUS_SOURCE:=libmodbus-$(LIBMODBUS_VERSION).tar.gz
> +LIBMODBUS_SITE:=http://github.com/downloads/stephane/libmodbus/$(LIBMODBUS_SOURCE)

Unfortunately, this redirects to a https site, with an invalid
certificate:

ERROR: certificate common name `*.github.com' doesn't match requested
host name `github.com'.

So I had to add --no-check-certificate to wget's command line options.
Not sure what we should do about this :

 *) Always use --no-check-certificate for all downloads

 *) Add a new <pkg>_WGET_NO_CERTIFICATE=YES option to the package
    infrastructure.

 *) Something else ?

Moreover, this package being a library, you certainly want:

LIBMODBUS_INSTALL_STAGING=YES

in order to install headers, pkgconfig file and other stuff to the
$(STAGING_DIR).

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com