Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add package bonnie++
Date: Tue, 1 Feb 2011 22:02:38 +0100	[thread overview]
Message-ID: <20110201220238.2c218fcd@surf> (raw)
In-Reply-To: <1296580740-4790-1-git-send-email-mort@bork.org>

Hello,

On Tue,  1 Feb 2011 12:19:00 -0500
Martin Hicks <mort@bork.org> wrote:

> A good filesystem performance benchmark program
> 
> Signed-off-by: Martin Hicks <mort@bork.org>

Thanks for this package. Some comments below.

> +config BR2_PACKAGE_BONNIE
> +	bool "bonnie++"
> +	help
> +          Filesystem tester

Here the indent should be one tab + two spaces.

> +BONNIE_VERSION = 1.03e
> +BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
> +BONNIE_SITE = http://www.coker.com.au/bonnie++/
> +BONNIE_INSTALL_TARGET_OPT = INSTALL="install -m 0755" install-bin

This is not needed if you override the installation as done below by
BONNE_INSTALL_TARGET_CMDS.

> +define BONNIE_INSTALL_TARGET_CMDS
> +	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++

> +	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-02-01 21:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01 17:19 [Buildroot] [PATCH] Add package bonnie++ Martin Hicks
2011-02-01 21:02 ` Thomas Petazzoni [this message]
2011-02-07 16:28   ` [Buildroot] [PATCH] V2: " Martin Hicks
2011-02-07 17:16     ` Peter Korsgaard
2011-02-08 21:42       ` Martin Hicks
2011-02-14 14:37         ` Martin Hicks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110201220238.2c218fcd@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox