Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Add package bonnie++
@ 2011-02-01 17:19 Martin Hicks
  2011-02-01 21:02 ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Martin Hicks @ 2011-02-01 17:19 UTC (permalink / raw)
  To: buildroot

A good filesystem performance benchmark program

Signed-off-by: Martin Hicks <mort@bork.org>
---
 package/Config.in        |    1 +
 package/bonnie/Config.in |    6 ++++++
 package/bonnie/bonnie.mk |   18 ++++++++++++++++++
 3 files changed, 25 insertions(+), 0 deletions(-)
 create mode 100644 package/bonnie/Config.in
 create mode 100644 package/bonnie/bonnie.mk

diff --git a/package/Config.in b/package/Config.in
index 631bb80..49859b1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -17,6 +17,7 @@ source "package/xz/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
+source "package/bonnie/Config.in"
 source "package/dhrystone/Config.in"
 source "package/dmalloc/Config.in"
 source "package/kexec/Config.in"
diff --git a/package/bonnie/Config.in b/package/bonnie/Config.in
new file mode 100644
index 0000000..6bef13b
--- /dev/null
+++ b/package/bonnie/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BONNIE
+	bool "bonnie++"
+	help
+          Filesystem tester
+
+	  http://www.coker.com.au/bonnie++/
diff --git a/package/bonnie/bonnie.mk b/package/bonnie/bonnie.mk
new file mode 100644
index 0000000..03fce50
--- /dev/null
+++ b/package/bonnie/bonnie.mk
@@ -0,0 +1,18 @@
+#
+# bonnie++
+#
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+BONNIE_INSTALL_TARGET_OPT = INSTALL="install -m 0755" install-bin
+
+define BONNIE_INSTALL_TARGET_CMDS
+	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin
+	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin
+endef
+
+define BONNIE_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+$(eval $(call AUTOTARGETS,package,bonnie))
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] Add package bonnie++
  2011-02-01 17:19 [Buildroot] [PATCH] Add package bonnie++ Martin Hicks
@ 2011-02-01 21:02 ` Thomas Petazzoni
  2011-02-07 16:28   ` [Buildroot] [PATCH] V2: " Martin Hicks
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2011-02-01 21:02 UTC (permalink / raw)
  To: buildroot

Hello,

On Tue,  1 Feb 2011 12:19:00 -0500
Martin Hicks <mort@bork.org> wrote:

> A good filesystem performance benchmark program
> 
> Signed-off-by: Martin Hicks <mort@bork.org>

Thanks for this package. Some comments below.

> +config BR2_PACKAGE_BONNIE
> +	bool "bonnie++"
> +	help
> +          Filesystem tester

Here the indent should be one tab + two spaces.

> +BONNIE_VERSION = 1.03e
> +BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
> +BONNIE_SITE = http://www.coker.com.au/bonnie++/
> +BONNIE_INSTALL_TARGET_OPT = INSTALL="install -m 0755" install-bin

This is not needed if you override the installation as done below by
BONNE_INSTALL_TARGET_CMDS.

> +define BONNIE_INSTALL_TARGET_CMDS
> +	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++

> +	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin

should be

install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] V2: Add package bonnie++
  2011-02-01 21:02 ` Thomas Petazzoni
@ 2011-02-07 16:28   ` Martin Hicks
  2011-02-07 17:16     ` Peter Korsgaard
  0 siblings, 1 reply; 6+ messages in thread
From: Martin Hicks @ 2011-02-07 16:28 UTC (permalink / raw)
  To: buildroot

A good filesystem performance benchmark program.
Fixed up a few things requested by reviewers.

Signed-off-by: Martin Hicks <mort@bork.org>
---
 package/Config.in        |    1 +
 package/bonnie/Config.in |    6 ++++++
 package/bonnie/bonnie.mk |   17 +++++++++++++++++
 3 files changed, 24 insertions(+), 0 deletions(-)
 create mode 100644 package/bonnie/Config.in
 create mode 100644 package/bonnie/bonnie.mk

diff --git a/package/Config.in b/package/Config.in
index 631bb80..49859b1 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -17,6 +17,7 @@ source "package/xz/Config.in"
 endmenu
 
 menu "Debugging, profiling and benchmark"
+source "package/bonnie/Config.in"
 source "package/dhrystone/Config.in"
 source "package/dmalloc/Config.in"
 source "package/kexec/Config.in"
diff --git a/package/bonnie/Config.in b/package/bonnie/Config.in
new file mode 100644
index 0000000..ff4988b
--- /dev/null
+++ b/package/bonnie/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BONNIE
+	bool "bonnie++"
+	help
+	  Filesystem tester
+
+	  http://www.coker.com.au/bonnie++/
diff --git a/package/bonnie/bonnie.mk b/package/bonnie/bonnie.mk
new file mode 100644
index 0000000..87f5fbc
--- /dev/null
+++ b/package/bonnie/bonnie.mk
@@ -0,0 +1,17 @@
+#
+# bonnie++
+#
+BONNIE_VERSION = 1.03e
+BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
+BONNIE_SITE = http://www.coker.com.au/bonnie++/
+
+define BONNIE_INSTALL_TARGET_CMDS
+	install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++
+	install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+define BONNIE_UNINSTALL_TARGET_CMDS
+	rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
+endef
+
+$(eval $(call AUTOTARGETS,package,bonnie))
-- 
1.5.6.5

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] V2: Add package bonnie++
  2011-02-07 16:28   ` [Buildroot] [PATCH] V2: " Martin Hicks
@ 2011-02-07 17:16     ` Peter Korsgaard
  2011-02-08 21:42       ` Martin Hicks
  0 siblings, 1 reply; 6+ messages in thread
From: Peter Korsgaard @ 2011-02-07 17:16 UTC (permalink / raw)
  To: buildroot

>>>>> "Martin" == Martin Hicks <mort@bork.org> writes:

 Martin> A good filesystem performance benchmark program.
 Martin> Fixed up a few things requested by reviewers.

Bonnie++ is implemented in C++, right? If so, you need to depend on
LIBSTDCPP (and add a comment statement if it isn't available) - See
E.G. package/iperf/Config.in for an example.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] V2: Add package bonnie++
  2011-02-07 17:16     ` Peter Korsgaard
@ 2011-02-08 21:42       ` Martin Hicks
  2011-02-14 14:37         ` Martin Hicks
  0 siblings, 1 reply; 6+ messages in thread
From: Martin Hicks @ 2011-02-08 21:42 UTC (permalink / raw)
  To: buildroot


On Mon, Feb 07, 2011 at 06:16:10PM +0100, Peter Korsgaard wrote:
> >>>>> "Martin" == Martin Hicks <mort@bork.org> writes:
> 
>  Martin> A good filesystem performance benchmark program.
>  Martin> Fixed up a few things requested by reviewers.
> 
> Bonnie++ is implemented in C++, right? If so, you need to depend on
> LIBSTDCPP (and add a comment statement if it isn't available) - See
> E.G. package/iperf/Config.in for an example.

Okay.  here's the updated patch:

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH] V2: Add package bonnie++
  2011-02-08 21:42       ` Martin Hicks
@ 2011-02-14 14:37         ` Martin Hicks
  0 siblings, 0 replies; 6+ messages in thread
From: Martin Hicks @ 2011-02-14 14:37 UTC (permalink / raw)
  To: buildroot

Were any other changes needed for this patch?

Thanks,
mh

On Tue, Feb 8, 2011 at 4:42 PM, Martin Hicks <mort@bork.org> wrote:
>
> On Mon, Feb 07, 2011 at 06:16:10PM +0100, Peter Korsgaard wrote:
>> >>>>> "Martin" == Martin Hicks <mort@bork.org> writes:
>>
>> ?Martin> A good filesystem performance benchmark program.
>> ?Martin> Fixed up a few things requested by reviewers.
>>
>> Bonnie++ is implemented in C++, right? If so, you need to depend on
>> LIBSTDCPP (and add a comment statement if it isn't available) - See
>> E.G. package/iperf/Config.in for an example.
>
> Okay. ?here's the updated patch:
>
>
> From 6b6e22d5a981069019db09fa68df5a7de0c892f4 Mon Sep 17 00:00:00 2001
> From: Martin Hicks <mort@bork.org>
> Date: Mon, 31 Jan 2011 15:32:06 -0500
> Subject: [PATCH] Add package bonnie++
>
> A good filesystem performance benchmark program
>
> Signed-off-by: Martin Hicks <mort@bork.org>
> ---
> ?package/Config.in ? ? ? ?| ? ?1 +
> ?package/bonnie/Config.in | ? 10 ++++++++++
> ?package/bonnie/bonnie.mk | ? 17 +++++++++++++++++
> ?3 files changed, 28 insertions(+), 0 deletions(-)
> ?create mode 100644 package/bonnie/Config.in
> ?create mode 100644 package/bonnie/bonnie.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 631bb80..49859b1 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -17,6 +17,7 @@ source "package/xz/Config.in"
> ?endmenu
>
> ?menu "Debugging, profiling and benchmark"
> +source "package/bonnie/Config.in"
> ?source "package/dhrystone/Config.in"
> ?source "package/dmalloc/Config.in"
> ?source "package/kexec/Config.in"
> diff --git a/package/bonnie/Config.in b/package/bonnie/Config.in
> new file mode 100644
> index 0000000..926d917
> --- /dev/null
> +++ b/package/bonnie/Config.in
> @@ -0,0 +1,10 @@
> +config BR2_PACKAGE_BONNIE
> + ? ? ? bool "bonnie++"
> + ? ? ? depends on BR2_INSTALL_LIBSTDCPP
> + ? ? ? help
> + ? ? ? ? Filesystem tester
> +
> + ? ? ? ? http://www.coker.com.au/bonnie++/
> +
> +comment "bonnie requires a toolchain with C++ support enabled"
> + ? ? ? depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/bonnie/bonnie.mk b/package/bonnie/bonnie.mk
> new file mode 100644
> index 0000000..87f5fbc
> --- /dev/null
> +++ b/package/bonnie/bonnie.mk
> @@ -0,0 +1,17 @@
> +#
> +# bonnie++
> +#
> +BONNIE_VERSION = 1.03e
> +BONNIE_SOURCE = bonnie++-$(BONNIE_VERSION).tgz
> +BONNIE_SITE = http://www.coker.com.au/bonnie++/
> +
> +define BONNIE_INSTALL_TARGET_CMDS
> + ? ? ? install -D -m 755 $(@D)/bonnie++ $(TARGET_DIR)/usr/sbin/bonnie++
> + ? ? ? install -D -m 755 $(@D)/zcav $(TARGET_DIR)/usr/sbin/zcav
> +endef
> +
> +define BONNIE_UNINSTALL_TARGET_CMDS
> + ? ? ? rm -f $(TARGET_DIR)/usr/sbin/bonnie++ $(TARGET_DIR)/usr/sbin/zcav
> +endef
> +
> +$(eval $(call AUTOTARGETS,package,bonnie))
> --
> 1.5.6.5
>
>
> --
> Martin Hicks P.Eng. ? ?| ? ? ?mort at bork.org
> Bork Consulting Inc. ? | ?+1 (613) 266-2296
>



-- 
Martin Hicks P.Eng. ?? ? | ? ? ? ? mort at bork.org
Bork Consulting Inc. ? ? | ? +1 (613) 266-2296

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-02-14 14:37 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-01 17:19 [Buildroot] [PATCH] Add package bonnie++ Martin Hicks
2011-02-01 21:02 ` Thomas Petazzoni
2011-02-07 16:28   ` [Buildroot] [PATCH] V2: " Martin Hicks
2011-02-07 17:16     ` Peter Korsgaard
2011-02-08 21:42       ` Martin Hicks
2011-02-14 14:37         ` Martin Hicks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox