* [Buildroot] [PATCH] readline: link directly against ncurses
@ 2011-03-23 23:42 Mike Frysinger
2011-03-23 23:52 ` bruce bushby
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Mike Frysinger @ 2011-03-23 23:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
note: not really tested since external toolchain support is totally broken
package/readline/readline-6.1-curses-link.patch | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
create mode 100644 package/readline/readline-6.1-curses-link.patch
diff --git a/package/readline/readline-6.1-curses-link.patch b/package/readline/readline-6.1-curses-link.patch
new file mode 100644
index 0000000..56b4770
--- /dev/null
+++ b/package/readline/readline-6.1-curses-link.patch
@@ -0,0 +1,16 @@
+link readline directly to ncurses since it needs symbols from it
+
+upstream readline does this on purpose (no direct linking), but
+it doesn't make much sense in a Linux world
+
+--- a/support/shobj-conf
++++ b/support/shobj-conf
+@@ -42,7 +42,7 @@
+ SHOBJ_LIBS=
+
+ SHLIB_XLDFLAGS=
+-SHLIB_LIBS=
++SHLIB_LIBS=-lncurses
+
+ SHLIB_DOT='.'
+ SHLIB_LIBPREF='lib'
--
1.7.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-23 23:42 [Buildroot] [PATCH] readline: link directly against ncurses Mike Frysinger
@ 2011-03-23 23:52 ` bruce bushby
2011-03-24 18:47 ` Thomas Petazzoni
2011-04-03 19:03 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: bruce bushby @ 2011-03-23 23:52 UTC (permalink / raw)
To: buildroot
Hi Mike
I can't thank you enough....if it wasn't for yourself and Joakim I would
still have no idea.
I manually tried your "sed" suggestion and can confirm it worked:
[root at dlxarm01 buildroot]# readelf -d
./output/target/usr/lib/libreadline.so.6.1 | grep "]"
0x00000001 (NEEDED) Shared library: [libncurses.so.5]
0x00000001 (NEEDED) Shared library: [libc.so.0]
0x0000000e (SONAME) Library soname: [libreadline.so.6]
0x0000000f (RPATH) Library rpath: [/usr/lib]
[root at dlxarm01 buildroot]#
And now when I run python:
[root at vx-200 ~]# python
Python 2.7.1 (r271:86832, Mar 23 2011, 23:27:09)
[GCC 4.5.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import readline
>>>
[root at vx-200 ~]#
:))))))))))))))))))))))))))))))))))))))))))))))))))))))
On Wed, Mar 23, 2011 at 11:42 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
> note: not really tested since external toolchain support is totally broken
>
> package/readline/readline-6.1-curses-link.patch | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
> create mode 100644 package/readline/readline-6.1-curses-link.patch
>
> diff --git a/package/readline/readline-6.1-curses-link.patch
> b/package/readline/readline-6.1-curses-link.patch
> new file mode 100644
> index 0000000..56b4770
> --- /dev/null
> +++ b/package/readline/readline-6.1-curses-link.patch
> @@ -0,0 +1,16 @@
> +link readline directly to ncurses since it needs symbols from it
> +
> +upstream readline does this on purpose (no direct linking), but
> +it doesn't make much sense in a Linux world
> +
> +--- a/support/shobj-conf
> ++++ b/support/shobj-conf
> +@@ -42,7 +42,7 @@
> + SHOBJ_LIBS=
> +
> + SHLIB_XLDFLAGS=
> +-SHLIB_LIBS=
> ++SHLIB_LIBS=-lncurses
> +
> + SHLIB_DOT='.'
> + SHLIB_LIBPREF='lib'
> --
> 1.7.4.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110323/ea136681/attachment.html>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-23 23:42 [Buildroot] [PATCH] readline: link directly against ncurses Mike Frysinger
2011-03-23 23:52 ` bruce bushby
@ 2011-03-24 18:47 ` Thomas Petazzoni
2011-03-28 7:36 ` Mike Frysinger
2011-04-03 19:03 ` Peter Korsgaard
2 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2011-03-24 18:47 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 23 Mar 2011 19:42:55 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> note: not really tested since external toolchain support is totally
> broken
Could you elaborate ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-24 18:47 ` Thomas Petazzoni
@ 2011-03-28 7:36 ` Mike Frysinger
2011-03-28 7:59 ` Peter Korsgaard
2011-03-28 8:50 ` Thomas Petazzoni
0 siblings, 2 replies; 8+ messages in thread
From: Mike Frysinger @ 2011-03-28 7:36 UTC (permalink / raw)
To: buildroot
On Thu, Mar 24, 2011 at 2:47 PM, Thomas Petazzoni wrote:
> On Wed, 23 Mar 2011 19:42:55 -0400 Mike Frysinger wrote:
>> note: not really tested since external toolchain support is totally
>> broken
>
> Could you elaborate ?
i'm pretty sure i pointed this out around the time it broke. if you
dont specify the full path, the stupid makefiles prepend garbage.
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_PATH=""
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="bfin-uclinux"
BR2_TOOLCHAIN_EXTERNAL_PREFIX="bfin-uclinux"
$ make ncurses
....
checking for bfin-linux-gcc... /bin/bfin-uclinux-gcc
--sysroot=/usr/local/src/buildroot/output/host/usr/bfin-unknown-linux-uclibc/sysroot
-mike
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-28 7:36 ` Mike Frysinger
@ 2011-03-28 7:59 ` Peter Korsgaard
2011-03-28 8:50 ` Thomas Petazzoni
1 sibling, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2011-03-28 7:59 UTC (permalink / raw)
To: buildroot
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> On Thu, Mar 24, 2011 at 2:47 PM, Thomas Petazzoni wrote:
>> On Wed, 23 Mar 2011 19:42:55 -0400 Mike Frysinger wrote:
>>> note: not really tested since external toolchain support is totally
>>> broken
>>
>> Could you elaborate ?
Mike> i'm pretty sure i pointed this out around the time it broke. if you
Mike> dont specify the full path, the stupid makefiles prepend garbage.
Mike> BR2_TOOLCHAIN_EXTERNAL=y
Mike> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
Mike> BR2_TOOLCHAIN_EXTERNAL_PATH=""
Mike> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="bfin-uclinux"
Mike> BR2_TOOLCHAIN_EXTERNAL_PREFIX="bfin-uclinux"
Ahh, that got reported some time ago:
http://lists.busybox.net/pipermail/buildroot/2011-March/041891.html
I'll fix it now.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-28 7:36 ` Mike Frysinger
2011-03-28 7:59 ` Peter Korsgaard
@ 2011-03-28 8:50 ` Thomas Petazzoni
2011-03-28 9:10 ` Mike Frysinger
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2011-03-28 8:50 UTC (permalink / raw)
To: buildroot
On Mon, 28 Mar 2011 03:36:46 -0400
Mike Frysinger <vapier@gentoo.org> wrote:
> On Thu, Mar 24, 2011 at 2:47 PM, Thomas Petazzoni wrote:
> > On Wed, 23 Mar 2011 19:42:55 -0400 Mike Frysinger wrote:
> >> note: not really tested since external toolchain support is totally
> >> broken
> >
> > Could you elaborate ?
>
> i'm pretty sure i pointed this out around the time it broke. if you
> dont specify the full path, the stupid makefiles prepend garbage.
Come on Mike, just for this reason you call the external toolchain
support "totally broken" ? It's fixed by a two-liner patch that I
acked some time ago:
http://lists.busybox.net/pipermail/buildroot/2011-March/041901.html.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-28 8:50 ` Thomas Petazzoni
@ 2011-03-28 9:10 ` Mike Frysinger
0 siblings, 0 replies; 8+ messages in thread
From: Mike Frysinger @ 2011-03-28 9:10 UTC (permalink / raw)
To: buildroot
On Mon, Mar 28, 2011 at 4:50 AM, Thomas Petazzoni wrote:
> On Mon, 28 Mar 2011 03:36:46 -0400 Mike Frysinger wrote:
>> On Thu, Mar 24, 2011 at 2:47 PM, Thomas Petazzoni wrote:
>> > On Wed, 23 Mar 2011 19:42:55 -0400 Mike Frysinger wrote:
>> >> note: not really tested since external toolchain support is totally
>> >> broken
>> >
>> > Could you elaborate ?
>>
>> i'm pretty sure i pointed this out around the time it broke. ?if you
>> dont specify the full path, the stupid makefiles prepend garbage.
>
> Come on Mike, just for this reason you call the external toolchain
> support "totally broken" ? It's ?fixed by a two-liner patch that I
> acked some time ago:
> http://lists.busybox.net/pipermail/buildroot/2011-March/041901.html.
the size of the patch doesnt make it any less broken. and since it
wasnt merged until just now, i couldnt test anything in mainline.
-mike
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH] readline: link directly against ncurses
2011-03-23 23:42 [Buildroot] [PATCH] readline: link directly against ncurses Mike Frysinger
2011-03-23 23:52 ` bruce bushby
2011-03-24 18:47 ` Thomas Petazzoni
@ 2011-04-03 19:03 ` Peter Korsgaard
2 siblings, 0 replies; 8+ messages in thread
From: Peter Korsgaard @ 2011-04-03 19:03 UTC (permalink / raw)
To: buildroot
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-04-03 19:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-23 23:42 [Buildroot] [PATCH] readline: link directly against ncurses Mike Frysinger
2011-03-23 23:52 ` bruce bushby
2011-03-24 18:47 ` Thomas Petazzoni
2011-03-28 7:36 ` Mike Frysinger
2011-03-28 7:59 ` Peter Korsgaard
2011-03-28 8:50 ` Thomas Petazzoni
2011-03-28 9:10 ` Mike Frysinger
2011-04-03 19:03 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox