Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] Makefile.package.in: Fixing git download method
Date: Tue, 10 May 2011 08:53:35 +0200	[thread overview]
Message-ID: <20110510085335.5c9be308@surf> (raw)
In-Reply-To: <1305008226-8906-4-git-send-email-a@awn.dk>

Hello,

On Tue, 10 May 2011 08:17:06 +0200
"Allan W. Nielsen" <a@awn.dk> wrote:

> Signed-off-by: Allan W. Nielsen <a@awn.dk>
> ---
>  package/Makefile.package.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> index 1e87256..6038a09 100644
> --- a/package/Makefile.package.in
> +++ b/package/Makefile.package.in
> @@ -109,7 +109,7 @@ define DOWNLOAD_GIT
>  	$(GIT) clone --bare $($(PKG)_SITE) $($(PKG)_BASE_NAME) && \
>  	pushd $($(PKG)_BASE_NAME) > /dev/null && \
>  	$(GIT) archive --format=tar --prefix=$($(PKG)_BASE_NAME)/ $($(PKG)_DL_VERSION) | \
> -		gzip -c > $(DL_DIR)/$($(PKG)_SOURCE) && \
> +		gzip -c > ../$($(PKG)_SOURCE) && \

Could you provide a few details on how it "fixes" the Git download
method ? Actually, the existing implementation seems to do the right
thing: it stores the tarball into the $(DL_DIR) directory, which is
what we want. What problem did you encounter, and how does the ../
thing fixes it ?

Thanks!

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2011-05-10  6:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-10  6:17 [Buildroot] Minor updates to Makefile.package.in Allan W. Nielsen
2011-05-10  6:17 ` [Buildroot] [PATCH 1/3] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10  7:08   ` Daniel Nyström
2011-05-10  7:16   ` Thomas Petazzoni
     [not found]     ` <BANLkTi=HirqhyL4uuuBWnUoKu36xGE+V2g@mail.gmail.com>
2011-05-10  9:03       ` Thomas Petazzoni
2011-05-10  6:17 ` [Buildroot] [PATCH 2/3] Makefile.package.in: Added LZMA as compression type Allan W. Nielsen
2011-05-10  6:52   ` Thomas Petazzoni
2011-07-12 21:15   ` Peter Korsgaard
2011-05-10  6:17 ` [Buildroot] [PATCH 3/3] Makefile.package.in: Fixing git download method Allan W. Nielsen
2011-05-10  6:53   ` Thomas Petazzoni [this message]
     [not found]     ` <BANLkTinQcHkTmHoq9ci_QYgaj8vAqZ07yQ@mail.gmail.com>
2011-05-10  7:36       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110510085335.5c9be308@surf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox