From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] Makefile.package.in: Fixing git download method
Date: Tue, 10 May 2011 09:36:09 +0200 [thread overview]
Message-ID: <20110510093609.203d64f9@surf> (raw)
In-Reply-To: <BANLkTinQcHkTmHoq9ci_QYgaj8vAqZ07yQ@mail.gmail.com>
On Tue, 10 May 2011 09:22:22 +0200
Allan Nielsen <a@awn.dk> wrote:
> When I run buildroot $(DL_DIR) is a relative path which says ./src and
> the current directory (at this point) is $(DL_DIR)/my-git-package/,
> and it will try to place the tar file in
> $(DL_DIR)/my-git-package/src/my-git-package.tar.gz which is the wrong
> place.
>
> The suggested change should work both when $(DL_DIR) is relative and absolute.
Ah, yes, got it.
> Alternative I could of cause just change my $(DL_DIR) variable to an
> absolute path.
Or, better, make sure that DL_DIR is an absolute path even if it was
defined as a relative path in the configuration. Something like
(untested):
DL_DIR=$(call qstrip,$(BR2_DL_DIR))
ifeq ($(DL_DIR),)
DL_DIR:=$(TOPDIR)/dl
endif
+ DL_DIR=$(shell readlink -f $(DL_DIR))
in package/Makefile.package.in
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
prev parent reply other threads:[~2011-05-10 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 6:17 [Buildroot] Minor updates to Makefile.package.in Allan W. Nielsen
2011-05-10 6:17 ` [Buildroot] [PATCH 1/3] Makefile.package.in: Makes it possible to override the default extract commands Allan W. Nielsen
2011-05-10 7:08 ` Daniel Nyström
2011-05-10 7:16 ` Thomas Petazzoni
[not found] ` <BANLkTi=HirqhyL4uuuBWnUoKu36xGE+V2g@mail.gmail.com>
2011-05-10 9:03 ` Thomas Petazzoni
2011-05-10 6:17 ` [Buildroot] [PATCH 2/3] Makefile.package.in: Added LZMA as compression type Allan W. Nielsen
2011-05-10 6:52 ` Thomas Petazzoni
2011-07-12 21:15 ` Peter Korsgaard
2011-05-10 6:17 ` [Buildroot] [PATCH 3/3] Makefile.package.in: Fixing git download method Allan W. Nielsen
2011-05-10 6:53 ` Thomas Petazzoni
[not found] ` <BANLkTinQcHkTmHoq9ci_QYgaj8vAqZ07yQ@mail.gmail.com>
2011-05-10 7:36 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510093609.203d64f9@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox