From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants.
Date: Tue, 5 Jul 2011 22:11:26 +0200 [thread overview]
Message-ID: <20110705221126.5912c201@skate> (raw)
In-Reply-To: <1309790240-25341-1-git-send-email-arnout@mind.be>
Hello,
Le Mon, 4 Jul 2011 16:37:20 +0200,
"Arnout Vandecappelle (Essensium - Mind)" <arnout@mind.be> a ?crit :
> @@ -478,6 +478,13 @@ config BR2_ARCH
> default "i686" if BR2_x86_pentiumpro
> default "i686" if BR2_x86_nocona
> default "i686" if BR2_x86_core2
> + default "i686" if BR2_x86_opteron
> + default "i686" if BR2_x86_opteron_sse3
> + default "i686" if BR2_x86_barcelona
> + default "i686" if BR2_x86_k6
> + default "i686" if BR2_x86_k6_2
> + default "i686" if BR2_x86_athlon
> + default "i686" if BR2_x86_athlon_4
> default "m68k" if BR2_m68k
> default "mips" if BR2_mips
> default "mipsel" if BR2_mipsel
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
This whole BR2_ARCH thing is a little nasty. For some archs, there is a
single entry (for example ARM), but for other archs (for example x86 or
x86_64) there are multiple entries. I would be tempted to replace all
the x86 entries by :
default "i386" if BR2_i386
but according to commit 6212c19a8fbe86bf6c9ab854bd9b0db4ecc8d5ba having
different BR2_ARCH is needed :
"""
allow people to build for i386/i486/i586/i686 targets since some
packages (like gcc) build differently based upon the host tuplet
"""
What do people think about this ?
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-07-05 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 14:37 [Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants Arnout Vandecappelle
2011-07-05 20:11 ` Thomas Petazzoni [this message]
2011-07-07 19:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705221126.5912c201@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox