[Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants.

[Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants.

[Arnout Vandecappelle]

From: "Arnout Vandecappelle (Essensium - Mind)" <arnout@mind.be>

Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
 target/Config.in.arch |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/target/Config.in.arch b/target/Config.in.arch
index 7c80945..1964357 100644
--- a/target/Config.in.arch
+++ b/target/Config.in.arch
@@ -478,6 +478,13 @@ config BR2_ARCH
 	default "i686"		if BR2_x86_pentiumpro
 	default "i686"		if BR2_x86_nocona
 	default "i686"		if BR2_x86_core2
+	default "i686"		if BR2_x86_opteron
+	default "i686"		if BR2_x86_opteron_sse3
+	default "i686"		if BR2_x86_barcelona
+	default "i686"		if BR2_x86_k6
+	default "i686"		if BR2_x86_k6_2
+	default "i686"		if BR2_x86_athlon
+	default "i686"		if BR2_x86_athlon_4
 	default "m68k"		if BR2_m68k
 	default "mips"		if BR2_mips
 	default "mipsel"	if BR2_mipsel
-- 
1.7.5.4

[Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants.

[Thomas Petazzoni]

Hello,

Le Mon,  4 Jul 2011 16:37:20 +0200,
"Arnout Vandecappelle (Essensium - Mind)" <arnout@mind.be> a ?crit :

> @@ -478,6 +478,13 @@ config BR2_ARCH
>  	default "i686"		if BR2_x86_pentiumpro
>  	default "i686"		if BR2_x86_nocona
>  	default "i686"		if BR2_x86_core2
> +	default "i686"		if BR2_x86_opteron
> +	default "i686"		if BR2_x86_opteron_sse3
> +	default "i686"		if BR2_x86_barcelona
> +	default "i686"		if BR2_x86_k6
> +	default "i686"		if BR2_x86_k6_2
> +	default "i686"		if BR2_x86_athlon
> +	default "i686"		if BR2_x86_athlon_4
>  	default "m68k"		if BR2_m68k
>  	default "mips"		if BR2_mips
>  	default "mipsel"	if BR2_mipsel

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

This whole BR2_ARCH thing is a little nasty. For some archs, there is a
single entry (for example ARM), but for other archs (for example x86 or
x86_64) there are multiple entries. I would be tempted to replace all
the x86 entries by :

	default "i386"	if BR2_i386

but according to commit 6212c19a8fbe86bf6c9ab854bd9b0db4ecc8d5ba having
different BR2_ARCH is needed :

"""
allow people to build for i386/i486/i586/i686 targets since some
packages (like gcc) build differently based upon the host tuplet
"""

What do people think about this ?

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] BR2_ARCH definition was missing for 32-bit AMD architecture variants.

[Peter Korsgaard]

>>>>> ""Arnout" == "Arnout Vandecappelle (Essensium <- Mind)" <arnout@mind.be>> writes:

 Arnout> From: "Arnout Vandecappelle (Essensium - Mind)" <arnout@mind.be>
 Arnout> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

Committed, thanks.

-- 
Bye, Peter Korsgaard