From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch] Allow file to be built against static libs.
Date: Tue, 19 Jul 2011 22:42:55 +0200 [thread overview]
Message-ID: <20110719224255.68dada94@skate> (raw)
In-Reply-To: <87sjq22f6n.fsf@macbook.be.48ers.dk>
Le Tue, 19 Jul 2011 22:22:56 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :
> We indeed force --enable-shared --disable-static for host builds, but
> that doesn't really matter. For target builds we use (see
> package/Makefile.in) --enable-static --enable-shared when
> PREFER_STATIC_LIB is enabled, so rather than something file specific, I
> think it would make more sense to set that to --enable-static
> --disable-shared instead.
We have :
ifeq ($(BR2_PREFER_STATIC_LIB),y)
SHARED_STATIC_LIBS_OPTS=--enable-static --disable-shared
else
SHARED_STATIC_LIBS_OPTS=--enable-static --enable-shared
endif
So it is already --enable-static --disable-shared when
BR2_PREFER_STATIC_LIB=y. So, Andy, I think that your patch is basically
a no-op, except for the host build of the file package, but it is
totally incorrect to turn the host build of the file package to a
static library depending on the value of BR2_PREFER_STATIC_LIB, which
is limited to target packages only.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-07-19 20:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:48 [Buildroot] [Patch] Allow file to be built against static libs ANDY KENNEDY
2011-07-19 20:22 ` Peter Korsgaard
2011-07-19 20:42 ` Thomas Petazzoni [this message]
2011-07-19 21:01 ` Peter Korsgaard
2011-07-20 4:53 ` ANDY KENNEDY
2011-07-20 21:51 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110719224255.68dada94@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox