From: Peter Korsgaard <jacmet@sunsite.dk>
To: buildroot@busybox.net
Subject: [Buildroot] [Patch] Allow file to be built against static libs.
Date: Wed, 20 Jul 2011 23:51:11 +0200 [thread overview]
Message-ID: <87ei1k1v00.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <F9C551623D2CBB4C9488801D14F864C60448FD@ex-mb1.corp.adtran.com> (ANDY KENNEDY's message of "Wed, 20 Jul 2011 04:53:31 +0000")
>>>>> "ANDY" == ANDY KENNEDY <ANDY.KENNEDY@adtran.com> writes:
>> Ehh, drop that, I remembered wrong - We're already doing --enable-
>> static --disable-shared.
ANDY> Okay, well, sortta, but not really. I believe this to be the culprit:
ANDY> #############################################################
ANDY> #
ANDY> # zlib
ANDY> #
ANDY> #############################################################
ANDY> ZLIB_VERSION:=1.2.5
ANDY> ZLIB_SOURCE:=zlib-$(ZLIB_VERSION).tar.bz2
ANDY> ZLIB_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/libpng
ANDY> ZLIB_INSTALL_STAGING=YES
ANDY> ifeq ($(BR2_PREFER_STATIC_LIB),y)
ANDY> ZLIB_PIC :=
ANDY> ZLIB_SHARED := --static
ANDY> else
ANDY> ZLIB_PIC := -fPIC
ANDY> ZLIB_SHARED := --shared
ANDY> endif
Yes, this is all fine. The problem is just that we link host stuff
dynamically, but zlib was building the host version in the same was as
the target one (so static if BR2_PREFER_STATIC_LIB), which would then
break host-file when it tried to dynamically link to zlib.
I've fixed that now, thanks for reporting it.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2011-07-20 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-19 19:48 [Buildroot] [Patch] Allow file to be built against static libs ANDY KENNEDY
2011-07-19 20:22 ` Peter Korsgaard
2011-07-19 20:42 ` Thomas Petazzoni
2011-07-19 21:01 ` Peter Korsgaard
2011-07-20 4:53 ` ANDY KENNEDY
2011-07-20 21:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ei1k1v00.fsf@macbook.be.48ers.dk \
--to=jacmet@sunsite.dk \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox