[Buildroot] [PATCH] Adding Fluxbox window manager

[Buildroot] [PATCH] Adding Fluxbox window manager

[Frederic Bassaler]

Hope this is ok, sorry I'm a git-newbie

(if it's not good, can somebody tell me the proper git commands? thanks)



---
 package/Config.in          |    1 +
 package/fluxbox/Config.in  |   13 +++++++++++++
 package/fluxbox/fluxbox.mk |   23 +++++++++++++++++++++++
 3 files changed, 37 insertions(+), 0 deletions(-)
 create mode 100644 package/fluxbox/Config.in
 create mode 100644 package/fluxbox/fluxbox.mk

diff --git a/package/Config.in b/package/Config.in
index 7112e05..c4cecfa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -127,6 +127,7 @@ comment "X Window managers"
 source "package/matchbox/Config.in"
 source "package/metacity/Config.in"
 source "package/blackbox/Config.in"
+source "package/fluxbox/Config.in"
 
 comment "X applications"
 source "package/alsamixergui/Config.in"
diff --git a/package/fluxbox/Config.in b/package/fluxbox/Config.in
new file mode 100644
index 0000000..63840b2
--- /dev/null
+++ b/package/fluxbox/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_FLUXBOX
+	bool "fluxbox"
+        depends on BR2_PACKAGE_XORG7
+        depends on BR2_INSTALL_LIBSTDCPP
+        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
+        select BR2_PACKAGE_XLIB_LIBX11
+  	help
+	  The Fluxbox lightweight window manager for X
+
+	  http://fluxbox.org
+
+comment "fluxbox requires a toolchain with C++ support enabled"
+        depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP
diff --git a/package/fluxbox/fluxbox.mk b/package/fluxbox/fluxbox.mk
new file mode 100644
index 0000000..726a133
--- /dev/null
+++ b/package/fluxbox/fluxbox.mk
@@ -0,0 +1,23 @@
+#############################################################
+#
+# FLUXBOX
+#
+#############################################################
+
+FLUXBOX_VERSION:=1.3.1
+FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
+FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
+FLUXBOX_AUTORECONF:=NO
+FLUXBOX_INSTALL_STAGING:=NO
+FLUXBOX_INSTALL_TARGET:=YES
+
+FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
+		--x-libraries=$(STAGING_DIR)/usr/lib
+
+FLUXBOX_DEPENDENCIES = xlib_libX11
+
+ifneq ($(BR2_ENABLE_LOCALE),y)
+FLUXBOX_DEPENDENCIES += libiconv
+endif
+
+$(eval $(call AUTOTARGETS,package,fluxbox))
-- 
1.7.2.3

[Buildroot] [PATCH] Adding Fluxbox window manager

[Thomas Petazzoni]

Hello,

Le Tue, 2 Aug 2011 19:10:04 +0200,
Frederic Bassaler <frederic.bassaler@gmail.com> a ?crit :

> Hope this is ok, sorry I'm a git-newbie
> 
> (if it's not good, can somebody tell me the proper git commands?
> thanks)

This should be a proper patch description, as it will end up in the
commit log. You must also add a Signed-off-by line.

> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_FLUXBOX
> +	bool "fluxbox"
> +        depends on BR2_PACKAGE_XORG7
> +        depends on BR2_INSTALL_LIBSTDCPP
> +        select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
> +        select BR2_PACKAGE_XLIB_LIBX11
> +  	help
> +	  The Fluxbox lightweight window manager for X
> +
> +	  http://fluxbox.org
> +
> +comment "fluxbox requires a toolchain with C++ support enabled"
> +        depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP

"bool", "depends on", "select" must be prefixed by a tab, not spaces.
The help text must be indented with one tab + 2 spaces.

> diff --git a/package/fluxbox/fluxbox.mk b/package/fluxbox/fluxbox.mk
> new file mode 100644
> index 0000000..726a133
> --- /dev/null
> +++ b/package/fluxbox/fluxbox.mk
> @@ -0,0 +1,23 @@
> +#############################################################
> +#
> +# FLUXBOX
> +#
> +#############################################################
> +
> +FLUXBOX_VERSION:=1.3.1
> +FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
> +FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/

Please use = instead of :=.

> +FLUXBOX_AUTORECONF:=NO
> +FLUXBOX_INSTALL_STAGING:=NO
> +FLUXBOX_INSTALL_TARGET:=YES

Not needed, those are the default values.

> +FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
> +		--x-libraries=$(STAGING_DIR)/usr/lib
> +
> +FLUXBOX_DEPENDENCIES = xlib_libX11

This doesn't really match the dependencies expressed in the Config.in
file, but it's true that our dependencies on X.org stuff are a bit
broken today (all client applications depend on the server, which is
not correct from a build point of view).

For the time being, I guess this will be fine, until we find the time
to clean up those dependencies.

> +ifneq ($(BR2_ENABLE_LOCALE),y)
> +FLUXBOX_DEPENDENCIES += libiconv
> +endif
> +
> +$(eval $(call AUTOTARGETS,package,fluxbox))

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] Adding Fluxbox window manager

[Thomas De Schampheleire]

Hi,

On Tue, Aug 2, 2011 at 8:44 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> Le Tue, 2 Aug 2011 19:10:04 +0200,
> Frederic Bassaler <frederic.bassaler@gmail.com> a ?crit :
>
>> Hope this is ok, sorry I'm a git-newbie
>>
>> (if it's not good, can somebody tell me the proper git commands?
>> thanks)
>
> This should be a proper patch description, as it will end up in the
> commit log. You must also add a Signed-off-by line.
>
>> @@ -0,0 +1,13 @@
>> +config BR2_PACKAGE_FLUXBOX
>> + ? ? bool "fluxbox"
>> + ? ? ? ?depends on BR2_PACKAGE_XORG7
>> + ? ? ? ?depends on BR2_INSTALL_LIBSTDCPP
>> + ? ? ? ?select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
>> + ? ? ? ?select BR2_PACKAGE_XLIB_LIBX11
>> + ? ? help
>> + ? ? ? The Fluxbox lightweight window manager for X
>> +
>> + ? ? ? http://fluxbox.org
>> +
>> +comment "fluxbox requires a toolchain with C++ support enabled"
>> + ? ? ? ?depends on BR2_PACKAGE_XORG7 && !BR2_INSTALL_LIBSTDCPP
>
> "bool", "depends on", "select" must be prefixed by a tab, not spaces.
> The help text must be indented with one tab + 2 spaces.
>
>> diff --git a/package/fluxbox/fluxbox.mk b/package/fluxbox/fluxbox.mk
>> new file mode 100644
>> index 0000000..726a133
>> --- /dev/null
>> +++ b/package/fluxbox/fluxbox.mk
>> @@ -0,0 +1,23 @@
>> +#############################################################
>> +#
>> +# FLUXBOX
>> +#
>> +#############################################################
>> +
>> +FLUXBOX_VERSION:=1.3.1
>> +FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
>> +FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
>
> Please use = instead of :=.

Just curious: why do you recommend against := ?
For example in the case of FLUXBOX_SOURCE, using := would avoid
unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE
is used.
For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is
already defined or not, but I think it has, right?

>
>> +FLUXBOX_AUTORECONF:=NO
>> +FLUXBOX_INSTALL_STAGING:=NO
>> +FLUXBOX_INSTALL_TARGET:=YES
>
> Not needed, those are the default values.
>
>> +FLUXBOX_CONF_OPT:=--x-includes=$(STAGING_DIR)/usr/include/X11 \
>> + ? ? ? ? ? ? --x-libraries=$(STAGING_DIR)/usr/lib
>> +
>> +FLUXBOX_DEPENDENCIES = xlib_libX11
>
> This doesn't really match the dependencies expressed in the Config.in
> file, but it's true that our dependencies on X.org stuff are a bit
> broken today (all client applications depend on the server, which is
> not correct from a build point of view).
>
> For the time being, I guess this will be fine, until we find the time
> to clean up those dependencies.
>
>> +ifneq ($(BR2_ENABLE_LOCALE),y)
>> +FLUXBOX_DEPENDENCIES += libiconv
>> +endif
>> +
>> +$(eval $(call AUTOTARGETS,package,fluxbox))
>
> Regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCH] Adding Fluxbox window manager

[Thomas Petazzoni]

Le Wed, 3 Aug 2011 09:46:16 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> >> +FLUXBOX_VERSION:=1.3.1
> >> +FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
> >> +FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
> >
> > Please use = instead of :=.
> 
> Just curious: why do you recommend against := ?
> For example in the case of FLUXBOX_SOURCE, using := would avoid
> unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE
> is used.
> For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is
> already defined or not, but I think it has, right?

Peter Korsgaard said:

""""
:= is only a performance advantage if variables are expensive to expand
(use) and are used more than once - E.G. stuff involving $(shell) and
similar, like the UPPERCASE macro we had calling tr.

= has a number of advantages though. As it only gets expanded at the
last possible moment you don't have to take care about variable
ordering, E.G. when you use a variable like LIBGLIB2_HOST_BINARY on
another package, whereas with := you do. This can also be interesting
when the variable contains $(shell) or other functions, as you might
only want to execute them if/when they are needed, and not right away
when the Makefiles are parsed.

I would prefer to use = by default, and only use := where it matters for
correctness or performance.
""""

See:

Subject: Re: [Buildroot] [PATCH 07/28] barebox: use = instead of := and re-indent
Date: Tue, 05 Jul 2011 23:04:58 +0200
Message-ID: <87sjqkv3ph.fsf@macbook.be.48ers.dk>

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] Adding Fluxbox window manager

[Thomas De Schampheleire]

On Wed, Aug 3, 2011 at 9:56 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Wed, 3 Aug 2011 09:46:16 +0200,
> Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
>
>> >> +FLUXBOX_VERSION:=1.3.1
>> >> +FLUXBOX_SOURCE:=fluxbox-$(FLUXBOX_VERSION).tar.bz2
>> >> +FLUXBOX_SITE:=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/fluxbox/
>> >
>> > Please use = instead of :=.
>>
>> Just curious: why do you recommend against := ?
>> For example in the case of FLUXBOX_SOURCE, using := would avoid
>> unnecessary expansions of $(FLUXBOX_VERSION), each time FLUXBOX_SOURCE
>> is used.
>> For FLUXBOX_SITE it depends on whether BR2_SOURCEFORGE_MIRROR is
>> already defined or not, but I think it has, right?
>
> Peter Korsgaard said:
>
> """"
> := is only a performance advantage if variables are expensive to expand
> (use) and are used more than once - E.G. stuff involving $(shell) and
> similar, like the UPPERCASE macro we had calling tr.
>
> = has a number of advantages though. As it only gets expanded at the
> last possible moment you don't have to take care about variable
> ordering, E.G. when you use a variable like LIBGLIB2_HOST_BINARY on
> another package, whereas with := you do. This can also be interesting
> when the variable contains $(shell) or other functions, as you might
> only want to execute them if/when they are needed, and not right away
> when the Makefiles are parsed.
>
> I would prefer to use = by default, and only use := where it matters for
> correctness or performance.
> """"
>
> See:
>
> Subject: Re: [Buildroot] [PATCH 07/28] barebox: use = instead of := and re-indent
> Date: Tue, 05 Jul 2011 23:04:58 +0200
> Message-ID: <87sjqkv3ph.fsf@macbook.be.48ers.dk>

Ok, thanks.
Thomas

>
> Regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com
>