From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/15] package: remove useless arguments from AUTOTARGETS
Date: Sat, 17 Sep 2011 09:11:36 +0200 [thread overview]
Message-ID: <20110917091136.4a05f81d@skate> (raw)
In-Reply-To: <87vcsrwu8u.fsf@macbook.be.48ers.dk>
Le Sat, 17 Sep 2011 08:36:17 +0200,
Peter Korsgaard <jacmet@uclibc.org> a ?crit :
> Does those functions do the right thing here or do we need to rename
> the directory to libfuse?
Good catch: those functions make the assumption that the directory is
named after the name of the package. Actually, the name of the .mk is
not important to these macros, it is the directory name that is
important:
+define pkgmakefile
+$(dir $(lastword $(MAKEFILE_LIST)))
+endef
For package/fuse/libfuse.mk, the output of this macro is package/fuse/.
In fact, I think we could rename this macro "pkgmakefiledir" or
something like that.
+define pkgname
+$(lastword $(subst /, ,$(call pkgmakefile)))
+endef
And therefore the output of this if "fuse". So you're correct that the
fuse package need to be changed.
Should I rebase my changes on master (to include new packages) and fix
those issues ?
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-09-17 7:11 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 21:31 [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-infra Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 01/15] package: show complete URL for external-deps Thomas Petazzoni
2011-09-17 6:31 ` Peter Korsgaard
2011-09-17 7:13 ` Thomas Petazzoni
2011-09-17 8:53 ` Peter Korsgaard
2011-08-31 21:31 ` [Buildroot] [PATCH 02/15] package: enhance infrastructure to support source dir override Thomas Petazzoni
2011-09-02 10:02 ` Arnout Vandecappelle
2011-09-02 11:21 ` Thomas Petazzoni
2011-09-02 11:45 ` Arnout Vandecappelle
2011-08-31 21:31 ` [Buildroot] [PATCH 03/15] package: add configuration option to specify a local override file Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 04/15] package: add <pkg>-rebuild and <pkg>-reconfigure Thomas Petazzoni
2011-11-04 9:44 ` Stephan Hoffmann
2011-11-27 17:49 ` Stephan Hoffmann
2011-11-28 8:12 ` Thomas Petazzoni
2011-11-28 8:46 ` Stephan Hoffmann
2011-11-28 11:10 ` Quotient Remainder
2011-11-28 12:06 ` Thomas Petazzoni
2012-04-06 16:44 ` [Buildroot] [PATCH] Add documentation for " Stephan Hoffmann
2012-04-07 17:45 ` Peter Korsgaard
2011-08-31 21:31 ` [Buildroot] [PATCH 05/15] package: implement a 'local' site method Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 06/15] package: add helper functions to get package name and directory magically Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 07/15] package: remove useless arguments from GENTARGETS Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 08/15] package: remove useless arguments from AUTOTARGETS Thomas Petazzoni
2011-09-17 6:36 ` Peter Korsgaard
2011-09-17 7:11 ` Thomas Petazzoni [this message]
2011-09-17 8:07 ` Peter Korsgaard
2011-09-22 6:06 ` Arnout Vandecappelle
2011-08-31 21:31 ` [Buildroot] [PATCH 09/15] package: remove useless arguments from CMAKETARGETS Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 10/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 11/15] Add support for local packages through 'file://' pseudo-protocol Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 12/15] fakeroot: remove target package Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 13/15] dhrystone: use the <pkg>_EXTRACT_CMDS mechanism Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 14/15] whetstone: " Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 15/15] mcookie: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-09-05 12:46 ` [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-infra Luca Ceresoli
2011-09-05 13:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110917091136.4a05f81d@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox