From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 08/15] package: remove useless arguments from AUTOTARGETS
Date: Thu, 22 Sep 2011 08:06:42 +0200 [thread overview]
Message-ID: <201109220806.42914.arnout@mind.be> (raw)
In-Reply-To: <20110917091136.4a05f81d@skate>
On Saturday 17 September 2011 09:11:36, Thomas Petazzoni wrote:
> Good catch: those functions make the assumption that the directory is
> named after the name of the package. Actually, the name of the .mk is
> not important to these macros, it is the directory name that is
> important:
>
> +define pkgmakefile
> +$(dir $(lastword $(MAKEFILE_LIST)))
> +endef
>
> For package/fuse/libfuse.mk, the output of this macro is package/fuse/.
> In fact, I think we could rename this macro "pkgmakefiledir" or
> something like that.
>
> +define pkgname
> +$(lastword $(subst /, ,$(call pkgmakefile)))
> +endef
How about the following?
define pkgname
$(notdir $(lastword $(MAKEFILE_LIST)))
endif
(I haven't tried this though.)
It sounds more important to me that the makefile name corresponds to the
package name than the directory name. For one, this would make it possible to
have two packages in the same directory. This is useful if they share a lot of
Config.in but have very different makefiles. U-boot and barebox might benefit
from this, for one.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
next prev parent reply other threads:[~2011-09-22 6:06 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-31 21:31 [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-infra Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 01/15] package: show complete URL for external-deps Thomas Petazzoni
2011-09-17 6:31 ` Peter Korsgaard
2011-09-17 7:13 ` Thomas Petazzoni
2011-09-17 8:53 ` Peter Korsgaard
2011-08-31 21:31 ` [Buildroot] [PATCH 02/15] package: enhance infrastructure to support source dir override Thomas Petazzoni
2011-09-02 10:02 ` Arnout Vandecappelle
2011-09-02 11:21 ` Thomas Petazzoni
2011-09-02 11:45 ` Arnout Vandecappelle
2011-08-31 21:31 ` [Buildroot] [PATCH 03/15] package: add configuration option to specify a local override file Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 04/15] package: add <pkg>-rebuild and <pkg>-reconfigure Thomas Petazzoni
2011-11-04 9:44 ` Stephan Hoffmann
2011-11-27 17:49 ` Stephan Hoffmann
2011-11-28 8:12 ` Thomas Petazzoni
2011-11-28 8:46 ` Stephan Hoffmann
2011-11-28 11:10 ` Quotient Remainder
2011-11-28 12:06 ` Thomas Petazzoni
2012-04-06 16:44 ` [Buildroot] [PATCH] Add documentation for " Stephan Hoffmann
2012-04-07 17:45 ` Peter Korsgaard
2011-08-31 21:31 ` [Buildroot] [PATCH 05/15] package: implement a 'local' site method Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 06/15] package: add helper functions to get package name and directory magically Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 07/15] package: remove useless arguments from GENTARGETS Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 08/15] package: remove useless arguments from AUTOTARGETS Thomas Petazzoni
2011-09-17 6:36 ` Peter Korsgaard
2011-09-17 7:11 ` Thomas Petazzoni
2011-09-17 8:07 ` Peter Korsgaard
2011-09-22 6:06 ` Arnout Vandecappelle [this message]
2011-08-31 21:31 ` [Buildroot] [PATCH 09/15] package: remove useless arguments from CMAKETARGETS Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 10/15] Makefile.package.in: Pass non-prefixed name as argument to GENTARGETS_INNER Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 11/15] Add support for local packages through 'file://' pseudo-protocol Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 12/15] fakeroot: remove target package Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 13/15] dhrystone: use the <pkg>_EXTRACT_CMDS mechanism Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 14/15] whetstone: " Thomas Petazzoni
2011-08-31 21:31 ` [Buildroot] [PATCH 15/15] mcookie: convert to the GENTARGETS infrastructure Thomas Petazzoni
2011-09-05 12:46 ` [Buildroot] [pull request v2] Pull request for branch for-2011.11/pkg-infra Luca Ceresoli
2011-09-05 13:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201109220806.42914.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox