[Buildroot] [PATCH 0 of 2] linux: add linux-update and allow vmlinux for all architectures

[Buildroot] [PATCH 0 of 2] linux: add linux-update and allow vmlinux for all architectures

[Thomas De Schampheleire]

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 linux/Config.in |  1 -
 linux/linux.mk  |  7 +++++++
 2 files changed, 7 insertions(+), 1 deletions(-)

[Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration

[Thomas De Schampheleire]

In analogy to build targets uclibc-update and busybox-update, add linux-update
that copies the current configuration to the custom configuration file set in
buildroot.
This facilitates the work of developers adding support for a specific board
to buildroot.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

---
 linux/linux.mk |  7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/linux/linux.mk b/linux/linux.mk
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -188,6 +188,13 @@
 	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) \
 		$(subst linux-,,$(subst linux26-,,$@))
 
+ifeq ($(BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG),y)
+linux-update linux26-update: $(LINUX_DIR)/.config
+	cp -f $(LINUX_DIR)/.config $(BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE)
+else
+linux-update linux26-update: ;
+endif
+
 # Support for rebuilding the kernel after the initramfs file list has
 # been generated in $(BINARIES_DIR)/rootfs.initramfs.
 $(LINUX_DIR)/.stamp_initramfs_rebuilt: $(LINUX_DIR)/.stamp_target_installed $(LINUX_DIR)/.stamp_images_installed $(BINARIES_DIR)/rootfs.initramfs

[Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration

[Thomas Petazzoni]

Hello,

Le Wed, 21 Sep 2011 08:46:15 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> In analogy to build targets uclibc-update and busybox-update, add linux-update
> that copies the current configuration to the custom configuration file set in
> buildroot.
> This facilitates the work of developers adding support for a specific board
> to buildroot.

Definitely a good thing to have. However:

 * The name if misleading. "linux-update" "busybox-update": one is not
   "updating" Linux or Busybox, but rather copying or updating the
   configuration. So presumably the name of those targets should be
   changed.

 * I don't like the existing behaviour of busybox-update and
   uclibc-update, because they can overwrite the default configuration
   in package/busybox/busybox-xxx.config or
   toolchain/uClibc/uClibc-xxx.config. I think those *-update should
   only take effect if a non-standard configuration file was proposed,
   as you did for the Linux one.

 * For the Linux kernel, I do use savedefconfig, so I'd like to see
   either this "linux-update" thing use savedefconfig, or have a
   separate option that does the same thing as "linux-update" but using
   savedefconfig. Maybe "linux-update-config" and
   "linux-update-minconfig" ?

Regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration

[Thomas De Schampheleire]

Hi Thomas,

On Wed, Sep 21, 2011 at 9:28 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> Le Wed, 21 Sep 2011 08:46:15 +0200,
> Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
>
>> In analogy to build targets uclibc-update and busybox-update, add linux-update
>> that copies the current configuration to the custom configuration file set in
>> buildroot.
>> This facilitates the work of developers adding support for a specific board
>> to buildroot.
>
> Definitely a good thing to have. However:
>
> ?* The name if misleading. "linux-update" "busybox-update": one is not
> ? "updating" Linux or Busybox, but rather copying or updating the
> ? configuration. So presumably the name of those targets should be
> ? changed.

I agree that the name is a bit strange. "busybox-update" and
"uclibc-update" were introduced back in 2007:

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas De Schampheleire]

The 'vmlinux' target in the linux build directory is a generic target. It may
not be directly bootable for all architectures, but for projects where a custom
bootloader is used, it can be of value.

Previously, this target was only available for mips architectures. This patch
removes this restriction.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 linux/Config.in |  1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/linux/Config.in b/linux/Config.in
--- a/linux/Config.in
+++ b/linux/Config.in
@@ -146,7 +146,6 @@
 
 config BR2_LINUX_KERNEL_VMLINUX
 	bool "vmlinux"
-	depends on BR2_mips || BR2_mipsel
 
 config BR2_LINUX_KERNEL_IMAGE_TARGET_CUSTOM
 	bool "custom target"

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas Petazzoni]

Le Wed, 21 Sep 2011 08:46:16 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> The 'vmlinux' target in the linux build directory is a generic target. It may
> not be directly bootable for all architectures, but for projects where a custom
> bootloader is used, it can be of value.
> 
> Previously, this target was only available for mips architectures. This patch
> removes this restriction.
> 
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas Petazzoni]

Le Wed, 21 Sep 2011 09:29:29 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :

> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

I've merged the patch in a linux-changes branch I will push to Peter.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas De Schampheleire]

Hi Thomas,

On Thu, Sep 22, 2011 at 9:07 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Wed, 21 Sep 2011 09:29:29 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a ?crit :
>
>> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>
> I've merged the patch in a linux-changes branch I will push to Peter.

Could you tell me the status of the linux-changes branch? Do you still
have other patches that should go in before you push it to Peter?

Thanks,
Thomas

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas Petazzoni]

Le Sun, 16 Oct 2011 12:35:00 +0200,
Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :

> Could you tell me the status of the linux-changes branch? Do you still
> have other patches that should go in before you push it to Peter?

I will check this and post the patches soon.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Thomas De Schampheleire]

On Mon, Oct 17, 2011 at 9:15 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Sun, 16 Oct 2011 12:35:00 +0200,
> Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> a ?crit :
>
>> Could you tell me the status of the linux-changes branch? Do you still
>> have other patches that should go in before you push it to Peter?
>
> I will check this and post the patches soon.

Thanks.

[Buildroot] [PATCH 2 of 2] linux: make vmlinux target available to all architectures

[Peter Korsgaard]

>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:

 Thomas> The 'vmlinux' target in the linux build directory is a generic
 Thomas> target. It may not be directly bootable for all architectures,
 Thomas> but for projects where a custom bootloader is used, it can be
 Thomas> of value.

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH 0 of 2] Facilitate saving of configuration files for board developers

[Thomas De Schampheleire]

This patch series intends to make the development life of board developers
working with buildroot easier, by providing two extra -update build targets
that copy over configuration files to their version-controlled counterparts.
The new targets, linux-update and config-update have the same behavior as
the already existing uclibc-update and busybox-update.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 linux/linux.mk |   7 +++++++
 Config.in      |  11 +++++++++++
 Makefile       |   9 +++++++++
 3 files changed, 27 insertions(+), 0 deletions(-)

[Buildroot] [PATCH 1 of 2] linux: add linux-update target to save configuration

[Thomas De Schampheleire]

In analogy to build targets uclibc-update and busybox-update, add linux-update
that copies the current configuration to the custom configuration file set in
buildroot.
This facilitates the work of developers adding support for a specific board
to buildroot.

Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
---
 linux/linux.mk |  7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/linux/linux.mk b/linux/linux.mk
--- a/linux/linux.mk
+++ b/linux/linux.mk
@@ -163,6 +163,13 @@
 	$(MAKE) $(LINUX26_MAKE_FLAGS) -C $(LINUX26_DIR) \
 		$(subst linux-,,$(subst linux26-,,$@))
 
+ifeq ($(BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG),y)
+linux-update linux26-update: $(LINUX26_DIR)/.config
+	cp -f $(LINUX26_DIR)/.config $(BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE)
+else
+linux-update linux26-update: ;
+endif
+
 # Support for rebuilding the kernel after the initramfs file list has
 # been generated in $(BINARIES_DIR)/rootfs.initramfs.
 $(LINUX26_DIR)/.stamp_initramfs_rebuilt: $(LINUX26_DIR)/.stamp_installed $(BINARIES_DIR)/rootfs.initramfs