From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] Add the picocom package
Date: Fri, 30 Sep 2011 21:46:14 +0200 [thread overview]
Message-ID: <20110930214614.1d844b95@skate> (raw)
In-Reply-To: <a43c69b7a1a524be05e8b42d86404b6f116a6a3e.1317210509.git.maxime.ripard@free-electrons.com>
Le Wed, 28 Sep 2011 13:48:31 +0200,
Maxime Ripard <maxime.ripard@free-electrons.com> a ?crit :
> + http://code.google.com/p/picocom/
> \ No newline at end of file
Peter would like to see a newline here.
> +define PICOCOM_BUILD_CMDS
> + $(TARGET_CONFIGURE_OPTS) \
> + $(MAKE) -C $(@D)
Nitpicking: it probably can be on one single line.
> +$(eval $(call GENTARGETS,package,picocom))
> \ No newline at end of file
newline needed here.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-09-30 19:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-28 11:48 [Buildroot] [pull request] Pull request for branch for-2011.11/packages Maxime Ripard
2011-09-28 11:48 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-09-30 19:46 ` Thomas Petazzoni [this message]
2011-09-28 11:48 ` [Buildroot] [PATCH 2/4] Add Transmission package Maxime Ripard
2011-09-28 12:11 ` Thomas Petazzoni
2011-09-28 11:48 ` [Buildroot] [PATCH 3/4] Add lame support in gstreamer Maxime Ripard
2011-09-28 11:48 ` [Buildroot] [PATCH 4/4] Add the libplayer package Maxime Ripard
2011-09-30 19:44 ` Thomas Petazzoni
2011-09-30 21:48 ` Maxime Ripard
2011-10-01 11:20 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2011-10-03 10:10 [Buildroot] [pull request v2] Pull request for branch for-2011.11/packages Maxime Ripard
2011-10-03 10:10 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-10-05 19:51 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110930214614.1d844b95@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox