From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] Add the picocom package
Date: Wed, 05 Oct 2011 21:51:00 +0200 [thread overview]
Message-ID: <87fwj7nrob.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <b1bcdc61348588f371f00063e571c4d78cd8f4ae.1317636624.git.maxime.ripard@free-electrons.com> (Maxime Ripard's message of "Mon, 3 Oct 2011 12:10:31 +0200")
>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:
Maxime> From: Maxime Ripard <maxime@free-electrons.com>
Maxime> Signed-off-by: Maxime Ripard <maxime@free-electrons.com>
Maxime> ---
Maxime> +++ b/package/picocom/Config.in
Maxime> @@ -0,0 +1,9 @@
Maxime> +config BR2_PACKAGE_PICOCOM
Maxime> + bool "picocom"
Maxime> + help
Maxime> + picocom is a minimal dumb-terminal emulation program. It
Maxime> + is, in principle, very much like minicom, only it's pico
Maxime> + instead of mini!
Maxime> +
nitpick, help text is indented with <tab><space><space>, not 3 spaces.
Maxime> + http://code.google.com/p/picocom/
Maxime> +
You have an extra blank line here and in the .mk.
Committed with those small fixes, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-10-05 19:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 10:10 [Buildroot] [pull request v2] Pull request for branch for-2011.11/packages Maxime Ripard
2011-10-03 10:10 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-10-05 19:51 ` Peter Korsgaard [this message]
2011-10-03 10:10 ` [Buildroot] [PATCH 2/4] Add Transmission package Maxime Ripard
2011-10-05 20:01 ` Peter Korsgaard
2011-10-07 12:34 ` Maxime Ripard
2011-10-12 15:22 ` [Buildroot] [PATCH] " Maxime Ripard
2011-11-14 12:17 ` Maxime Ripard
2011-11-17 20:03 ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 3/4] Add lame support in gstreamer Maxime Ripard
2011-10-05 20:02 ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 4/4] Add the libplayer package Maxime Ripard
2011-10-05 20:16 ` Peter Korsgaard
2011-10-06 8:19 ` Thomas Petazzoni
2011-10-06 8:47 ` Peter Korsgaard
2011-10-06 9:08 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2011-09-28 11:48 [Buildroot] [pull request] Pull request for branch for-2011.11/packages Maxime Ripard
2011-09-28 11:48 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-09-30 19:46 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwj7nrob.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox