Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/4] Add the libplayer package
Date: Thu, 06 Oct 2011 11:08:59 +0200	[thread overview]
Message-ID: <87mxde4hck.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d0ce7b4624a0a4fc886c8fcbc9c6730e7a931981.1317636624.git.maxime.ripard@free-electrons.com> (Maxime Ripard's message of "Mon, 3 Oct 2011 12:10:34 +0200")

>>>>> "Maxime" == Maxime Ripard <maxime.ripard@free-electrons.com> writes:

 Maxime> From: Maxime Ripard <maxime@free-electrons.com>
 Maxime> Signed-off-by: Maxime Ripard <maxime@free-electrons.com>

Committed with minor changes, thanks.

 Maxime> diff --git a/package/multimedia/libplayer/Config.in b/package/multimedia/libplayer/Config.in
 Maxime> new file mode 100644
 Maxime> index 0000000..38315ec
 Maxime> --- /dev/null
 Maxime> +++ b/package/multimedia/libplayer/Config.in
 Maxime> @@ -0,0 +1,27 @@
 Maxime> +config BR2_PACKAGE_LIBPLAYER
 Maxime> +	depends on BR2_LARGEFILE
 Maxime> +	bool "libplayer"
 Maxime> +	help
 Maxime> +	  libplayer provides a generic A/V API that relies on various multimedia
 Maxime> +	  player for Linux systems. It currently supports MPlayer, xine VLC and
 Maxime> +	  GStreamer only
 Maxime> +
 Maxime> +	  http://libplayer.geexbox.org/
 Maxime> +
 Maxime> +comment "Libplayer requires a toolchain with LARGEFILE support"
 Maxime> +	depends on !BR2_LARGEFILE
 Maxime> +

This should be at the bottom of the file (after the sub options),
otherwise those don't get indented under BR2_PACKAGE_LIBPLAYER

 Maxime> +if BR2_PACKAGE_LIBPLAYER
 Maxime> +config BR2_PACKAGE_LIBPLAYER_MPLAYER
 Maxime> +	depends on BR2_PACKAGE_MPLAYER
 Maxime> +	bool "Libplayer mplayer backend"

It's not really clear for people who don't know the libplayer
implementation that they need to go and enable mplayer/gstreamer to get
libplayer to do anything useful, so I've changed these 'depends on' to
select like we normally do for libraries (yes, mplayer isn't really a
library, but here it is used as one).

At the same time I tweaked the option names a bit.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2011-10-06  9:08 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-03 10:10 [Buildroot] [pull request v2] Pull request for branch for-2011.11/packages Maxime Ripard
2011-10-03 10:10 ` [Buildroot] [PATCH 1/4] Add the picocom package Maxime Ripard
2011-10-05 19:51   ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 2/4] Add Transmission package Maxime Ripard
2011-10-05 20:01   ` Peter Korsgaard
2011-10-07 12:34     ` Maxime Ripard
2011-10-12 15:22   ` [Buildroot] [PATCH] " Maxime Ripard
2011-11-14 12:17     ` Maxime Ripard
2011-11-17 20:03     ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 3/4] Add lame support in gstreamer Maxime Ripard
2011-10-05 20:02   ` Peter Korsgaard
2011-10-03 10:10 ` [Buildroot] [PATCH 4/4] Add the libplayer package Maxime Ripard
2011-10-05 20:16   ` Peter Korsgaard
2011-10-06  8:19     ` Thomas Petazzoni
2011-10-06  8:47       ` Peter Korsgaard
2011-10-06  9:08   ` Peter Korsgaard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-28 11:48 [Buildroot] [pull request] Pull request for branch for-2011.11/packages Maxime Ripard
2011-09-28 11:48 ` [Buildroot] [PATCH 4/4] Add the libplayer package Maxime Ripard
2011-09-30 19:44   ` Thomas Petazzoni
2011-09-30 21:48     ` Maxime Ripard
2011-10-01 11:20       ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxde4hck.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox