From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2
Date: Tue, 4 Oct 2011 08:14:04 +0200 [thread overview]
Message-ID: <201110040814.04539.arnout@mind.be> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F39DC56AC8@AUSP01VMBX24.collaborationhost.net>
On Monday 03 October 2011 19:06:08, H Hartley Sweeten wrote:
> Rename the libsigc package to libsigc2 so that the older 1.2 version
> of libsigc++ can also be added to packages/.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> ---
>
> diff --git a/package/Config.in b/package/Config.in
> index 8b9c816..d77c29f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -351,7 +351,7 @@ source "package/libffi/Config.in"
> source "package/libglib2/Config.in"
> source "package/libnspr/Config.in"
> source "package/liboil/Config.in"
> -source "package/libsigc/Config.in"
> +source "package/libsigc2/Config.in"
> source "package/orc/Config.in"
> source "package/startup-notification/Config.in"
> endmenu
> diff --git a/package/libsigc/Config.in b/package/libsigc/Config.in
> deleted file mode 100644
> index 93fa3f4..0000000
> --- a/package/libsigc/Config.in
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -config BR2_PACKAGE_LIBSIGC
> - bool "libsigc++"
> - depends on BR2_INSTALL_LIBSTDCPP
> - help
> - libsigc++ implements a typesafe callback system for standard C++.
> - It allows you to define signals and to connect those signals to
> - any callback function, either global or a member function,
> - regardless of whether it is static or virtual.
> -
> - http://libsigc.sourceforge.net/
> -
> -comment "libsigc++ requires a toolchain with C++ support enabled"
> - depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsigc/libsigc.mk b/package/libsigc/libsigc.mk
> deleted file mode 100644
> index 4c443eb..0000000
> --- a/package/libsigc/libsigc.mk
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#############################################################
> -#
> -# libsigc++
> -#
> -#############################################################
> -LIBSIGC_VERSION = 2.2.8
> -LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
> -LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
> -LIBSIGC_INSTALL_STAGING = YES
> -
> -$(eval $(call AUTOTARGETS))
> diff --git a/package/libsigc2/Config.in b/package/libsigc2/Config.in
> new file mode 100644
> index 0000000..cae8da1
> --- /dev/null
> +++ b/package/libsigc2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBSIGC
Shouldn't it be renamed BR2_PACKAGE_LIBSIGC2 then?
Perhaps adding a hidden BR2_PACKAGE_LIBSIGC for backwards compatibility, like
so (untested):
bool BR2_PACKAGE_LIBSIGC
select BR2_PACKAGE_LIBSIGC2
> + bool "libsigc++ 2.2"
> + depends on BR2_INSTALL_LIBSTDCPP
> + help
> + libsigc++ implements a typesafe callback system for standard C++.
> + It allows you to define signals and to connect those signals to
> + any callback function, either global or a member function,
> + regardless of whether it is static or virtual.
> +
> + http://libsigc.sourceforge.net/
> +
> +comment "libsigc++ requires a toolchain with C++ support enabled"
> + depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsigc2/libsigc2.mk b/package/libsigc2/libsigc2.mk
> new file mode 100644
> index 0000000..72fff07
> --- /dev/null
> +++ b/package/libsigc2/libsigc2.mk
> @@ -0,0 +1,11 @@
> +#############################################################
> +#
> +# libsigc++ 2.2
> +#
> +#############################################################
> +LIBSIGC_VERSION = 2.2.8
> +LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
> +LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
> +LIBSIGC_INSTALL_STAGING = YES
> +
> +$(eval $(call AUTOTARGETS))
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
next prev parent reply other threads:[~2011-10-04 6:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 17:06 [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2 H Hartley Sweeten
2011-10-04 6:14 ` Arnout Vandecappelle [this message]
2011-10-04 16:55 ` H Hartley Sweeten
2011-10-04 16:47 ` [Buildroot] [PATCH v2] " H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201110040814.04539.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox