Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2
@ 2011-10-03 17:06 H Hartley Sweeten
  2011-10-04  6:14 ` Arnout Vandecappelle
  2011-10-04 16:47 ` [Buildroot] [PATCH v2] " H Hartley Sweeten
  0 siblings, 2 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-10-03 17:06 UTC (permalink / raw)
  To: buildroot

Rename the libsigc package to libsigc2 so that the older 1.2 version
of libsigc++ can also be added to packages/.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/package/Config.in b/package/Config.in
index 8b9c816..d77c29f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -351,7 +351,7 @@ source "package/libffi/Config.in"
 source "package/libglib2/Config.in"
 source "package/libnspr/Config.in"
 source "package/liboil/Config.in"
-source "package/libsigc/Config.in"
+source "package/libsigc2/Config.in"
 source "package/orc/Config.in"
 source "package/startup-notification/Config.in"
 endmenu
diff --git a/package/libsigc/Config.in b/package/libsigc/Config.in
deleted file mode 100644
index 93fa3f4..0000000
--- a/package/libsigc/Config.in
+++ /dev/null
@@ -1,13 +0,0 @@
-config BR2_PACKAGE_LIBSIGC
-	bool "libsigc++"
-	depends on BR2_INSTALL_LIBSTDCPP
-	help
-	  libsigc++ implements a typesafe callback system for standard C++.
-	  It allows you to define signals and to connect those signals to
-	  any callback function, either global or a member function,
-	  regardless of whether it is static or virtual.
-
-	  http://libsigc.sourceforge.net/
-
-comment "libsigc++ requires a toolchain with C++ support enabled"
-	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libsigc/libsigc.mk b/package/libsigc/libsigc.mk
deleted file mode 100644
index 4c443eb..0000000
--- a/package/libsigc/libsigc.mk
+++ /dev/null
@@ -1,11 +0,0 @@
-#############################################################
-#
-# libsigc++
-#
-#############################################################
-LIBSIGC_VERSION = 2.2.8
-LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
-LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
-LIBSIGC_INSTALL_STAGING = YES
-
-$(eval $(call AUTOTARGETS))
diff --git a/package/libsigc2/Config.in b/package/libsigc2/Config.in
new file mode 100644
index 0000000..cae8da1
--- /dev/null
+++ b/package/libsigc2/Config.in
@@ -0,0 +1,13 @@
+config BR2_PACKAGE_LIBSIGC
+	bool "libsigc++ 2.2"
+	depends on BR2_INSTALL_LIBSTDCPP
+	help
+	  libsigc++ implements a typesafe callback system for standard C++.
+	  It allows you to define signals and to connect those signals to
+	  any callback function, either global or a member function,
+	  regardless of whether it is static or virtual.
+
+	  http://libsigc.sourceforge.net/
+
+comment "libsigc++ requires a toolchain with C++ support enabled"
+	depends on !BR2_INSTALL_LIBSTDCPP
diff --git a/package/libsigc2/libsigc2.mk b/package/libsigc2/libsigc2.mk
new file mode 100644
index 0000000..72fff07
--- /dev/null
+++ b/package/libsigc2/libsigc2.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# libsigc++ 2.2
+#
+#############################################################
+LIBSIGC_VERSION = 2.2.8
+LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
+LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
+LIBSIGC_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2
  2011-10-03 17:06 [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2 H Hartley Sweeten
@ 2011-10-04  6:14 ` Arnout Vandecappelle
  2011-10-04 16:55   ` H Hartley Sweeten
  2011-10-04 16:47 ` [Buildroot] [PATCH v2] " H Hartley Sweeten
  1 sibling, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2011-10-04  6:14 UTC (permalink / raw)
  To: buildroot


On Monday 03 October 2011 19:06:08, H Hartley Sweeten wrote:
> Rename the libsigc package to libsigc2 so that the older 1.2 version
> of libsigc++ can also be added to packages/.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> 
> ---
> 
> diff --git a/package/Config.in b/package/Config.in
> index 8b9c816..d77c29f 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -351,7 +351,7 @@ source "package/libffi/Config.in"
>  source "package/libglib2/Config.in"
>  source "package/libnspr/Config.in"
>  source "package/liboil/Config.in"
> -source "package/libsigc/Config.in"
> +source "package/libsigc2/Config.in"
>  source "package/orc/Config.in"
>  source "package/startup-notification/Config.in"
>  endmenu
> diff --git a/package/libsigc/Config.in b/package/libsigc/Config.in
> deleted file mode 100644
> index 93fa3f4..0000000
> --- a/package/libsigc/Config.in
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -config BR2_PACKAGE_LIBSIGC
> -	bool "libsigc++"
> -	depends on BR2_INSTALL_LIBSTDCPP
> -	help
> -	  libsigc++ implements a typesafe callback system for standard C++.
> -	  It allows you to define signals and to connect those signals to
> -	  any callback function, either global or a member function,
> -	  regardless of whether it is static or virtual.
> -
> -	  http://libsigc.sourceforge.net/
> -
> -comment "libsigc++ requires a toolchain with C++ support enabled"
> -	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsigc/libsigc.mk b/package/libsigc/libsigc.mk
> deleted file mode 100644
> index 4c443eb..0000000
> --- a/package/libsigc/libsigc.mk
> +++ /dev/null
> @@ -1,11 +0,0 @@
> -#############################################################
> -#
> -# libsigc++
> -#
> -#############################################################
> -LIBSIGC_VERSION = 2.2.8
> -LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
> -LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
> -LIBSIGC_INSTALL_STAGING = YES
> -
> -$(eval $(call AUTOTARGETS))
> diff --git a/package/libsigc2/Config.in b/package/libsigc2/Config.in
> new file mode 100644
> index 0000000..cae8da1
> --- /dev/null
> +++ b/package/libsigc2/Config.in
> @@ -0,0 +1,13 @@
> +config BR2_PACKAGE_LIBSIGC

 Shouldn't it be renamed BR2_PACKAGE_LIBSIGC2 then?

 Perhaps adding a hidden BR2_PACKAGE_LIBSIGC for backwards compatibility, like 
so (untested):

bool BR2_PACKAGE_LIBSIGC
   select BR2_PACKAGE_LIBSIGC2

> +	bool "libsigc++ 2.2"
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	help
> +	  libsigc++ implements a typesafe callback system for standard C++.
> +	  It allows you to define signals and to connect those signals to
> +	  any callback function, either global or a member function,
> +	  regardless of whether it is static or virtual.
> +
> +	  http://libsigc.sourceforge.net/
> +
> +comment "libsigc++ requires a toolchain with C++ support enabled"
> +	depends on !BR2_INSTALL_LIBSTDCPP
> diff --git a/package/libsigc2/libsigc2.mk b/package/libsigc2/libsigc2.mk
> new file mode 100644
> index 0000000..72fff07
> --- /dev/null
> +++ b/package/libsigc2/libsigc2.mk
> @@ -0,0 +1,11 @@
> +#############################################################
> +#
> +# libsigc++ 2.2
> +#
> +#############################################################
> +LIBSIGC_VERSION = 2.2.8
> +LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
> +LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
> +LIBSIGC_INSTALL_STAGING = YES
> +
> +$(eval $(call AUTOTARGETS))
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v2] Rename package/libsigc to package/libsigc2
  2011-10-03 17:06 [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2 H Hartley Sweeten
  2011-10-04  6:14 ` Arnout Vandecappelle
@ 2011-10-04 16:47 ` H Hartley Sweeten
  1 sibling, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-10-04 16:47 UTC (permalink / raw)
  To: buildroot

Rename the libsigc package to libsigc2 so that the older 1.2 version
of libsigc++ can also be added to packages/.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>

---

diff --git a/package/Config.in b/package/Config.in
index 8b9c816..d77c29f 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -351,7 +351,7 @@ source "package/libffi/Config.in"
 source "package/libglib2/Config.in"
 source "package/libnspr/Config.in"
 source "package/liboil/Config.in"
-source "package/libsigc/Config.in"
+source "package/libsigc2/Config.in"
 source "package/orc/Config.in"
 source "package/startup-notification/Config.in"
 endmenu
diff --git a/package/libsigc/libsigc.mk b/package/libsigc/libsigc.mk
deleted file mode 100644
index 4c443eb..0000000
--- a/package/libsigc/libsigc.mk
+++ /dev/null
@@ -1,11 +0,0 @@
-#############################################################
-#
-# libsigc++
-#
-#############################################################
-LIBSIGC_VERSION = 2.2.8
-LIBSIGC_SOURCE = libsigc++-$(LIBSIGC_VERSION).tar.bz2
-LIBSIGC_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
-LIBSIGC_INSTALL_STAGING = YES
-
-$(eval $(call AUTOTARGETS))
diff --git a/package/libsigc/Config.in b/package/libsigc2/Config.in
similarity index 89%
rename from package/libsigc/Config.in
rename to package/libsigc2/Config.in
index 93fa3f4..433d0b7 100644
--- a/package/libsigc/Config.in
+++ b/package/libsigc2/Config.in
@@ -1,5 +1,5 @@
-config BR2_PACKAGE_LIBSIGC
-	bool "libsigc++"
+config BR2_PACKAGE_LIBSIGC2
+	bool "libsigc++ 2.2"
 	depends on BR2_INSTALL_LIBSTDCPP
 	help
 	  libsigc++ implements a typesafe callback system for standard C++.
diff --git a/package/libsigc2/libsigc2.mk b/package/libsigc2/libsigc2.mk
new file mode 100644
index 0000000..036ac6a
--- /dev/null
+++ b/package/libsigc2/libsigc2.mk
@@ -0,0 +1,11 @@
+#############################################################
+#
+# libsigc++ 2.2
+#
+#############################################################
+LIBSIGC2_VERSION = 2.2.8
+LIBSIGC2_SOURCE = libsigc++-$(LIBSIGC2_VERSION).tar.bz2
+LIBSIGC2_SITE = http://ftp.gnome.org/pub/GNOME/sources/libsigc++/2.2
+LIBSIGC2_INSTALL_STAGING = YES
+
+$(eval $(call AUTOTARGETS))

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2
  2011-10-04  6:14 ` Arnout Vandecappelle
@ 2011-10-04 16:55   ` H Hartley Sweeten
  0 siblings, 0 replies; 4+ messages in thread
From: H Hartley Sweeten @ 2011-10-04 16:55 UTC (permalink / raw)
  To: buildroot

On Monday, October 03, 2011 11:14 PM, Arnout Vandecappelle wrote:
> On Monday 03 October 2011 19:06:08, H Hartley Sweeten wrote:
>> Rename the libsigc package to libsigc2 so that the older 1.2 version
>> of libsigc++ can also be added to packages/.
>> 
>> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>> 
>> ---

[...]

>> diff --git a/package/libsigc2/Config.in b/package/libsigc2/Config.in
>> new file mode 100644
>> index 0000000..cae8da1
>> --- /dev/null
>> +++ b/package/libsigc2/Config.in
>> @@ -0,0 +1,13 @@
>> +config BR2_PACKAGE_LIBSIGC
>
>  Shouldn't it be renamed BR2_PACKAGE_LIBSIGC2 then?

Yes, it should be... I missed that, sorry.  I just posted a new patch.

>  Perhaps adding a hidden BR2_PACKAGE_LIBSIGC for backwards compatibility, like 
> so (untested):
>
> bool BR2_PACKAGE_LIBSIGC
>    select BR2_PACKAGE_LIBSIGC2

No.  Nothing in Buildroot currently has this version of libsigc++ as a dependency
so there shouldn't be any backward compatibility issues.

Thanks,
Hartley

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-10-04 16:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-03 17:06 [Buildroot] [PATCH] Rename package/libsigc to package/libsigc2 H Hartley Sweeten
2011-10-04  6:14 ` Arnout Vandecappelle
2011-10-04 16:55   ` H Hartley Sweeten
2011-10-04 16:47 ` [Buildroot] [PATCH v2] " H Hartley Sweeten

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox