Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2] New package: ImLib2
@ 2011-10-11 10:26 yegorslists at googlemail.com
  2011-10-11 16:17 ` Arnout Vandecappelle
  0 siblings, 1 reply; 14+ messages in thread
From: yegorslists at googlemail.com @ 2011-10-11 10:26 UTC (permalink / raw)
  To: buildroot

From: Yegor Yefremov <yegorslists@googlemail.com>

Signed-off-by: Frederic Bassaler <frederic.bassaler@gmail.com>
Signed-off-by: Matias Garcia <mgarcia@rossvideo.com>
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
Changes v2: add libXext dependency

 package/Config.in        |    1 +
 package/imlib2/Config.in |   38 +++++++++++++++++++++++++++++
 package/imlib2/imlib2.mk |   60 ++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 99 insertions(+), 0 deletions(-)
 create mode 100644 package/imlib2/Config.in
 create mode 100644 package/imlib2/imlib2.mk

diff --git a/package/Config.in b/package/Config.in
index 7dc8887..7a7b4bf 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -282,6 +282,7 @@ source "package/fontconfig/Config.in"
 source "package/freetype/Config.in"
 source "package/gtk2-engines/Config.in"
 source "package/gtk2-themes/Config.in"
+source "package/imlib2/Config.in"
 source "package/jpeg/Config.in"
 source "package/libart/Config.in"
 source "package/libdrm/Config.in"
diff --git a/package/imlib2/Config.in b/package/imlib2/Config.in
new file mode 100644
index 0000000..9b6ee98
--- /dev/null
+++ b/package/imlib2/Config.in
@@ -0,0 +1,38 @@
+config BR2_PACKAGE_IMLIB2
+	bool "imlib2"
+	help
+	  Imlib 2 is the successor to Imlib.
+
+	  http://freshmeat.net/projects/imlib2/
+
+if BR2_PACKAGE_IMLIB2
+
+config BR2_PACKAGE_IMLIB2_JPEG
+	select BR2_PACKAGE_JPEG
+	bool "JPEG support"
+
+config BR2_PACKAGE_IMLIB2_PNG
+	select BR2_PACKAGE_LIBPNG
+	bool "PNG support"
+
+config BR2_PACKAGE_IMLIB2_GIF
+	select BR2_PACKAGE_LIBUNGIF
+	bool "GIF support"
+
+config BR2_PACKAGE_IMLIB2_TIFF
+	select BR2_PACKAGE_TIFF
+	bool "TIFF support"
+
+config BR2_PACKAGE_IMLIB2_FREETYPE
+	select BR2_PACKAGE_FREETYPE
+	bool "FreeType support"
+
+config BR2_PACKAGE_IMLIB2_ID3
+	select BR2_PACKAGE_LIBID3TAG
+	bool "ID3 support"
+
+config BR2_PACKAGE_IMLIB2_X
+	select BR2_PACKAGE_XLIB_LIBX11
+	select BR2_PACKAGE_XLIB_LIBXEXT
+	bool "X support"
+endif
diff --git a/package/imlib2/imlib2.mk b/package/imlib2/imlib2.mk
new file mode 100644
index 0000000..5a274ee
--- /dev/null
+++ b/package/imlib2/imlib2.mk
@@ -0,0 +1,60 @@
+#############################################################
+#
+## IMLIB2
+#
+##############################################################
+IMLIB2_VERSION = 1.4.5
+IMLIB2_SOURCE = imlib2-$(IMLIB2_VERSION).tar.bz2
+IMLIB2_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/project/enlightenment/imlib2-src/$(IMLIB2_VERSION)/
+IMLIB2_INSTALL_STAGING = YES
+IMLIB2_DEPENDENCIES = host-pkg-config
+
+ifeq ($(BR2_PACKAGE_IMLIB2_X),y)
+	IMLIB2_CONF_OPT += --with-x
+	IMLIB2_DEPENDENCIES += xlib_libX11 xlib_libXext
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_FREETYPE),y)
+	IMLIB2_CONF_OPT += --with-freetype-config=$(STAGING_DIR)/usr/bin/freetype-config
+	IMLIB2_DEPENDENCIES += freetype
+else
+	IMLIB2_CONF_OPT += --without-freetype
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_JPEG),y)
+	IMLIB2_CONF_OPT += --with-jpeg
+	IMLIB2_DEPENDENCIES += jpeg
+else
+	IMLIB2_CONF_OPT += --without-jpeg
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_PNG),y)
+	IMLIB2_CONF_OPT += --with-png
+	IMLIB2_DEPENDENCIES += libpng
+else
+	IMLIB2_CONF_OPT += --without-png
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_GIF),y)
+	IMLIB2_CONF_OPT += --with-gif
+	IMLIB2_DEPENDENCIES += libungif
+else
+	IMLIB2_CONF_OPT += --without-gif
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_TIFF),y)
+	IMLIB2_CONF_OPT += --with-tiff
+	IMLIB2_DEPENDENCIES += tiff
+else
+	IMLIB2_CONF_OPT += --without-tiff
+endif
+
+ifeq ($(BR2_PACKAGE_IMLIB2_ID3),y)
+	IMLIB2_CONF_OPT += --with-id3
+	IMLIB2_DEPENDENCIES += libid3tag
+else
+	IMLIB2_CONF_OPT += --without-id3
+endif
+
+$(eval $(call AUTOTARGETS))
+
-- 
1.7.1.1

^ permalink raw reply related	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-11 10:26 [Buildroot] [PATCH v2] New package: ImLib2 yegorslists at googlemail.com
@ 2011-10-11 16:17 ` Arnout Vandecappelle
  2011-10-12  9:18   ` Yegor Yefremov
  0 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2011-10-11 16:17 UTC (permalink / raw)
  To: buildroot


On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
[snip]
> +config BR2_PACKAGE_IMLIB2_X
> +	select BR2_PACKAGE_XLIB_LIBX11
> +	select BR2_PACKAGE_XLIB_LIBXEXT
> +	bool "X support"
> +endif

 Shouldn't this depend on BR2_PACKAGE_XORG7 ?

[snip]

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111011/38cd0045/attachment-0001.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-11 16:17 ` Arnout Vandecappelle
@ 2011-10-12  9:18   ` Yegor Yefremov
  2011-10-12  9:25     ` Arnout Vandecappelle
  2011-10-12  9:40     ` Thomas Petazzoni
  0 siblings, 2 replies; 14+ messages in thread
From: Yegor Yefremov @ 2011-10-12  9:18 UTC (permalink / raw)
  To: buildroot

On Tue, Oct 11, 2011 at 6:17 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>
> On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
>
> [snip]
>
>> +config BR2_PACKAGE_IMLIB2_X
>
>> + select BR2_PACKAGE_XLIB_LIBX11
>
>> + select BR2_PACKAGE_XLIB_LIBXEXT
>
>> + bool "X support"
>
>> +endif
>
> Shouldn't this depend on BR2_PACKAGE_XORG7 ?

Thanks for reviewing. I checked these two packages_ libx11 and libxext
and they seem to selected by xorg anyway, so I replaced them by
dependency on  BR2_PACKAGE_XORG7.

Yegor

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:18   ` Yegor Yefremov
@ 2011-10-12  9:25     ` Arnout Vandecappelle
  2011-10-12  9:32       ` Yegor Yefremov
  2011-10-12  9:40     ` Thomas Petazzoni
  1 sibling, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2011-10-12  9:25 UTC (permalink / raw)
  To: buildroot


On Wednesday 12 October 2011 11:18:34, Yegor Yefremov wrote:
> On Tue, Oct 11, 2011 at 6:17 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> >
> > On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
> >
> > [snip]
> >
> >> +config BR2_PACKAGE_IMLIB2_X
> >> + select BR2_PACKAGE_XLIB_LIBX11
> >> + select BR2_PACKAGE_XLIB_LIBXEXT
> >> + bool "X support"
> >> +endif
> >
> > Shouldn't this depend on BR2_PACKAGE_XORG7 ?
> 
> Thanks for reviewing. I checked these two packages_ libx11 and libxext
> and they seem to selected by xorg anyway, so I replaced them by
> dependency on  BR2_PACKAGE_XORG7.

 libXext indeed selects libX11, but I don't see how libXext would be automatically selected...

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:25     ` Arnout Vandecappelle
@ 2011-10-12  9:32       ` Yegor Yefremov
  2011-10-13 22:07         ` Arnout Vandecappelle
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2011-10-12  9:32 UTC (permalink / raw)
  To: buildroot

Am 12.10.2011 11:25, schrieb Arnout Vandecappelle:
> 
> On Wednesday 12 October 2011 11:18:34, Yegor Yefremov wrote:
>> On Tue, Oct 11, 2011 at 6:17 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
>>>
>>> On Tuesday 11 October 2011 12:26:10, yegorslists at googlemail.com wrote:
>>>
>>> [snip]
>>>
>>>> +config BR2_PACKAGE_IMLIB2_X
>>>> + select BR2_PACKAGE_XLIB_LIBX11
>>>> + select BR2_PACKAGE_XLIB_LIBXEXT
>>>> + bool "X support"
>>>> +endif
>>>
>>> Shouldn't this depend on BR2_PACKAGE_XORG7 ?
>>
>> Thanks for reviewing. I checked these two packages_ libx11 and libxext
>> and they seem to selected by xorg anyway, so I replaced them by
>> dependency on  BR2_PACKAGE_XORG7.
> 
>  libXext indeed selects libX11, but I don't see how libXext would be automatically selected...

What about  BR2_PACKAGE_XSERVER_XORG_SERVER [=y] && BR2_PACKAGE_XORG7 [=y] && !BR2_avr32 [=n]?

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:18   ` Yegor Yefremov
  2011-10-12  9:25     ` Arnout Vandecappelle
@ 2011-10-12  9:40     ` Thomas Petazzoni
  2011-10-12  9:44       ` Yegor Yefremov
  1 sibling, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2011-10-12  9:40 UTC (permalink / raw)
  To: buildroot

Le Wed, 12 Oct 2011 11:18:34 +0200,
Yegor Yefremov <yegorslists@googlemail.com> a ?crit :

> Thanks for reviewing. I checked these two packages_ libx11 and libxext
> and they seem to selected by xorg anyway, so I replaced them by
> dependency on  BR2_PACKAGE_XORG7.

The dependencies on X.org are quite a mess these days. Maybe packages
depend on xserver-xorg_server, while they should depend on the X11
libraries that they require.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:40     ` Thomas Petazzoni
@ 2011-10-12  9:44       ` Yegor Yefremov
  2011-10-12  9:53         ` Thomas Petazzoni
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2011-10-12  9:44 UTC (permalink / raw)
  To: buildroot

Am 12.10.2011 11:40, schrieb Thomas Petazzoni:
> Le Wed, 12 Oct 2011 11:18:34 +0200,
> Yegor Yefremov <yegorslists@googlemail.com> a ?crit :
> 
>> Thanks for reviewing. I checked these two packages_ libx11 and libxext
>> and they seem to selected by xorg anyway, so I replaced them by
>> dependency on  BR2_PACKAGE_XORG7.
> 
> The dependencies on X.org are quite a mess these days. Maybe packages
> depend on xserver-xorg_server, while they should depend on the X11
> libraries that they require.

O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that libXext is to be selected. 

Yegor

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:44       ` Yegor Yefremov
@ 2011-10-12  9:53         ` Thomas Petazzoni
  2011-10-12  9:59           ` Yegor Yefremov
  2011-10-13 22:09           ` Arnout Vandecappelle
  0 siblings, 2 replies; 14+ messages in thread
From: Thomas Petazzoni @ 2011-10-12  9:53 UTC (permalink / raw)
  To: buildroot

Le Wed, 12 Oct 2011 11:44:46 +0200,
Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :

> > The dependencies on X.org are quite a mess these days. Maybe
> > packages depend on xserver-xorg_server, while they should depend on
> > the X11 libraries that they require.
> 
> O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that
> libXext is to be selected. 

Yes, but technically speaking, all X11 client libraries and programs
should *not* depend on the X.org server, but rather on the needed X11
libraries. For several reasons:

 *) Because technically, the clients don't require the server to
    already be built ;

 *) Because if one day, we manage to enable parallel building of
    packages, it is great to have correct dependencies ;

 *) Because you can imagine a setup in which you build several X11
    client libraries and programs, but not the X server, and the
    X applications display their windows to a remote X server, which is
    not built by Buildroot.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:53         ` Thomas Petazzoni
@ 2011-10-12  9:59           ` Yegor Yefremov
  2011-10-13 22:09           ` Arnout Vandecappelle
  1 sibling, 0 replies; 14+ messages in thread
From: Yegor Yefremov @ 2011-10-12  9:59 UTC (permalink / raw)
  To: buildroot

Am 12.10.2011 11:53, schrieb Thomas Petazzoni:
> Le Wed, 12 Oct 2011 11:44:46 +0200,
> Yegor Yefremov <yegor_sub1@visionsystems.de> a ?crit :
>
>>> The dependencies on X.org are quite a mess these days. Maybe
>>> packages depend on xserver-xorg_server, while they should depend on
>>> the X11 libraries that they require.
>> O.K. BR2_PACKAGE_XSERVER_XORG_SERVER definitely specifies that
>> libXext is to be selected. 
> Yes, but technically speaking, all X11 client libraries and programs
> should *not* depend on the X.org server, but rather on the needed X11
> libraries. For several reasons:
>
>  *) Because technically, the clients don't require the server to
>     already be built ;
>
>  *) Because if one day, we manage to enable parallel building of
>     packages, it is great to have correct dependencies ;
>
>  *) Because you can imagine a setup in which you build several X11
>     client libraries and programs, but not the X server, and the
>     X applications display their windows to a remote X server, which is
>     not built by Buildroot.

O.K. I make ImLib2 depend on libXext. Du to the fact, that libX11 is selected by libXext I don't need this additional dependency.

For feh I then make 2 dependencies: 

BR2_PACKAGE_XLIB_LIBXINERAMA
BR2_PACKAGE_XLIB_LIBXT

Yegor

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:32       ` Yegor Yefremov
@ 2011-10-13 22:07         ` Arnout Vandecappelle
  0 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2011-10-13 22:07 UTC (permalink / raw)
  To: buildroot


On Wednesday 12 October 2011 11:32:59, Yegor Yefremov wrote:
> >>> Shouldn't this depend on BR2_PACKAGE_XORG7 ?
> >>
> >> Thanks for reviewing. I checked these two packages_ libx11 and libxext
> >> and they seem to selected by xorg anyway, so I replaced them by
> >> dependency on  BR2_PACKAGE_XORG7.
> > 
> >  libXext indeed selects libX11, but I don't see how libXext would be automatically selected...
> 
> What about  BR2_PACKAGE_XSERVER_XORG_SERVER [=y] && BR2_PACKAGE_XORG7 [=y] && !BR2_avr32 [=n]?

 Yes, but you can usefully build ImLib2 without an Xserver.  BR2_PACKAGE_XSERVER_XORG_SERVER does not get selected by BR2_PACKAGE_XORG7.

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/bb50d761/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-12  9:53         ` Thomas Petazzoni
  2011-10-12  9:59           ` Yegor Yefremov
@ 2011-10-13 22:09           ` Arnout Vandecappelle
  2011-10-14  6:36             ` Thomas Petazzoni
  1 sibling, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2011-10-13 22:09 UTC (permalink / raw)
  To: buildroot


On Wednesday 12 October 2011 11:53:17, Thomas Petazzoni wrote:
>  *) Because if one day, we manage to enable parallel building of
>     packages, it is great to have correct dependencies ;

 Actually that would only be for Makefile dependencies, not for Kconfig dependencies...

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111014/142f2e32/attachment.html>

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-13 22:09           ` Arnout Vandecappelle
@ 2011-10-14  6:36             ` Thomas Petazzoni
  2011-10-14  7:51               ` Yegor Yefremov
  0 siblings, 1 reply; 14+ messages in thread
From: Thomas Petazzoni @ 2011-10-14  6:36 UTC (permalink / raw)
  To: buildroot

Le Fri, 14 Oct 2011 00:09:13 +0200,
Arnout Vandecappelle <arnout@mind.be> a ?crit :

>  Actually that would only be for Makefile dependencies, not for
> Kconfig dependencies...

True, but this is also wrong currently for Makefile dependencies:

cairo/cairo.mk: CAIRO_DEPENDENCIES += xserver_xorg-server
docker/docker.mk:DOCKER_DEPENDENCIES = host-pkg-config libglib2 xserver_xorg-server
fltk/fltk.mk:FLTK_DEPENDENCIES = xserver_xorg-server xlib_libXt
games/rubix/rubix.mk:RUBIX_DEPENDENCIES = xserver_xorg-server
java/classpath/classpath.mk:    CLASSPATH_DEPENDENCIES+= xserver_xorg-server
java/jamvm/jamvm.mk:    JAMVM_DEPENDENCIES+= xserver_xorg-server
libgtk2/libgtk2.mk:     LIBGTK2_DEPENDENCIES += xlib_libXcomposite xserver_xorg-server
metacity/metacity.mk:METACITY_DEPENDENCIES = libgtk2 xserver_xorg-server
pango/pango.mk: PANGO_DEPENDENCIES += xserver_xorg-server
pcmanfm/pcmanfm.mk:PCMANFM_DEPENDENCIES = host-pkg-config libgtk2 gamin startup-notification xserver_xorg-server
sdl/sdl.mk:SDL_DEPENDENCIES += xserver_xorg-server
synergy/synergy.mk:SYNERGY_DEPENDENCIES = xserver_xorg-server xlib_libXtst
torsmo/torsmo.mk:TORSMO_DEPENDENCIES = xserver_xorg-server
webkit/webkit.mk:       WEBKIT_DEPENDENCIES += xserver_xorg-server xlib_libXt

I don't think any of these actually require the X.org server to be built.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-14  6:36             ` Thomas Petazzoni
@ 2011-10-14  7:51               ` Yegor Yefremov
  2011-10-14  8:05                 ` Arnout Vandecappelle
  0 siblings, 1 reply; 14+ messages in thread
From: Yegor Yefremov @ 2011-10-14  7:51 UTC (permalink / raw)
  To: buildroot

Am 14.10.2011 08:36, schrieb Thomas Petazzoni:
> Le Fri, 14 Oct 2011 00:09:13 +0200,
> Arnout Vandecappelle <arnout@mind.be> a ?crit :
> 
>>  Actually that would only be for Makefile dependencies, not for
>> Kconfig dependencies...
> 
> True, but this is also wrong currently for Makefile dependencies:
> 
> cairo/cairo.mk: CAIRO_DEPENDENCIES += xserver_xorg-server
> docker/docker.mk:DOCKER_DEPENDENCIES = host-pkg-config libglib2 xserver_xorg-server
> fltk/fltk.mk:FLTK_DEPENDENCIES = xserver_xorg-server xlib_libXt
> games/rubix/rubix.mk:RUBIX_DEPENDENCIES = xserver_xorg-server
> java/classpath/classpath.mk:    CLASSPATH_DEPENDENCIES+= xserver_xorg-server
> java/jamvm/jamvm.mk:    JAMVM_DEPENDENCIES+= xserver_xorg-server
> libgtk2/libgtk2.mk:     LIBGTK2_DEPENDENCIES += xlib_libXcomposite xserver_xorg-server
> metacity/metacity.mk:METACITY_DEPENDENCIES = libgtk2 xserver_xorg-server
> pango/pango.mk: PANGO_DEPENDENCIES += xserver_xorg-server
> pcmanfm/pcmanfm.mk:PCMANFM_DEPENDENCIES = host-pkg-config libgtk2 gamin startup-notification xserver_xorg-server
> sdl/sdl.mk:SDL_DEPENDENCIES += xserver_xorg-server
> synergy/synergy.mk:SYNERGY_DEPENDENCIES = xserver_xorg-server xlib_libXtst
> torsmo/torsmo.mk:TORSMO_DEPENDENCIES = xserver_xorg-server
> webkit/webkit.mk:       WEBKIT_DEPENDENCIES += xserver_xorg-server xlib_libXt
> 
> I don't think any of these actually require the X.org server to be built.

As far as I understand the dependencies should look like this:

for ImLib2

depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */
select BR2_PACKAGE_XLIB_LIBX11
select BR2_PACKAGE_XLIB_LIBXEXT

for feh

depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */
select BR2_PACKAGE_XLIB_LIBXINERAMA
select BR2_PACKAGE_XLIB_LIBXT

Do we agree on this scheme?

Yegor

^ permalink raw reply	[flat|nested] 14+ messages in thread

* [Buildroot] [PATCH v2] New package: ImLib2
  2011-10-14  7:51               ` Yegor Yefremov
@ 2011-10-14  8:05                 ` Arnout Vandecappelle
  0 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2011-10-14  8:05 UTC (permalink / raw)
  To: buildroot


On Friday 14 October 2011 09:51:28, Yegor Yefremov wrote:
> As far as I understand the dependencies should look like this:
> 
> for ImLib2
> 
> depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */
> select BR2_PACKAGE_XLIB_LIBX11
> select BR2_PACKAGE_XLIB_LIBXEXT
> 
> for feh
> 
> depends on BR2_PACKAGE_XORG7 /* because it is some kind of subsystem */
> select BR2_PACKAGE_XLIB_LIBXINERAMA
> select BR2_PACKAGE_XLIB_LIBXT
> 
> Do we agree on this scheme?

 I'm sorry, I have to correct myself again...  In xlib_libXext.mk we can find

XLIB_LIBXEXT_DEPENDENCIES = xlib_libX11 xproto_xextproto xproto_xproto

 Since ImLib2's configure doesn't need to be informed about libX11 directly, that dependency is redundant after all - both in Config.in and in imlib2.mk.

 That said, it doesn't hurt to keep it.

 Regards,
 Arnout
-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  31BB CF53 8660 6F88 345D  54CC A836 5879 20D7 CF43

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2011-10-14  8:05 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-11 10:26 [Buildroot] [PATCH v2] New package: ImLib2 yegorslists at googlemail.com
2011-10-11 16:17 ` Arnout Vandecappelle
2011-10-12  9:18   ` Yegor Yefremov
2011-10-12  9:25     ` Arnout Vandecappelle
2011-10-12  9:32       ` Yegor Yefremov
2011-10-13 22:07         ` Arnout Vandecappelle
2011-10-12  9:40     ` Thomas Petazzoni
2011-10-12  9:44       ` Yegor Yefremov
2011-10-12  9:53         ` Thomas Petazzoni
2011-10-12  9:59           ` Yegor Yefremov
2011-10-13 22:09           ` Arnout Vandecappelle
2011-10-14  6:36             ` Thomas Petazzoni
2011-10-14  7:51               ` Yegor Yefremov
2011-10-14  8:05                 ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox