* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
@ 2011-10-19 20:55 Damian Kaczmarek
2011-10-19 21:27 ` Yann E. MORIN
2011-10-19 22:46 ` Arnout Vandecappelle
0 siblings, 2 replies; 6+ messages in thread
From: Damian Kaczmarek @ 2011-10-19 20:55 UTC (permalink / raw)
To: buildroot
Signed-off-by: Damian Kaczmarek <damian@veritymedical.co.uk>
---
package/lsof/lsof.mk | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/package/lsof/lsof.mk b/package/lsof/lsof.mk
index ff76f92..bfdfee3 100644
--- a/package/lsof/lsof.mk
+++ b/package/lsof/lsof.mk
@@ -35,6 +35,7 @@ endif
# The .tar.bz2 contains another .tar, which contains the source code.
define LSOF_EXTRACT_TAR
$(TAR) $(TAR_STRIP_COMPONENTS)=1 -xf $(@D)/lsof_$(LSOF_VERSION)_src.tar -C $(@D)
+ chmod +w -R $(@D)
rm -f $(@D)/lsof_$(LSOF_VERSION)_src.tar
endef
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
2011-10-19 20:55 [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE) Damian Kaczmarek
@ 2011-10-19 21:27 ` Yann E. MORIN
2011-10-19 22:46 ` Arnout Vandecappelle
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2011-10-19 21:27 UTC (permalink / raw)
To: buildroot
On Wednesday 19 October 2011 22:55:45 Damian Kaczmarek wrote:
Summary line is too long, keep it under 80 chars. Something like:
lsof: fix permissions of extracted files
Then you can add a longer description in the commit message:
Add a "chmod" to fix permissions on the lsof sources, because
most files are not writable after extraction, so the patching
fails.
> Signed-off-by: Damian Kaczmarek <damian@veritymedical.co.uk>
After you fix the above, you can add:
Acked-by: "Yann E. MORIN" <yann.morin.1998@anciens.enib.fr>
> ---
> package/lsof/lsof.mk | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/package/lsof/lsof.mk b/package/lsof/lsof.mk
> index ff76f92..bfdfee3 100644
> --- a/package/lsof/lsof.mk
> +++ b/package/lsof/lsof.mk
> @@ -35,6 +35,7 @@ endif
> # The .tar.bz2 contains another .tar, which contains the source code.
> define LSOF_EXTRACT_TAR
> $(TAR) $(TAR_STRIP_COMPONENTS)=1 -xf $(@D)/lsof_$(LSOF_VERSION)_src.tar -C $(@D)
> + chmod +w -R $(@D)
> rm -f $(@D)/lsof_$(LSOF_VERSION)_src.tar
> endef
>
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
2011-10-19 20:55 [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE) Damian Kaczmarek
2011-10-19 21:27 ` Yann E. MORIN
@ 2011-10-19 22:46 ` Arnout Vandecappelle
2011-10-20 11:22 ` Yann E. MORIN
1 sibling, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2011-10-19 22:46 UTC (permalink / raw)
To: buildroot
On Wednesday 19 October 2011 22:55:45, Damian Kaczmarek wrote:
> # The .tar.bz2 contains another .tar, which contains the source code.
> define LSOF_EXTRACT_TAR
> $(TAR) $(TAR_STRIP_COMPONENTS)=1 -xf $(@D)/lsof_$(LSOF_VERSION)_src.tar -C $(@D)
> + chmod +w -R $(@D)
> rm -f $(@D)/lsof_$(LSOF_VERSION)_src.tar
> endef
Perhaps it would be better to override the extract command directly, like:
LSOF_EXTRACT_CMDS = \
$(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
$(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
$(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -)
(completely untested, of course)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
2011-10-19 22:46 ` Arnout Vandecappelle
@ 2011-10-20 11:22 ` Yann E. MORIN
2011-10-20 12:48 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Yann E. MORIN @ 2011-10-20 11:22 UTC (permalink / raw)
To: buildroot
Arnout, All,
On Thursday 20 October 2011 004630 Arnout Vandecappelle wrote:
> On Wednesday 19 October 2011 22:55:45, Damian Kaczmarek wrote:
> > # The .tar.bz2 contains another .tar, which contains the source code.
> > define LSOF_EXTRACT_TAR
> > $(TAR) $(TAR_STRIP_COMPONENTS)=1 -xf $(@D)/lsof_$(LSOF_VERSION)_src.tar -C $(@D)
> > + chmod +w -R $(@D)
> > rm -f $(@D)/lsof_$(LSOF_VERSION)_src.tar
> > endef
>
> Perhaps it would be better to override the extract command directly, like:
>
>
> LSOF_EXTRACT_CMDS = \
> $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
> $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
> $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -)
That would not work, because the first $(TAR) will extract actual files
to the disk, and does not send the extracted files to the stdio, so the
second $(TAR) will get nothing on its stdin (at best), or only get
garbage (at worst).
To extract a tar-in-a-tar, you have to extract the outermost tar, to be
able to extract the innermost one. This _has_ to be a two-step procedure.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ |
| --==< O_o >==-- '------------.-------: X AGAINST | /e\ There is no |
| http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. |
'------------------------------'-------'------------------'--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
2011-10-20 11:22 ` Yann E. MORIN
@ 2011-10-20 12:48 ` Arnout Vandecappelle
2011-10-20 19:45 ` Yann E. MORIN
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2011-10-20 12:48 UTC (permalink / raw)
To: buildroot
On Thursday 20 October 2011 13:22:13, Yann E. MORIN wrote:
> > LSOF_EXTRACT_CMDS = \
> > $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
> > $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
> > $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -)
>
> That would not work, because the first $(TAR) will extract actual files
> to the disk, and does not send the extracted files to the stdio, so the
> second $(TAR) will get nothing on its stdin (at best), or only get
> garbage (at worst).
Oh, is -O not a universally accepted tar option?
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE)
2011-10-20 12:48 ` Arnout Vandecappelle
@ 2011-10-20 19:45 ` Yann E. MORIN
0 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2011-10-20 19:45 UTC (permalink / raw)
To: buildroot
Arnout, All,
On Thursday 20 October 2011 14:48:52 Arnout Vandecappelle wrote:
> On Thursday 20 October 2011 13:22:13, Yann E. MORIN wrote:
> > > LSOF_EXTRACT_CMDS = \
> > > $(INFLATE.bz2) $(DL_DIR)/$(LSOF_SOURCE) | \
> > > $(TAR) -O $(TAR_OPTIONS) - lsof_$(LSOF_VERSION)/lsof_$(LSOF_VERSION)_src.tar | \
> > > $(TAR) $(TAR_STRIP_COMPONENTS)=1 -C $(LSOF_DIR) $(TAR_OPTIONS) -)
> >
> > That would not work, because the first $(TAR) will extract actual files
> > to the disk, and does not send the extracted files to the stdio, so the
> > second $(TAR) will get nothing on its stdin (at best), or only get
> > garbage (at worst).
>
> Oh, is -O not a universally accepted tar option?
Ah. Sigh... I missed that '-O' option... My bad.
You're right, that would work.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-20 19:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-19 20:55 [Buildroot] [PATCH] -lsof was unable to patch Makefile.skel due to bad file permissions. Adding chmod solves it. (openSUSE) Damian Kaczmarek
2011-10-19 21:27 ` Yann E. MORIN
2011-10-19 22:46 ` Arnout Vandecappelle
2011-10-20 11:22 ` Yann E. MORIN
2011-10-20 12:48 ` Arnout Vandecappelle
2011-10-20 19:45 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox