From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 5 RFC] dependencies: check core dependencies before anything else
Date: Tue, 15 Nov 2011 22:43:45 +0000 [thread overview]
Message-ID: <201111152243.45470.arnout@mind.be> (raw)
In-Reply-To: <268352ac0f111e4fdf72.1320911666@devws108>
On Thursday 10 November 2011 19:31:51 Thomas De Schampheleire wrote:
> Currently, the dependencies target (that runs dependencies.sh) depends on
> DEPENDENCIES_HOST_PREREQ. This means that the dependencies listed in
> DEPENDENCIES_HOST_PREREQ (currently host-sstrip if sstrip is selected) are
> built *before* the dependencies.sh script is run.
>
> As a result, if e.g. there is no gcc compiler present on the build system,
> the dependencies in DEPENDENCIES_HOST_PREREQ will fail to build, and
> buildroot will fail non-gracefully.
>
> This patch makes sure that the DEPENDENCIES_HOST_PREREQ are checked *after*
> the dependencies.sh script, so that any problem in the build system is
> reported in a clean way by dependencies.sh.
>
> Signed-off-by: Thomas De Schampheleire <thomas.de.schampheleire@gmail.com>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> ---
> toolchain/dependencies/dependencies.mk | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/toolchain/dependencies/dependencies.mk
> b/toolchain/dependencies/dependencies.mk ---
> a/toolchain/dependencies/dependencies.mk
> +++ b/toolchain/dependencies/dependencies.mk
> @@ -16,12 +16,14 @@ DL_TOOLS = \
> $(findstring git,$(DL_TOOLS_DEPENDENCIES)) \
> $(findstring bzr,$(DL_TOOLS_DEPENDENCIES))
>
> -dependencies: $(DEPENDENCIES_HOST_PREREQ)
> +core-dependencies:
> @HOSTCC="$(firstword $(HOSTCC))" MAKE="$(MAKE)" \
> CONFIG_FILE="$(CONFIG_DIR)/.config" \
> DL_TOOLS="$(DL_TOOLS)" \
> $(TOPDIR)/toolchain/dependencies/dependencies.sh
>
> +dependencies: core-dependencies $(DEPENDENCIES_HOST_PREREQ)
> +
> dependencies-source:
>
> dependencies-clean:
> @@ -35,5 +37,5 @@ dependencies-dirclean:
> # Toplevel Makefile options
> #
> #############################################################
> -.PHONY: dependencies
> +.PHONY: dependencies core-dependencies
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
next prev parent reply other threads:[~2011-11-15 22:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 19:31 [Buildroot] [PATCH 0 of 5 RFC] dependencies: some improvements Thomas De Schampheleire
2011-11-10 19:31 ` [Buildroot] [PATCH 1 of 5 RFC] dependencies: check core dependencies before anything else Thomas De Schampheleire
2011-11-15 22:43 ` Arnout Vandecappelle [this message]
2011-11-17 22:20 ` Peter Korsgaard
2011-11-10 19:31 ` [Buildroot] [PATCH 2 of 5 RFC] dependencies: add function suitable-host-package Thomas De Schampheleire
2011-11-15 23:22 ` Arnout Vandecappelle
2011-11-10 19:31 ` [Buildroot] [PATCH 3 of 5 RFC] dependencies: build a host-tar if no suitable tar can be found Thomas De Schampheleire
2011-11-15 23:31 ` Arnout Vandecappelle
2011-11-10 19:32 ` [Buildroot] [PATCH 4 of 5 RFC] dependencies: remove unused lzma checking scripts Thomas De Schampheleire
2011-11-15 22:57 ` Arnout Vandecappelle
2011-11-17 22:20 ` Peter Korsgaard
2011-11-10 19:32 ` [Buildroot] [PATCH 5 of 5 RFC] dirs and dependencies should be executed before every package Thomas De Schampheleire
2011-11-15 23:52 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111152243.45470.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox