From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5 of 5 RFC] dirs and dependencies should be executed before every package
Date: Tue, 15 Nov 2011 23:52:54 +0000 [thread overview]
Message-ID: <201111152352.54229.arnout@mind.be> (raw)
In-Reply-To: <229371fcaeaf9f44e4e4.1320911670@devws108>
On Thursday 10 November 2011 19:32:02 Thomas De Schampheleire wrote:
[snip]
> To solve both problems, this patch changes the gentargets 'foo-source' target
> to explicitly depend on 'dirs' and 'dependencies'. This way, every package
> built with gentargets/autotargets/cmake will be built after dirs and
> dependencies.
>
> But, certain problems remain:
> * When a dependency package is not using gentargets.
packets not using gentargets are deprecated. AFAICS there are only 14 left:
cups/cups.mk
customize/customize.mk
fis/fis.mk
games/doom-wad/doom-wads.mk
gettext/gettext.mk
java/concierge/concierge.mk
microperl/microperl.mk
netkitbase/netkitbase.mk
netkittelnet/netkittelnet.mk
newt/newt.mk
tinyhttpd/tinyhttpd.mk
ttcp/ttcp.mk
uemacs/uemacs.mk
vpnc/vpnc.mk
xfsprogs/xfsprogs.mk
The only worrysome one is gettext.
> * In some cases, this patch introduces a circular make dependency, because e.g.
> dependencies <-- host-tar
> <any package> <-- dirs dependencies
This is of course much more important.
For dirs it certainly isn't a problem.
For the dependencies, I'm actually thinking that a much better solution
would be to add a dependencies step at the first build, that checks for all
potentially needed host packages. It creates a hostpackages.mk file that
contains variable assignments for all potential dependencies. Specifying
a rule for hostpackages.mk in the top-level Makefile will make sure that it is
generated if it doesn't exist. This has the advantage that dependencies
have to be checked only at the first build and not every single time. But
it is a lot more work to implement of course...
Regards,
Arnout
--
Arnout Vandecappelle arnout@mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 31BB CF53 8660 6F88 345D 54CC A836 5879 20D7 CF43
prev parent reply other threads:[~2011-11-15 23:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-10 19:31 [Buildroot] [PATCH 0 of 5 RFC] dependencies: some improvements Thomas De Schampheleire
2011-11-10 19:31 ` [Buildroot] [PATCH 1 of 5 RFC] dependencies: check core dependencies before anything else Thomas De Schampheleire
2011-11-15 22:43 ` Arnout Vandecappelle
2011-11-17 22:20 ` Peter Korsgaard
2011-11-10 19:31 ` [Buildroot] [PATCH 2 of 5 RFC] dependencies: add function suitable-host-package Thomas De Schampheleire
2011-11-15 23:22 ` Arnout Vandecappelle
2011-11-10 19:31 ` [Buildroot] [PATCH 3 of 5 RFC] dependencies: build a host-tar if no suitable tar can be found Thomas De Schampheleire
2011-11-15 23:31 ` Arnout Vandecappelle
2011-11-10 19:32 ` [Buildroot] [PATCH 4 of 5 RFC] dependencies: remove unused lzma checking scripts Thomas De Schampheleire
2011-11-15 22:57 ` Arnout Vandecappelle
2011-11-17 22:20 ` Peter Korsgaard
2011-11-10 19:32 ` [Buildroot] [PATCH 5 of 5 RFC] dirs and dependencies should be executed before every package Thomas De Schampheleire
2011-11-15 23:52 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111152352.54229.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox