* [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices
@ 2011-12-09 12:39 Sagaert Johan
2011-12-09 14:31 ` Luca Ceresoli
2011-12-09 18:40 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: Sagaert Johan @ 2011-12-09 12:39 UTC (permalink / raw)
To: buildroot
Signed-off-by: Sagaert Johan <sagaert.johan@skynet.be>
---
package/Config.in | 1 +
package/libmbus/Config.in | 7 +++++++
package/libmbus/libmbus.mk | 12 ++++++++++++
3 files changed, 20 insertions(+), 0 deletions(-)
create mode 100644 package/libmbus/Config.in
create mode 100644 package/libmbus/libmbus.mk
diff --git a/package/Config.in b/package/Config.in
index e949649..8f0b5ba 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
source "package/neon/Config.in"
source "package/libmnl/Config.in"
source "package/libmodbus/Config.in"
+source "package/libmbus/Config.in"
source "package/libnl/Config.in"
source "package/libpcap/Config.in"
source "package/libosip2/Config.in"
diff --git a/package/libmbus/Config.in b/package/libmbus/Config.in
new file mode 100644
index 0000000..93666ed
--- /dev/null
+++ b/package/libmbus/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_LIBMBUS
+ bool "libmbus"
+ help
+ libmbus is a library for communicating with energie metering devices
+ supports TCP and RS232 M-bus gateways.
+
+ http://www.freescada.com/libmbus
diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
new file mode 100644
index 0000000..a57595e
--- /dev/null
+++ b/package/libmbus/libmbus.mk
@@ -0,0 +1,12 @@
+#############################################################
+#
+# libmbus
+#
+#############################################################
+LIBMBUS_VERSION:=0.6.1
+LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
+LIBMBUS_SITE:=http://www.freescada.com/public-dist/
+LIBMBUS_INSTALL_STAGING=YES
+LIBMBUS_AUTORECONF=YES
+
+$(eval $(call AUTOTARGETS))
--
1.7.8-rc3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices
2011-12-09 12:39 [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices Sagaert Johan
@ 2011-12-09 14:31 ` Luca Ceresoli
2011-12-09 14:45 ` Sagaert Johan
2011-12-09 18:40 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Luca Ceresoli @ 2011-12-09 14:31 UTC (permalink / raw)
To: buildroot
Sagaert Johan wrote:
>
> Signed-off-by: Sagaert Johan<sagaert.johan@skynet.be>
> ---
> package/Config.in | 1 +
> package/libmbus/Config.in | 7 +++++++
> package/libmbus/libmbus.mk | 12 ++++++++++++
> 3 files changed, 20 insertions(+), 0 deletions(-)
> create mode 100644 package/libmbus/Config.in
> create mode 100644 package/libmbus/libmbus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e949649..8f0b5ba 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
> source "package/neon/Config.in"
> source "package/libmnl/Config.in"
> source "package/libmodbus/Config.in"
> +source "package/libmbus/Config.in"
> source "package/libnl/Config.in"
> source "package/libpcap/Config.in"
> source "package/libosip2/Config.in"
> diff --git a/package/libmbus/Config.in b/package/libmbus/Config.in
> new file mode 100644
> index 0000000..93666ed
> --- /dev/null
> +++ b/package/libmbus/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBMBUS
> + bool "libmbus"
> + help
> + libmbus is a library for communicating with energie metering devices
> + supports TCP and RS232 M-bus gateways.
s/energie/energy/
I'd also reword this way:
libmbus is a library for communicating with energy metering devices.
It supports TCP and RS232 M-bus gateways.
> +
> + http://www.freescada.com/libmbus
> diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
> new file mode 100644
> index 0000000..a57595e
> --- /dev/null
> +++ b/package/libmbus/libmbus.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# libmbus
> +#
> +#############################################################
> +LIBMBUS_VERSION:=0.6.1
> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
This should be removed, as it's equal to Buildroot's default.
Search
for LIBFOO_SOURCE in the docs and you'll read:
If none are specified, then the value is assumed to be
packagename-$(LIBFOO_VERSION).tar.gz
> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/
> +LIBMBUS_INSTALL_STAGING=YES
> +LIBMBUS_AUTORECONF=YES
Why is this line needed? The downloaded tarball already contains a
configure script. If there's a specific reason that is not obvious,
then you should add a line of comment.
Luca
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices
2011-12-09 14:31 ` Luca Ceresoli
@ 2011-12-09 14:45 ` Sagaert Johan
0 siblings, 0 replies; 4+ messages in thread
From: Sagaert Johan @ 2011-12-09 14:45 UTC (permalink / raw)
To: buildroot
Hi
LIBMBUS_AUTORECONF=YES is needed because without it the build yields an
error : 'test/Makefile.in' not found .
-----Oorspronkelijk bericht-----
Van: Luca Ceresoli [mailto:luca at lucaceresoli.net]
Verzonden: vrijdag 9 december 2011 15:32
Aan: Sagaert Johan
CC: buildroot at busybox.net
Onderwerp: Re: [Buildroot] [PATCH] Add new package libmbus Library for
communicating with energy metering devices
Sagaert Johan wrote:
>
> Signed-off-by: Sagaert Johan<sagaert.johan@skynet.be>
> ---
> package/Config.in | 1 +
> package/libmbus/Config.in | 7 +++++++
> package/libmbus/libmbus.mk | 12 ++++++++++++
> 3 files changed, 20 insertions(+), 0 deletions(-)
> create mode 100644 package/libmbus/Config.in
> create mode 100644 package/libmbus/libmbus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index e949649..8f0b5ba 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -330,6 +330,7 @@ source "package/libmicrohttpd/Config.in"
> source "package/neon/Config.in"
> source "package/libmnl/Config.in"
> source "package/libmodbus/Config.in"
> +source "package/libmbus/Config.in"
> source "package/libnl/Config.in"
> source "package/libpcap/Config.in"
> source "package/libosip2/Config.in"
> diff --git a/package/libmbus/Config.in b/package/libmbus/Config.in
> new file mode 100644
> index 0000000..93666ed
> --- /dev/null
> +++ b/package/libmbus/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_LIBMBUS
> + bool "libmbus"
> + help
> + libmbus is a library for communicating with energie metering
devices
> + supports TCP and RS232 M-bus gateways.
s/energie/energy/
I'd also reword this way:
libmbus is a library for communicating with energy metering devices.
It supports TCP and RS232 M-bus gateways.
> +
> + http://www.freescada.com/libmbus
> diff --git a/package/libmbus/libmbus.mk b/package/libmbus/libmbus.mk
> new file mode 100644
> index 0000000..a57595e
> --- /dev/null
> +++ b/package/libmbus/libmbus.mk
> @@ -0,0 +1,12 @@
> +#############################################################
> +#
> +# libmbus
> +#
> +#############################################################
> +LIBMBUS_VERSION:=0.6.1
> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
This should be removed, as it's equal to Buildroot's default.
Search
for LIBFOO_SOURCE in the docs and you'll read:
If none are specified, then the value is assumed to be
packagename-$(LIBFOO_VERSION).tar.gz
> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/
> +LIBMBUS_INSTALL_STAGING=YES
> +LIBMBUS_AUTORECONF=YES
Why is this line needed? The downloaded tarball already contains a
configure script. If there's a specific reason that is not obvious,
then you should add a line of comment.
Luca
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices
2011-12-09 12:39 [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices Sagaert Johan
2011-12-09 14:31 ` Luca Ceresoli
@ 2011-12-09 18:40 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2011-12-09 18:40 UTC (permalink / raw)
To: buildroot
Le Fri, 9 Dec 2011 13:39:36 +0100,
Sagaert Johan <sagaert.johan@skynet.be> a ?crit :
> +LIBMBUS_VERSION:=0.6.1
> +LIBMBUS_SOURCE:=libmbus-$(LIBMBUS_VERSION).tar.gz
> +LIBMBUS_SITE:=http://www.freescada.com/public-dist/
'=' signs should be used instead of ':=' signs.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-12-09 18:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-09 12:39 [Buildroot] [PATCH] Add new package libmbus Library for communicating with energy metering devices Sagaert Johan
2011-12-09 14:31 ` Luca Ceresoli
2011-12-09 14:45 ` Sagaert Johan
2011-12-09 18:40 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox