Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] lpc32xx: Add CDL to the available bootloaders
Date: Wed, 4 Jan 2012 13:39:03 +0100	[thread overview]
Message-ID: <20120104133903.6a7edf69@skate> (raw)
In-Reply-To: <1325675997.2442.25.camel@emblysd024.adetel.com>

Le Wed, 04 Jan 2012 12:19:57 +0100,
Alexandre Belloni <abelloni@adeneo-embedded.com> a ?crit :

> It won't compile without it because the files are duplicate, the linker
> will complain about symbols being defined twice. I definitely tried to
> keep the patch as small as possible.

Ok.

> Th fact is that they are already duplicated in the original source. Is
> it worth patching the makefiles to unify those ?
> 
> Upstream is trying to unify everything. I hope t will be done at some
> point in time.

Ok. Then I'm fine with those.

> Will be done but $(MAKE) won't work as it isn't possible to compile
> using multiple jobs. Is it worth fixing the makefiles for a so small
> piece of code ?

Then specify:

LPC32XXCDL_MAKE = $(MAKE1)

And Buildroot will use make -j1 to build this package specifically. See
package/at/at.mk for an example.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-01-04 12:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-03 18:49 [Buildroot] [PATCH 0/2] V2: Add defconfigs for LPC3250 boards Alexandre Belloni
2012-01-03 18:49 ` [Buildroot] [PATCH 1/2] lpc32xx: Add CDL to the available bootloaders Alexandre Belloni
2012-01-03 20:08   ` Thomas Petazzoni
2012-01-04 11:19     ` Alexandre Belloni
2012-01-04 12:39       ` Thomas Petazzoni [this message]
2012-01-03 18:49 ` [Buildroot] [PATCH 2/2] Add defconfigs for LPC3250 boards Alexandre Belloni
2012-01-03 20:09 ` [Buildroot] [PATCH 0/2] V2: " Thomas Petazzoni
2012-01-04 11:12   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120104133903.6a7edf69@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox