* [Buildroot] [PATCH 1/7] libeina: Add new package along with EFL infrastructure.
@ 2012-01-18 11:15 Will Newton
2012-01-21 0:44 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2012-01-18 11:15 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
---
package/Config.in | 2 ++
package/efl/Config.in | 16 ++++++++++++++++
package/efl/efl.mk | 3 +++
package/efl/libeina/Config.in | 4 ++++
package/efl/libeina/libeina.mk | 18 ++++++++++++++++++
5 files changed, 43 insertions(+), 0 deletions(-)
create mode 100644 package/efl/Config.in
create mode 100644 package/efl/efl.mk
create mode 100644 package/efl/libeina/Config.in
create mode 100644 package/efl/libeina/libeina.mk
diff --git a/package/Config.in b/package/Config.in
index 2e91427..e86b80e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -121,6 +121,8 @@ comment "other GUIs"
source "package/qt/Config.in"
source "package/x11r7/Config.in"
+source "package/efl/Config.in"
+
comment "X libraries and helper libraries"
source "package/liberation/Config.in"
source "package/libsexy/Config.in"
diff --git a/package/efl/Config.in b/package/efl/Config.in
new file mode 100644
index 0000000..cc677cb
--- /dev/null
+++ b/package/efl/Config.in
@@ -0,0 +1,16 @@
+menuconfig BR2_PACKAGE_EFL
+ bool "Enlightenment Foundation Libraries"
+ depends on BR2_USE_WCHAR
+ help
+ Enlightenment Foundation Libraries
+
+ http://enlightenment.org
+
+if BR2_PACKAGE_EFL
+
+source "package/efl/libeina/Config.in"
+
+endif # BR2_PACKAGE_EFL
+
+comment "EFL requires WCHAR support in toolchain"
+ depends on !BR2_USE_WCHAR
diff --git a/package/efl/efl.mk b/package/efl/efl.mk
new file mode 100644
index 0000000..1f9f43a
--- /dev/null
+++ b/package/efl/efl.mk
@@ -0,0 +1,3 @@
+ifeq ($(BR2_PACKAGE_EFL),y)
+include package/efl/*/*.mk
+endif
diff --git a/package/efl/libeina/Config.in b/package/efl/libeina/Config.in
new file mode 100644
index 0000000..b937b3b
--- /dev/null
+++ b/package/efl/libeina/Config.in
@@ -0,0 +1,4 @@
+config BR2_PACKAGE_LIBEINA
+ bool "libeina"
+ help
+ Eina is a tiny library to handle data types (list, hash, etc.)
diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
new file mode 100644
index 0000000..879a878
--- /dev/null
+++ b/package/efl/libeina/libeina.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# libeina
+#
+#############################################################
+
+LIBEINA_VERSION = 1.1.0
+LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
+LIBEINA_SITE = http://download.enlightenment.org/releases/
+LIBEINA_AUTORECONF = YES
+LIBEINA_LIBTOOL_PATCH = YES
+LIBEINA_INSTALL_STAGING = YES
+LIBEINA_INSTALL_TARGET = YES
+
+LIBEINA_DEPENDENCIES = host-pkg-config
+
+$(eval $(call AUTOTARGETS))
+
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/7] libeina: Add new package along with EFL infrastructure.
2012-01-18 11:15 [Buildroot] [PATCH 1/7] libeina: Add new package along with EFL infrastructure Will Newton
@ 2012-01-21 0:44 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2012-01-21 0:44 UTC (permalink / raw)
To: buildroot
On Wednesday 18 January 2012 12:15:20 Will Newton wrote:
> Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Nit-picking: the short commit message shouldn't end with a .
> ---
> package/Config.in | 2 ++
> package/efl/Config.in | 16 ++++++++++++++++
> package/efl/efl.mk | 3 +++
> package/efl/libeina/Config.in | 4 ++++
> package/efl/libeina/libeina.mk | 18 ++++++++++++++++++
> 5 files changed, 43 insertions(+), 0 deletions(-)
> create mode 100644 package/efl/Config.in
> create mode 100644 package/efl/efl.mk
> create mode 100644 package/efl/libeina/Config.in
> create mode 100644 package/efl/libeina/libeina.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 2e91427..e86b80e 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -121,6 +121,8 @@ comment "other GUIs"
> source "package/qt/Config.in"
> source "package/x11r7/Config.in"
>
> +source "package/efl/Config.in"
> +
Should come before qt (to keep alphabetic order) and the empty line
is redundant.
> comment "X libraries and helper libraries"
> source "package/liberation/Config.in"
> source "package/libsexy/Config.in"
> diff --git a/package/efl/Config.in b/package/efl/Config.in
> new file mode 100644
> index 0000000..cc677cb
> --- /dev/null
> +++ b/package/efl/Config.in
> @@ -0,0 +1,16 @@
> +menuconfig BR2_PACKAGE_EFL
> + bool "Enlightenment Foundation Libraries"
> + depends on BR2_USE_WCHAR
> + help
> + Enlightenment Foundation Libraries
> +
> + http://enlightenment.org
> +
> +if BR2_PACKAGE_EFL
> +
> +source "package/efl/libeina/Config.in"
> +
> +endif # BR2_PACKAGE_EFL
> +
> +comment "EFL requires WCHAR support in toolchain"
> + depends on !BR2_USE_WCHAR
> diff --git a/package/efl/efl.mk b/package/efl/efl.mk
> new file mode 100644
> index 0000000..1f9f43a
> --- /dev/null
> +++ b/package/efl/efl.mk
> @@ -0,0 +1,3 @@
> +ifeq ($(BR2_PACKAGE_EFL),y)
Personally I'm not in favour of this kind of conditional inclusion of .mk
files. It removes the possibility to do a quick 'make libeina'. And unlike
x11r7, EFL does not add 260 packages to the overhead is affordable.
> +include package/efl/*/*.mk
> +endif
> diff --git a/package/efl/libeina/Config.in b/package/efl/libeina/Config.in
> new file mode 100644
> index 0000000..b937b3b
> --- /dev/null
> +++ b/package/efl/libeina/Config.in
> @@ -0,0 +1,4 @@
> +config BR2_PACKAGE_LIBEINA
> + bool "libeina"
> + help
> + Eina is a tiny library to handle data types (list, hash, etc.)
> diff --git a/package/efl/libeina/libeina.mk b/package/efl/libeina/libeina.mk
> new file mode 100644
> index 0000000..879a878
> --- /dev/null
> +++ b/package/efl/libeina/libeina.mk
> @@ -0,0 +1,18 @@
> +#############################################################
> +#
> +# libeina
> +#
> +#############################################################
> +
> +LIBEINA_VERSION = 1.1.0
> +LIBEINA_SOURCE = eina-$(LIBEINA_VERSION).tar.bz2
> +LIBEINA_SITE = http://download.enlightenment.org/releases/
> +LIBEINA_AUTORECONF = YES
> +LIBEINA_LIBTOOL_PATCH = YES
YES is default for _LIBTOOL_PATCH, so drop that.
> +LIBEINA_INSTALL_STAGING = YES
> +LIBEINA_INSTALL_TARGET = YES
YES is default for _INSTALL_TARGET, so drop that.
> +
> +LIBEINA_DEPENDENCIES = host-pkg-config
> +
> +$(eval $(call AUTOTARGETS))
> +
Nit-picking: redundant empty line.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-21 0:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 11:15 [Buildroot] [PATCH 1/7] libeina: Add new package along with EFL infrastructure Will Newton
2012-01-21 0:44 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox