* [Buildroot] [PATCH 4/7] libecore: Add new package.
@ 2012-01-18 11:17 Will Newton
2012-01-21 1:44 ` Arnout Vandecappelle
0 siblings, 1 reply; 2+ messages in thread
From: Will Newton @ 2012-01-18 11:17 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
---
package/efl/Config.in | 1 +
package/efl/libecore/Config.in | 81 +++++++++++++++++++++++++
package/efl/libecore/libecore.mk | 124 ++++++++++++++++++++++++++++++++++++++
3 files changed, 206 insertions(+), 0 deletions(-)
create mode 100644 package/efl/libecore/Config.in
create mode 100644 package/efl/libecore/libecore.mk
diff --git a/package/efl/Config.in b/package/efl/Config.in
index 27d1f95..3007783 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -9,6 +9,7 @@ menuconfig BR2_PACKAGE_EFL
if BR2_PACKAGE_EFL
source "package/efl/libeina/Config.in"
+source "package/efl/libecore/Config.in"
source "package/efl/libeet/Config.in"
source "package/efl/libevas/Config.in"
diff --git a/package/efl/libecore/Config.in b/package/efl/libecore/Config.in
new file mode 100644
index 0000000..fd4da93
--- /dev/null
+++ b/package/efl/libecore/Config.in
@@ -0,0 +1,81 @@
+config BR2_PACKAGE_LIBECORE
+ bool "libecore"
+ select BR2_PACKAGE_LIBEINA
+ help
+ Ecore is the event/X abstraction layer that makes doing
+ selections, Xdnd, general X stuff, event loops, timeouts and
+ idle handlers fast, optimized, and convenient.
+
+if BR2_PACKAGE_LIBECORE
+
+config BR2_PACKAGE_LIBECORE_DIRECTFB
+ bool "libecore directfb support"
+ depends on BR2_PACKAGE_DIRECTFB
+
+config BR2_PACKAGE_LIBECORE_FB
+ bool "libecore framebuffer support"
+
+config BR2_PACKAGE_LIBECORE_SDL
+ bool "libecore sdl support"
+ depends on BR2_PACKAGE_SDL
+
+config BR2_PACKAGE_LIBECORE_X
+ bool "libecore x support"
+ depends on BR2_PACKAGE_X11R7
+
+config BR2_PACKAGE_LIBECORE_EVAS
+ bool "libecore evas support"
+ select BR2_PACKAGE_EVAS
+
+if BR2_PACKAGE_LIBECORE_EVAS
+
+config BR2_PACKAGE_LIBECORE_EVAS_BUFFER
+ bool "libecore evas software buffer support"
+ select BR2_PACKAGE_LIBEVAS
+
+config BR2_PACKAGE_LIBECORE_EVAS_X11
+ bool "libecore evas x11 support"
+ depends on BR2_PACKAGE_X11R7
+
+config BR2_PACKAGE_LIBECORE_EVAS_X11_16
+ bool "libecore evas x11 16bits support"
+ depends on BR2_PACKAGE_X11R7
+
+config BR2_PACKAGE_LIBECORE_EVAS_XRENDER_X11
+ bool "libecore evas xrender x11 support"
+ depends on BR2_PACKAGE_X11R7
+ select BR2_PACKAGE_XLIB_LIBXRENDER
+
+config BR2_PACKAGE_LIBECORE_EVAS_XCB
+ bool "libecore evas xcb support"
+ depends on BR2_PACKAGE_X11R7
+ select BR2_PACKAGE_XCB_PROTO
+
+config BR2_PACKAGE_LIBECORE_EVAS_XRENDER_XCB
+ bool "libecore evas xrender xcb support"
+ depends on BR2_PACKAGE_X11R7
+ select BR2_PACKAGE_XCB_PROTO
+ select BR2_PACKAGE_XLIB_LIBXRENDER
+
+config BR2_PACKAGE_LIBECORE_EVAS_OPENGL_X11
+ bool "libecore evas opengl x11 support"
+ depends on BR2_PACKAGE_X11R7
+
+config BR2_PACKAGE_LIBECORE_EVAS_OPENGL_GLEW
+ bool "libecore evas opengl glew support"
+
+config BR2_PACKAGE_LIBECORE_EVAS_SDL
+ bool "libecore evas sdl support"
+ select BR2_PACKAGE_SDL
+
+config BR2_PACKAGE_LIBECORE_EVAS_DIRECTFB
+ bool "libecore evas directfb support"
+ select BR2_PACKAGE_DIRECTFB
+
+config BR2_PACKAGE_LIBECORE_EVAS_FB
+ bool "libecore evas frame buffer support"
+ select BR2_PACKAGE_LIBEVAS
+
+endif # BR2_PACKAGE_LIBECORE_EVAS
+
+endif # BR2_PACKAGE_LIBECORE
diff --git a/package/efl/libecore/libecore.mk b/package/efl/libecore/libecore.mk
new file mode 100644
index 0000000..acd7fa3
--- /dev/null
+++ b/package/efl/libecore/libecore.mk
@@ -0,0 +1,124 @@
+#############################################################
+#
+# libecore
+#
+#############################################################
+
+LIBECORE_VERSION = 1.1.0
+LIBECORE_SOURCE = ecore-$(LIBECORE_VERSION).tar.bz2
+LIBECORE_SITE = http://download.enlightenment.org/releases/
+LIBECORE_INSTALL_STAGING = YES
+LIBECORE_INSTALL_TARGET = YES
+
+LIBECORE_DEPENDENCIES = host-pkg-config libeina
+
+# default options
+LIBECORE_CONF_OPT = --disable-simple-x11
+
+# libecore
+ifeq ($(BR2_PACKAGE_LIBECORE_DIRECTFB),y)
+LIBECORE_CONF_OPT += --enable-ecore-directfb
+else
+LIBECORE_CONF_OPT += --disable-ecore-directfb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_FB),y)
+LIBECORE_CONF_OPT += --enable-ecore-fb
+else
+LIBECORE_CONF_OPT += --disable-ecore-fb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_SDL),y)
+LIBECORE_CONF_OPT += --enable-ecore-sdl
+else
+LIBECORE_CONF_OPT += --disable-ecore-sdl
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_X),y)
+LIBECORE_CONF_OPT += --enable-ecore-x
+else
+LIBECORE_CONF_OPT += --disable-ecore-x
+endif
+
+# libecore-evas
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas
+LIBECORE_DEPENDENCIES += libevas
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_BUFFER),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-software-buffer
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-software-buffer
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_X11),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-software-x11
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-software-x11
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_X11_16),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-software-16-x11
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-software-16-x11
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_XRENDER_X11),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-xrender-x11
+LIBECORE_DEPENDENCIES += xlib_libXrender
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-xrender-x11
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_XCB),y)
+#LIBECORE_CONF_OPT += --enable-ecore-evas-software-xcb
+LIBECORE_CONF_OPT += --enable-ecore-x-xcb
+LIBECORE_DEPENDENCIES += xcb-proto
+else
+#LIBECORE_CONF_OPT += --disable-ecore-evas-software-xcb
+LIBECORE_CONF_OPT += --disable-ecore-x-xcb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_XRENDER_XCB),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-xrender-xcb
+LIBECORE_DEPENDENCIES += xcb-proto xlib_libXrender
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-xrender-xcb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_OPENGL_X11),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-opengl-x11
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-opengl-x11
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_OPENGL_GLEW),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-opengl-glew
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-opengl-glew
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_SDL),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-software-sdl
+LIBECORE_DEPENDENCIES += sdl
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-software-sdl
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_DIRECTFB),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-directfb
+LIBECORE_DEPENDENCIES += directfb
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-directfb
+endif
+
+ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_FB),y)
+LIBECORE_CONF_OPT += --enable-ecore-evas-fb
+else
+LIBECORE_CONF_OPT += --disable-ecore-evas-fb
+endif
+
+$(eval $(call AUTOTARGETS))
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 4/7] libecore: Add new package.
2012-01-18 11:17 [Buildroot] [PATCH 4/7] libecore: Add new package Will Newton
@ 2012-01-21 1:44 ` Arnout Vandecappelle
0 siblings, 0 replies; 2+ messages in thread
From: Arnout Vandecappelle @ 2012-01-21 1:44 UTC (permalink / raw)
To: buildroot
On Wednesday 18 January 2012 12:17:30 Will Newton wrote:
> Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[snip]
> diff --git a/package/efl/libecore/Config.in b/package/efl/libecore/Config.in
> new file mode 100644
> index 0000000..fd4da93
> --- /dev/null
> +++ b/package/efl/libecore/Config.in
> @@ -0,0 +1,81 @@
> +config BR2_PACKAGE_LIBECORE
> + bool "libecore"
> + select BR2_PACKAGE_LIBEINA
> + help
> + Ecore is the event/X abstraction layer that makes doing
> + selections, Xdnd, general X stuff, event loops, timeouts and
> + idle handlers fast, optimized, and convenient.
> +
> +if BR2_PACKAGE_LIBECORE
> +
> +config BR2_PACKAGE_LIBECORE_DIRECTFB
> + bool "libecore directfb support"
> + depends on BR2_PACKAGE_DIRECTFB
You could add a 'default y' (which will only apply if directfb is
selected). But I'm not sure if that's a good idea.
> +
> +config BR2_PACKAGE_LIBECORE_FB
> + bool "libecore framebuffer support"
Don't add default y here!
> +
> +config BR2_PACKAGE_LIBECORE_SDL
> + bool "libecore sdl support"
> + depends on BR2_PACKAGE_SDL
> +
> +config BR2_PACKAGE_LIBECORE_X
> + bool "libecore x support"
> + depends on BR2_PACKAGE_X11R7
> +
> +config BR2_PACKAGE_LIBECORE_EVAS
> + bool "libecore evas support"
> + select BR2_PACKAGE_EVAS
> +
> +if BR2_PACKAGE_LIBECORE_EVAS
> +
> +config BR2_PACKAGE_LIBECORE_EVAS_BUFFER
> + bool "libecore evas software buffer support"
> + select BR2_PACKAGE_LIBEVAS
Redundant select: already selected by LIBECORE_EVAS. But you probably
meant 'select BR2_PACKAGE_LIBEVAS_BUFFER', in which case you should add
the dependency on BR2_PACKAGE_XORG7. Or maybe it should depend on
BR2_PACKAGE_LIBECORE_X?
> +config BR2_PACKAGE_LIBECORE_EVAS_X11
> + bool "libecore evas x11 support"
> + depends on BR2_PACKAGE_X11R7
BR2_PACKAGE_X11R7 doesn't exist...
Since there's a big group of similar dependencies here, I would wrap them
in an 'if BR2_PACKAGE_XORG7' instead of adding individual 'depends on'.
This probably misses a select BR2_PACKAGE_LIBEVAS_X11. And more like that
in the following options.
I wonder though... Won't the libecore configure script find out automatically
which evas backends are supported, and enable just those? Then it's sufficient
to select the backends in libevas.
[snip]
> diff --git a/package/efl/libecore/libecore.mk b/package/efl/libecore/libecore.mk
> new file mode 100644
> index 0000000..acd7fa3
> --- /dev/null
> +++ b/package/efl/libecore/libecore.mk
> @@ -0,0 +1,124 @@
> +#############################################################
> +#
> +# libecore
> +#
> +#############################################################
> +
> +LIBECORE_VERSION = 1.1.0
> +LIBECORE_SOURCE = ecore-$(LIBECORE_VERSION).tar.bz2
> +LIBECORE_SITE = http://download.enlightenment.org/releases/
> +LIBECORE_INSTALL_STAGING = YES
> +LIBECORE_INSTALL_TARGET = YES
_INSTALL_TARGET already defaults to YES.
[snip]
> +ifeq ($(BR2_PACKAGE_LIBECORE_EVAS_XCB),y)
> +#LIBECORE_CONF_OPT += --enable-ecore-evas-software-xcb
> +LIBECORE_CONF_OPT += --enable-ecore-x-xcb
> +LIBECORE_DEPENDENCIES += xcb-proto
> +else
> +#LIBECORE_CONF_OPT += --disable-ecore-evas-software-xcb
> +LIBECORE_CONF_OPT += --disable-ecore-x-xcb
> +endif
Don't leave those commented-out lines in the patch. Or if there is a good
reason for it, add a FIXME comment to explain it.
[snip]
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-21 1:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-18 11:17 [Buildroot] [PATCH 4/7] libecore: Add new package Will Newton
2012-01-21 1:44 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox