From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 14/14] libedbus: Add new package
Date: Fri, 27 Jan 2012 00:40:09 +0100 [thread overview]
Message-ID: <201201270040.09862.arnout@mind.be> (raw)
In-Reply-To: <CAFbHwiTmVeZYM_OBKzzNLkdvbr30RG06wi8FxFzbhVhP9KcTbw@mail.gmail.com>
On Tuesday 24 January 2012 11:32:50 Will Newton wrote:
> On Mon, Jan 23, 2012 at 10:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> > On Monday 23 January 2012 17:36:27 Will Newton wrote:
> >> Signed-off-by: Will Newton <will.newton@imgtec.com>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >
> > [snip]
> >> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> >> new file mode 100644
> >> index 0000000..71e3b50
> >> --- /dev/null
> >> +++ b/package/efl/libedbus/Config.in
> >> @@ -0,0 +1,8 @@
> >> +config BR2_PACKAGE_LIBEDBUS
> >> + bool "libedbus"
> >> + select BR2_PACKAGE_LIBEINA
> >> + select BR2_PACKAGE_DBUS
> > DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
> > so you have to repeat that here.
>
> Hmm, would it be better just to add a comment asking the user to
> enable dbus rather than adding the select for the XML library? I'm not
> sure what the best way to handle that is.
dbus itself has depends on, not select. So either you take that over
(and libedbus is not available unless one of the two XML packages is
selected). Alternatively, you can use depends on BR2_PACKAGE_DBUS
instead of a select. Or ideally, you add a choice for the XML library
to DBUS itself, so that the dependency is removed completely. Patch
follows.
> > BTW, it's advisable to compile-test your patches against a minimal
> > uclibc-based 32-bit and 64-bit cross-toolchain. That helps detecting
> > dependencies on USE_WCHAR and USE_LARGEFILE.
>
> There is a top-level dependency on WCHAR for all of EFL, I'll test
> with LARGEFILE enabled too.
Oops my bad.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2012-01-26 23:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 16:36 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle [this message]
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
2012-01-31 11:39 ` Arnout Vandecappelle
2012-01-31 13:01 ` Peter Korsgaard
2012-02-01 17:09 ` [Buildroot] [PATCH] dbus: deprecate libxml2 support Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-29 22:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201270040.09862.arnout@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox