* [Buildroot] [PATCH 14/14] libedbus: Add new package
@ 2012-01-23 16:36 Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
0 siblings, 1 reply; 16+ messages in thread
From: Will Newton @ 2012-01-23 16:36 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
---
package/efl/Config.in | 1 +
package/efl/libedbus/Config.in | 8 ++++++++
package/efl/libedbus/libedbus.mk | 16 ++++++++++++++++
3 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 package/efl/libedbus/Config.in
create mode 100644 package/efl/libedbus/libedbus.mk
diff --git a/package/efl/Config.in b/package/efl/Config.in
index ec8c513..c783d7f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -18,6 +18,7 @@ source "package/efl/libembryo/Config.in"
source "package/efl/libedje/Config.in"
source "package/efl/libethumb/Config.in"
source "package/efl/libelementary/Config.in"
+source "package/efl/libedbus/Config.in"
endif # BR2_PACKAGE_EFL
diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
new file mode 100644
index 0000000..71e3b50
--- /dev/null
+++ b/package/efl/libedbus/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBEDBUS
+ bool "libedbus"
+ select BR2_PACKAGE_LIBEINA
+ select BR2_PACKAGE_DBUS
+ help
+ E_Dbus is a set of wrappers around DBus APIs by third party, so
+ they can be easily used by EFL applications, automatically
+ providing Ecore/main loop integration, as well as Eina data types.
diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
new file mode 100644
index 0000000..e2ac836
--- /dev/null
+++ b/package/efl/libedbus/libedbus.mk
@@ -0,0 +1,16 @@
+#############################################################
+#
+# libedbus
+#
+#############################################################
+
+LIBEDBUS_VERSION = 1.1.0
+LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
+LIBEDBUS_SITE = http://download.enlightenment.org/releases/
+LIBEDBUS_AUTORECONF = YES
+LIBEDBUS_LIBTOOL_PATCH = YES
+LIBEDBUS_INSTALL_STAGING = YES
+
+LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina
+
+$(eval $(call AUTOTARGETS))
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-23 16:36 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
@ 2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32 ` Will Newton
0 siblings, 1 reply; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-23 22:51 UTC (permalink / raw)
To: buildroot
On Monday 23 January 2012 17:36:27 Will Newton wrote:
> Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[snip]
> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> new file mode 100644
> index 0000000..71e3b50
> --- /dev/null
> +++ b/package/efl/libedbus/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBEDBUS
> + bool "libedbus"
> + select BR2_PACKAGE_LIBEINA
> + select BR2_PACKAGE_DBUS
DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
so you have to repeat that here.
BTW, it's advisable to compile-test your patches against a minimal
uclibc-based 32-bit and 64-bit cross-toolchain. That helps detecting
dependencies on USE_WCHAR and USE_LARGEFILE.
> + help
> + E_Dbus is a set of wrappers around DBus APIs by third party, so
I believe the official name is D-Bus.
> + they can be easily used by EFL applications, automatically
> + providing Ecore/main loop integration, as well as Eina data types.
> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
> new file mode 100644
> index 0000000..e2ac836
> --- /dev/null
> +++ b/package/efl/libedbus/libedbus.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# libedbus
> +#
> +#############################################################
> +
> +LIBEDBUS_VERSION = 1.1.0
> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
> +LIBEDBUS_AUTORECONF = YES
> +LIBEDBUS_LIBTOOL_PATCH = YES
Libtool patching is enabled by default.
> +LIBEDBUS_INSTALL_STAGING = YES
> +
> +LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina
> +
> +$(eval $(call AUTOTARGETS))
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-23 22:51 ` Arnout Vandecappelle
@ 2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
0 siblings, 2 replies; 16+ messages in thread
From: Will Newton @ 2012-01-24 10:32 UTC (permalink / raw)
To: buildroot
On Mon, Jan 23, 2012 at 10:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On Monday 23 January 2012 17:36:27 Will Newton wrote:
>> Signed-off-by: Will Newton <will.newton@imgtec.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> [snip]
>> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
>> new file mode 100644
>> index 0000000..71e3b50
>> --- /dev/null
>> +++ b/package/efl/libedbus/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_LIBEDBUS
>> + ? ? bool "libedbus"
>> + ? ? select BR2_PACKAGE_LIBEINA
>> + ? ? select BR2_PACKAGE_DBUS
> ?DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
> so you have to repeat that here.
Hmm, would it be better just to add a comment asking the user to
enable dbus rather than adding the select for the XML library? I'm not
sure what the best way to handle that is.
> ?BTW, it's advisable to compile-test your patches against a minimal
> uclibc-based 32-bit and 64-bit cross-toolchain. ?That helps detecting
> dependencies on USE_WCHAR and USE_LARGEFILE.
There is a top-level dependency on WCHAR for all of EFL, I'll test
with LARGEFILE enabled too.
>> + ? ? help
>> + ? ? ? E_Dbus is a set of wrappers around DBus APIs by third party, so
> ?I believe the official name is D-Bus.
>
>> + ? ? ? they can be easily used by EFL applications, automatically
>> + ? ? ? providing Ecore/main loop integration, as well as Eina data types.
>> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
>> new file mode 100644
>> index 0000000..e2ac836
>> --- /dev/null
>> +++ b/package/efl/libedbus/libedbus.mk
>> @@ -0,0 +1,16 @@
>> +#############################################################
>> +#
>> +# libedbus
>> +#
>> +#############################################################
>> +
>> +LIBEDBUS_VERSION = 1.1.0
>> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
>> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
>> +LIBEDBUS_AUTORECONF = YES
>> +LIBEDBUS_LIBTOOL_PATCH = YES
> ?Libtool patching is enabled by default.
Thanks for the review, I'll fix these.
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-24 10:32 ` Will Newton
@ 2012-01-26 23:40 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
1 sibling, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:40 UTC (permalink / raw)
To: buildroot
On Tuesday 24 January 2012 11:32:50 Will Newton wrote:
> On Mon, Jan 23, 2012 at 10:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> > On Monday 23 January 2012 17:36:27 Will Newton wrote:
> >> Signed-off-by: Will Newton <will.newton@imgtec.com>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >
> > [snip]
> >> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> >> new file mode 100644
> >> index 0000000..71e3b50
> >> --- /dev/null
> >> +++ b/package/efl/libedbus/Config.in
> >> @@ -0,0 +1,8 @@
> >> +config BR2_PACKAGE_LIBEDBUS
> >> + bool "libedbus"
> >> + select BR2_PACKAGE_LIBEINA
> >> + select BR2_PACKAGE_DBUS
> > DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
> > so you have to repeat that here.
>
> Hmm, would it be better just to add a comment asking the user to
> enable dbus rather than adding the select for the XML library? I'm not
> sure what the best way to handle that is.
dbus itself has depends on, not select. So either you take that over
(and libedbus is not available unless one of the two XML packages is
selected). Alternatively, you can use depends on BR2_PACKAGE_DBUS
instead of a select. Or ideally, you add a choice for the XML library
to DBUS itself, so that the dependency is removed completely. Patch
follows.
> > BTW, it's advisable to compile-test your patches against a minimal
> > uclibc-based 32-bit and 64-bit cross-toolchain. That helps detecting
> > dependencies on USE_WCHAR and USE_LARGEFILE.
>
> There is a top-level dependency on WCHAR for all of EFL, I'll test
> with LARGEFILE enabled too.
Oops my bad.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
` (5 more replies)
1 sibling, 6 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
D-Bus requires an XML library, expat or libxml2. There already is a choice
between them in the config menu, but it requires the user to first select
one of the libraries, and then select dbus. With this patch, the choice
automatically selects the XML library. Note that this removes the
automatic choice of libxml2 for dbus if libxml2 had already been selected,
i.e. in that case both libxml2 and expat will be selected unless the user
takes action.
An alternative would be to remove the choice completely, and to take the
path of bluez-utils: select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_DBUS_LIBXML2
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/dbus/Config.in | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/package/dbus/Config.in b/package/dbus/Config.in
index c625382..54a8540 100644
--- a/package/dbus/Config.in
+++ b/package/dbus/Config.in
@@ -1,18 +1,13 @@
config BR2_PACKAGE_DBUS
bool "dbus"
- depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
help
The D-Bus message bus system.
http://www.freedesktop.org/wiki/Software/dbus
-comment "dbus not available (need expat or libxml2)"
- depends on !BR2_PACKAGE_EXPAT && !BR2_PACKAGE_LIBXML2
-
choice
prompt "XML library to use"
depends on BR2_PACKAGE_DBUS
- default BR2_DBUS_LIBXML2 if (BR2_PACKAGE_LIBXML2 && !BR2_PACKAGE_EXPAT)
default BR2_DBUS_EXPAT
help
Select the XML library to use with D-Bus. Select Expat
@@ -21,10 +16,10 @@ choice
config BR2_DBUS_EXPAT
bool "Expat"
- depends on BR2_PACKAGE_EXPAT
+ select BR2_PACKAGE_EXPAT
config BR2_DBUS_LIBXML2
bool "libxml2"
- depends on BR2_PACKAGE_LIBXML2
+ select BR2_PACKAGE_LIBXML2
endchoice
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
` (4 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
expat/libxml2 is selected by dbus.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/bluez_utils/Config.in | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/package/bluez_utils/Config.in b/package/bluez_utils/Config.in
index ea6b44c..3517407 100644
--- a/package/bluez_utils/Config.in
+++ b/package/bluez_utils/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_BLUEZ_UTILS
bool "bluez-utils"
depends on BR2_USE_WCHAR # libglib2
select BR2_PACKAGE_DBUS
- select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_DBUS_LIBXML2
select BR2_PACKAGE_LIBGLIB2
help
bluez utils
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
` (3 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/samba/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/samba/Config.in b/package/samba/Config.in
index 3a77776..a5a5c29 100644
--- a/package/samba/Config.in
+++ b/package/samba/Config.in
@@ -249,12 +249,12 @@ config BR2_PACKAGE_SAMBA_AVAHI
default y
depends on BR2_PACKAGE_SAMBA
depends on BR2_PACKAGE_AVAHI_DAEMON
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
help
Include support for avahi
-comment "support avahi - disabled (requires avahi-daemon/dbus)"
- depends on !BR2_PACKAGE_AVAHI_DAEMON || !BR2_PACKAGE_DBUS
+comment "support avahi - disabled (requires avahi-daemon)"
+ depends on !BR2_PACKAGE_AVAHI_DAEMON
config BR2_PACKAGE_SAMBA_GAMIN
bool "support gamin"
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 4/6] qt: qt-dbus: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
` (2 subsequent siblings)
5 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/qt/Config.in | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/package/qt/Config.in b/package/qt/Config.in
index ab231d9..3a552d0 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -280,12 +280,9 @@ config BR2_PACKAGE_QT_PHONON_BACKEND
If unsure, say n.
endif
-comment "Qt Dbus module not available (needs dbus)"
- depends on !BR2_PACKAGE_DBUS
-
config BR2_PACKAGE_QT_DBUS
bool "DBus Module"
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
help
Build the Qt DBus module.
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 5/6] network-manager: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (2 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
5 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/network-manager/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
index 6e51f53..9708a11 100644
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -1,7 +1,7 @@
config BR2_PACKAGE_NETWORK_MANAGER
bool "NetworkManager"
depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
depends on BR2_INET_IPV6
depends on BR2_LARGEFILE # acl
depends on BR2_USE_WCHAR # libglib2
@@ -25,6 +25,6 @@ config BR2_PACKAGE_NETWORK_MANAGER
http://projects.gnome.org/NetworkManager/
-comment "NetworkManager requires DBus and a toolchain with IPV6, LARGEFILE and WCHAR support"
- depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || !BR2_PACKAGE_DBUS
+comment "NetworkManager requires a toolchain with IPV6, LARGEFILE and WCHAR support"
+ depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 6/6] connman: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (3 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
5 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/connman/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/connman/Config.in b/package/connman/Config.in
index 237c30e..2801b87 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -1,6 +1,6 @@
config BR2_PACKAGE_CONNMAN
bool "connman"
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
select BR2_PACKAGE_LIBGLIB2
select BR2_PACKAGE_IPTABLES
depends on BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc
@@ -43,5 +43,5 @@ config BR2_PACKAGE_CONNMAN_CLIENT
endif # BR2_PACKAGE_CONNMAN
-comment "connman needs DBus enabled and a toolchain with resolver support"
- depends on !BR2_PACKAGE_DBUS || !(BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc)
+comment "connman needs a toolchain with resolver support"
+ depends on !(BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc)
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (4 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
@ 2012-01-31 11:26 ` Peter Korsgaard
2012-01-31 11:39 ` Arnout Vandecappelle
5 siblings, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2012-01-31 11:26 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Arnout> D-Bus requires an XML library, expat or libxml2. There already
Arnout> is a choice between them in the config menu, but it requires
Arnout> the user to first select one of the libraries, and then select
Arnout> dbus. With this patch, the choice automatically selects the
Arnout> XML library. Note that this removes the automatic choice of
Arnout> libxml2 for dbus if libxml2 had already been selected, i.e. in
Arnout> that case both libxml2 and expat will be selected unless the
Arnout> user takes action.
Committed entire series, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 16+ messages in thread* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
@ 2012-01-31 11:39 ` Arnout Vandecappelle
2012-01-31 13:01 ` Peter Korsgaard
0 siblings, 1 reply; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-01-31 11:39 UTC (permalink / raw)
To: buildroot
On Tuesday 31 January 2012 12:26:40 Peter Korsgaard wrote:
> >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
>
> Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> Arnout> D-Bus requires an XML library, expat or libxml2. There already
> Arnout> is a choice between them in the config menu, but it requires
> Arnout> the user to first select one of the libraries, and then select
> Arnout> dbus. With this patch, the choice automatically selects the
> Arnout> XML library. Note that this removes the automatic choice of
> Arnout> libxml2 for dbus if libxml2 had already been selected, i.e. in
> Arnout> that case both libxml2 and expat will be selected unless the
> Arnout> user takes action.
>
> Committed entire series, thanks.
What does everybody think of the alternative (which Peter snipped here):
An alternative would be to remove the choice completely, and to take the
path of bluez-utils: select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_DBUS_LIBXML2
Advantage: no redundant expat library if the user has selected libxml2
Disadvantage: what happens when the user has selected both libxml2 and
expat? (My answer: dbus will use libxml2)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-31 11:39 ` Arnout Vandecappelle
@ 2012-01-31 13:01 ` Peter Korsgaard
2012-02-01 17:09 ` [Buildroot] [PATCH] dbus: deprecate libxml2 support Arnout Vandecappelle
0 siblings, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2012-01-31 13:01 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
Arnout> What does everybody think of the alternative (which Peter
Arnout> snipped here):
Arnout> An alternative would be to remove the choice completely, and
Arnout> to take the path of bluez-utils: select BR2_PACKAGE_EXPAT if
Arnout> !BR2_PACKAGE_DBUS_LIBXML2
Arnout> Advantage: no redundant expat library if the user has selected
Arnout> libxml2
Arnout> Disadvantage: what happens when the user has selected both
Arnout> libxml2 and expat? (My answer: dbus will use libxml2)
Or alternatively drop the libxml2 option. It's deprecated upstream and
not commonly used:
https://bugs.freedesktop.org/show_bug.cgi?id=20253
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH] dbus: deprecate libxml2 support
2012-01-31 13:01 ` Peter Korsgaard
@ 2012-02-01 17:09 ` Arnout Vandecappelle
0 siblings, 0 replies; 16+ messages in thread
From: Arnout Vandecappelle @ 2012-02-01 17:09 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/dbus/Config.in | 23 +++++++++++++++++------
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/package/dbus/Config.in b/package/dbus/Config.in
index 54a8540..850753d 100644
--- a/package/dbus/Config.in
+++ b/package/dbus/Config.in
@@ -1,25 +1,36 @@
config BR2_PACKAGE_DBUS
bool "dbus"
+ select BR2_DBUS_EXPAT if !BR2_DEPRECATED
help
The D-Bus message bus system.
http://www.freedesktop.org/wiki/Software/dbus
+config BR2_DBUS_EXPAT
+ bool
+ select BR2_PACKAGE_EXPAT
+
+if BR2_DEPRECATED
choice
prompt "XML library to use"
depends on BR2_PACKAGE_DBUS
- default BR2_DBUS_EXPAT
+ default BR2_DBUS_CHOICE_EXPAT
help
Select the XML library to use with D-Bus. Select Expat
unless you have specific reasons for using libxml2 as
Expat is significant smaller.
- config BR2_DBUS_EXPAT
+ config BR2_DBUS_CHOICE_EXPAT
bool "Expat"
- select BR2_PACKAGE_EXPAT
+ select BR2_DBUS_EXPAT
- config BR2_DBUS_LIBXML2
+ config BR2_DBUS_CHOICE_LIBXML2
bool "libxml2"
- select BR2_PACKAGE_LIBXML2
-
+ select BR2_DBUS_LIBXML2
endchoice
+
+config BR2_DBUS_LIBXML2
+ bool
+ select BR2_PACKAGE_LIBXML2
+
+endif
--
1.7.8.3
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
@ 2012-01-26 17:42 Will Newton
2012-01-29 22:22 ` Peter Korsgaard
0 siblings, 1 reply; 16+ messages in thread
From: Will Newton @ 2012-01-26 17:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/efl/Config.in | 1 +
package/efl/libedbus/Config.in | 10 ++++++++++
package/efl/libedbus/libedbus.mk | 15 +++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/efl/libedbus/Config.in
create mode 100644 package/efl/libedbus/libedbus.mk
diff --git a/package/efl/Config.in b/package/efl/Config.in
index ec8c513..c783d7f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -18,6 +18,7 @@ source "package/efl/libembryo/Config.in"
source "package/efl/libedje/Config.in"
source "package/efl/libethumb/Config.in"
source "package/efl/libelementary/Config.in"
+source "package/efl/libedbus/Config.in"
endif # BR2_PACKAGE_EFL
diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
new file mode 100644
index 0000000..27993f0
--- /dev/null
+++ b/package/efl/libedbus/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBEDBUS
+ bool "libedbus"
+ select BR2_PACKAGE_LIBEINA
+ select BR2_PACKAGE_LIBECORE
+ select BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_LIBXML2
+ help
+ E_Dbus is a set of wrappers around D-Bus APIs so they can be
+ easily used by EFL applications, automatically providing
+ Ecore/main loop integration, as well as Eina data types.
diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
new file mode 100644
index 0000000..fe883e0
--- /dev/null
+++ b/package/efl/libedbus/libedbus.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# libedbus
+#
+#############################################################
+
+LIBEDBUS_VERSION = 1.1.0
+LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
+LIBEDBUS_SITE = http://download.enlightenment.org/releases/
+LIBEDBUS_AUTORECONF = YES
+LIBEDBUS_INSTALL_STAGING = YES
+
+LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina libecore
+
+$(eval $(call AUTOTARGETS))
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
@ 2012-01-29 22:22 ` Peter Korsgaard
0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2012-01-29 22:22 UTC (permalink / raw)
To: buildroot
>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:
Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed with minor tweaks, thanks.
Will> new file mode 100644
Will> index 0000000..27993f0
Will> --- /dev/null
Will> +++ b/package/efl/libedbus/Config.in
Will> @@ -0,0 +1,10 @@
Will> +config BR2_PACKAGE_LIBEDBUS
Will> + bool "libedbus"
Will> + select BR2_PACKAGE_LIBEINA
Will> + select BR2_PACKAGE_LIBECORE
Will> + select BR2_PACKAGE_DBUS
Will> + select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_LIBXML2
I prefer to just do depends on BR2_PACKAGE_DBUS (atleast until Arnout's
patches are merged).
Will> + help
Will> + E_Dbus is a set of wrappers around D-Bus APIs so they can be
Will> + easily used by EFL applications, automatically providing
Will> + Ecore/main loop integration, as well as Eina data types.
You forgot upstream URL.
Will> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
Will> new file mode 100644
Will> index 0000000..fe883e0
Will> --- /dev/null
Will> +++ b/package/efl/libedbus/libedbus.mk
Will> @@ -0,0 +1,15 @@
Will> +#############################################################
Will> +#
Will> +# libedbus
Will> +#
Will> +#############################################################
Will> +
Will> +LIBEDBUS_VERSION = 1.1.0
Will> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
Will> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
Will> +LIBEDBUS_AUTORECONF = YES
You are not patching any autotools files, so no need for AUTORECONF.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2012-02-01 17:09 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-23 16:36 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
2012-01-31 11:39 ` Arnout Vandecappelle
2012-01-31 13:01 ` Peter Korsgaard
2012-02-01 17:09 ` [Buildroot] [PATCH] dbus: deprecate libxml2 support Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-29 22:22 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox