* [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
` (4 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
expat/libxml2 is selected by dbus.
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/bluez_utils/Config.in | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/package/bluez_utils/Config.in b/package/bluez_utils/Config.in
index ea6b44c..3517407 100644
--- a/package/bluez_utils/Config.in
+++ b/package/bluez_utils/Config.in
@@ -2,7 +2,6 @@ config BR2_PACKAGE_BLUEZ_UTILS
bool "bluez-utils"
depends on BR2_USE_WCHAR # libglib2
select BR2_PACKAGE_DBUS
- select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_DBUS_LIBXML2
select BR2_PACKAGE_LIBGLIB2
help
bluez utils
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
` (3 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/samba/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/samba/Config.in b/package/samba/Config.in
index 3a77776..a5a5c29 100644
--- a/package/samba/Config.in
+++ b/package/samba/Config.in
@@ -249,12 +249,12 @@ config BR2_PACKAGE_SAMBA_AVAHI
default y
depends on BR2_PACKAGE_SAMBA
depends on BR2_PACKAGE_AVAHI_DAEMON
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
help
Include support for avahi
-comment "support avahi - disabled (requires avahi-daemon/dbus)"
- depends on !BR2_PACKAGE_AVAHI_DAEMON || !BR2_PACKAGE_DBUS
+comment "support avahi - disabled (requires avahi-daemon)"
+ depends on !BR2_PACKAGE_AVAHI_DAEMON
config BR2_PACKAGE_SAMBA_GAMIN
bool "support gamin"
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 4/6] qt: qt-dbus: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 2/6] bluez_utils: remove redundant selection of expat Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 3/6] samba: avahi: replace dependency on dbus by select Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
` (2 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/qt/Config.in | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/package/qt/Config.in b/package/qt/Config.in
index ab231d9..3a552d0 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -280,12 +280,9 @@ config BR2_PACKAGE_QT_PHONON_BACKEND
If unsure, say n.
endif
-comment "Qt Dbus module not available (needs dbus)"
- depends on !BR2_PACKAGE_DBUS
-
config BR2_PACKAGE_QT_DBUS
bool "DBus Module"
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
help
Build the Qt DBus module.
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 5/6] network-manager: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (2 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 4/6] qt: qt-dbus: " Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
5 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/network-manager/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/network-manager/Config.in b/package/network-manager/Config.in
index 6e51f53..9708a11 100644
--- a/package/network-manager/Config.in
+++ b/package/network-manager/Config.in
@@ -1,7 +1,7 @@
config BR2_PACKAGE_NETWORK_MANAGER
bool "NetworkManager"
depends on BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_UDEV
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
depends on BR2_INET_IPV6
depends on BR2_LARGEFILE # acl
depends on BR2_USE_WCHAR # libglib2
@@ -25,6 +25,6 @@ config BR2_PACKAGE_NETWORK_MANAGER
http://projects.gnome.org/NetworkManager/
-comment "NetworkManager requires DBus and a toolchain with IPV6, LARGEFILE and WCHAR support"
- depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR || !BR2_PACKAGE_DBUS
+comment "NetworkManager requires a toolchain with IPV6, LARGEFILE and WCHAR support"
+ depends on !BR2_INET_IPV6 || !BR2_LARGEFILE || !BR2_USE_WCHAR
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 6/6] connman: replace dependency on dbus by select
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (3 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 5/6] network-manager: " Arnout Vandecappelle
@ 2012-01-26 23:41 ` Arnout Vandecappelle
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
5 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:41 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/connman/Config.in | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/package/connman/Config.in b/package/connman/Config.in
index 237c30e..2801b87 100644
--- a/package/connman/Config.in
+++ b/package/connman/Config.in
@@ -1,6 +1,6 @@
config BR2_PACKAGE_CONNMAN
bool "connman"
- depends on BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_DBUS
select BR2_PACKAGE_LIBGLIB2
select BR2_PACKAGE_IPTABLES
depends on BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc
@@ -43,5 +43,5 @@ config BR2_PACKAGE_CONNMAN_CLIENT
endif # BR2_PACKAGE_CONNMAN
-comment "connman needs DBus enabled and a toolchain with resolver support"
- depends on !BR2_PACKAGE_DBUS || !(BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc)
+comment "connman needs a toolchain with resolver support"
+ depends on !(BR2_UCLIBC_VERSION_SNAPSHOT || BR2_TOOLCHAIN_EXTERNAL_GLIBC || BR2_TOOLCHAIN_CTNG_eglibc || BR2_TOOLCHAIN_CTNG_eglibc)
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-26 23:41 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Arnout Vandecappelle
` (4 preceding siblings ...)
2012-01-26 23:41 ` [Buildroot] [PATCH 6/6] connman: " Arnout Vandecappelle
@ 2012-01-31 11:26 ` Peter Korsgaard
2012-01-31 11:39 ` Arnout Vandecappelle
5 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2012-01-31 11:26 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Arnout> D-Bus requires an XML library, expat or libxml2. There already
Arnout> is a choice between them in the config menu, but it requires
Arnout> the user to first select one of the libraries, and then select
Arnout> dbus. With this patch, the choice automatically selects the
Arnout> XML library. Note that this removes the automatic choice of
Arnout> libxml2 for dbus if libxml2 had already been selected, i.e. in
Arnout> that case both libxml2 and expat will be selected unless the
Arnout> user takes action.
Committed entire series, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-31 11:26 ` [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on) Peter Korsgaard
@ 2012-01-31 11:39 ` Arnout Vandecappelle
2012-01-31 13:01 ` Peter Korsgaard
0 siblings, 1 reply; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-01-31 11:39 UTC (permalink / raw)
To: buildroot
On Tuesday 31 January 2012 12:26:40 Peter Korsgaard wrote:
> >>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
>
> Arnout> From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
>
> Arnout> D-Bus requires an XML library, expat or libxml2. There already
> Arnout> is a choice between them in the config menu, but it requires
> Arnout> the user to first select one of the libraries, and then select
> Arnout> dbus. With this patch, the choice automatically selects the
> Arnout> XML library. Note that this removes the automatic choice of
> Arnout> libxml2 for dbus if libxml2 had already been selected, i.e. in
> Arnout> that case both libxml2 and expat will be selected unless the
> Arnout> user takes action.
>
> Committed entire series, thanks.
What does everybody think of the alternative (which Peter snipped here):
An alternative would be to remove the choice completely, and to take the
path of bluez-utils: select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_DBUS_LIBXML2
Advantage: no redundant expat library if the user has selected libxml2
Disadvantage: what happens when the user has selected both libxml2 and
expat? (My answer: dbus will use libxml2)
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH 1/6] dbus: make it easier to select an XML library (select rather than depends on)
2012-01-31 11:39 ` Arnout Vandecappelle
@ 2012-01-31 13:01 ` Peter Korsgaard
2012-02-01 17:09 ` [Buildroot] [PATCH] dbus: deprecate libxml2 support Arnout Vandecappelle
0 siblings, 1 reply; 14+ messages in thread
From: Peter Korsgaard @ 2012-01-31 13:01 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:
Hi,
Arnout> What does everybody think of the alternative (which Peter
Arnout> snipped here):
Arnout> An alternative would be to remove the choice completely, and
Arnout> to take the path of bluez-utils: select BR2_PACKAGE_EXPAT if
Arnout> !BR2_PACKAGE_DBUS_LIBXML2
Arnout> Advantage: no redundant expat library if the user has selected
Arnout> libxml2
Arnout> Disadvantage: what happens when the user has selected both
Arnout> libxml2 and expat? (My answer: dbus will use libxml2)
Or alternatively drop the libxml2 option. It's deprecated upstream and
not commonly used:
https://bugs.freedesktop.org/show_bug.cgi?id=20253
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Buildroot] [PATCH] dbus: deprecate libxml2 support
2012-01-31 13:01 ` Peter Korsgaard
@ 2012-02-01 17:09 ` Arnout Vandecappelle
0 siblings, 0 replies; 14+ messages in thread
From: Arnout Vandecappelle @ 2012-02-01 17:09 UTC (permalink / raw)
To: buildroot
From: "Arnout Vandecappelle (Essensium/Mind)" <arnout@mind.be>
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/dbus/Config.in | 23 +++++++++++++++++------
1 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/package/dbus/Config.in b/package/dbus/Config.in
index 54a8540..850753d 100644
--- a/package/dbus/Config.in
+++ b/package/dbus/Config.in
@@ -1,25 +1,36 @@
config BR2_PACKAGE_DBUS
bool "dbus"
+ select BR2_DBUS_EXPAT if !BR2_DEPRECATED
help
The D-Bus message bus system.
http://www.freedesktop.org/wiki/Software/dbus
+config BR2_DBUS_EXPAT
+ bool
+ select BR2_PACKAGE_EXPAT
+
+if BR2_DEPRECATED
choice
prompt "XML library to use"
depends on BR2_PACKAGE_DBUS
- default BR2_DBUS_EXPAT
+ default BR2_DBUS_CHOICE_EXPAT
help
Select the XML library to use with D-Bus. Select Expat
unless you have specific reasons for using libxml2 as
Expat is significant smaller.
- config BR2_DBUS_EXPAT
+ config BR2_DBUS_CHOICE_EXPAT
bool "Expat"
- select BR2_PACKAGE_EXPAT
+ select BR2_DBUS_EXPAT
- config BR2_DBUS_LIBXML2
+ config BR2_DBUS_CHOICE_LIBXML2
bool "libxml2"
- select BR2_PACKAGE_LIBXML2
-
+ select BR2_DBUS_LIBXML2
endchoice
+
+config BR2_DBUS_LIBXML2
+ bool
+ select BR2_PACKAGE_LIBXML2
+
+endif
--
1.7.8.3
^ permalink raw reply related [flat|nested] 14+ messages in thread