* [Buildroot] [PATCH 14/14] libedbus: Add new package
@ 2012-01-26 17:42 Will Newton
2012-01-29 22:22 ` Peter Korsgaard
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2012-01-26 17:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
package/efl/Config.in | 1 +
package/efl/libedbus/Config.in | 10 ++++++++++
package/efl/libedbus/libedbus.mk | 15 +++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/efl/libedbus/Config.in
create mode 100644 package/efl/libedbus/libedbus.mk
diff --git a/package/efl/Config.in b/package/efl/Config.in
index ec8c513..c783d7f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -18,6 +18,7 @@ source "package/efl/libembryo/Config.in"
source "package/efl/libedje/Config.in"
source "package/efl/libethumb/Config.in"
source "package/efl/libelementary/Config.in"
+source "package/efl/libedbus/Config.in"
endif # BR2_PACKAGE_EFL
diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
new file mode 100644
index 0000000..27993f0
--- /dev/null
+++ b/package/efl/libedbus/Config.in
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_LIBEDBUS
+ bool "libedbus"
+ select BR2_PACKAGE_LIBEINA
+ select BR2_PACKAGE_LIBECORE
+ select BR2_PACKAGE_DBUS
+ select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_LIBXML2
+ help
+ E_Dbus is a set of wrappers around D-Bus APIs so they can be
+ easily used by EFL applications, automatically providing
+ Ecore/main loop integration, as well as Eina data types.
diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
new file mode 100644
index 0000000..fe883e0
--- /dev/null
+++ b/package/efl/libedbus/libedbus.mk
@@ -0,0 +1,15 @@
+#############################################################
+#
+# libedbus
+#
+#############################################################
+
+LIBEDBUS_VERSION = 1.1.0
+LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
+LIBEDBUS_SITE = http://download.enlightenment.org/releases/
+LIBEDBUS_AUTORECONF = YES
+LIBEDBUS_INSTALL_STAGING = YES
+
+LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina libecore
+
+$(eval $(call AUTOTARGETS))
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
@ 2012-01-29 22:22 ` Peter Korsgaard
0 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2012-01-29 22:22 UTC (permalink / raw)
To: buildroot
>>>>> "Will" == Will Newton <will.newton@gmail.com> writes:
Will> Signed-off-by: Will Newton <will.newton@imgtec.com>
Will> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed with minor tweaks, thanks.
Will> new file mode 100644
Will> index 0000000..27993f0
Will> --- /dev/null
Will> +++ b/package/efl/libedbus/Config.in
Will> @@ -0,0 +1,10 @@
Will> +config BR2_PACKAGE_LIBEDBUS
Will> + bool "libedbus"
Will> + select BR2_PACKAGE_LIBEINA
Will> + select BR2_PACKAGE_LIBECORE
Will> + select BR2_PACKAGE_DBUS
Will> + select BR2_PACKAGE_EXPAT if !BR2_PACKAGE_LIBXML2
I prefer to just do depends on BR2_PACKAGE_DBUS (atleast until Arnout's
patches are merged).
Will> + help
Will> + E_Dbus is a set of wrappers around D-Bus APIs so they can be
Will> + easily used by EFL applications, automatically providing
Will> + Ecore/main loop integration, as well as Eina data types.
You forgot upstream URL.
Will> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
Will> new file mode 100644
Will> index 0000000..fe883e0
Will> --- /dev/null
Will> +++ b/package/efl/libedbus/libedbus.mk
Will> @@ -0,0 +1,15 @@
Will> +#############################################################
Will> +#
Will> +# libedbus
Will> +#
Will> +#############################################################
Will> +
Will> +LIBEDBUS_VERSION = 1.1.0
Will> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
Will> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
Will> +LIBEDBUS_AUTORECONF = YES
You are not patching any autotools files, so no need for AUTORECONF.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
@ 2012-01-23 16:36 Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2012-01-23 16:36 UTC (permalink / raw)
To: buildroot
Signed-off-by: Will Newton <will.newton@imgtec.com>
---
package/efl/Config.in | 1 +
package/efl/libedbus/Config.in | 8 ++++++++
package/efl/libedbus/libedbus.mk | 16 ++++++++++++++++
3 files changed, 25 insertions(+), 0 deletions(-)
create mode 100644 package/efl/libedbus/Config.in
create mode 100644 package/efl/libedbus/libedbus.mk
diff --git a/package/efl/Config.in b/package/efl/Config.in
index ec8c513..c783d7f 100644
--- a/package/efl/Config.in
+++ b/package/efl/Config.in
@@ -18,6 +18,7 @@ source "package/efl/libembryo/Config.in"
source "package/efl/libedje/Config.in"
source "package/efl/libethumb/Config.in"
source "package/efl/libelementary/Config.in"
+source "package/efl/libedbus/Config.in"
endif # BR2_PACKAGE_EFL
diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
new file mode 100644
index 0000000..71e3b50
--- /dev/null
+++ b/package/efl/libedbus/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_LIBEDBUS
+ bool "libedbus"
+ select BR2_PACKAGE_LIBEINA
+ select BR2_PACKAGE_DBUS
+ help
+ E_Dbus is a set of wrappers around DBus APIs by third party, so
+ they can be easily used by EFL applications, automatically
+ providing Ecore/main loop integration, as well as Eina data types.
diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
new file mode 100644
index 0000000..e2ac836
--- /dev/null
+++ b/package/efl/libedbus/libedbus.mk
@@ -0,0 +1,16 @@
+#############################################################
+#
+# libedbus
+#
+#############################################################
+
+LIBEDBUS_VERSION = 1.1.0
+LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
+LIBEDBUS_SITE = http://download.enlightenment.org/releases/
+LIBEDBUS_AUTORECONF = YES
+LIBEDBUS_LIBTOOL_PATCH = YES
+LIBEDBUS_INSTALL_STAGING = YES
+
+LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina
+
+$(eval $(call AUTOTARGETS))
--
1.7.1
-------------- next part --------------
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-23 16:36 Will Newton
@ 2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32 ` Will Newton
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-01-23 22:51 UTC (permalink / raw)
To: buildroot
On Monday 23 January 2012 17:36:27 Will Newton wrote:
> Signed-off-by: Will Newton <will.newton@imgtec.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
[snip]
> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> new file mode 100644
> index 0000000..71e3b50
> --- /dev/null
> +++ b/package/efl/libedbus/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_LIBEDBUS
> + bool "libedbus"
> + select BR2_PACKAGE_LIBEINA
> + select BR2_PACKAGE_DBUS
DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
so you have to repeat that here.
BTW, it's advisable to compile-test your patches against a minimal
uclibc-based 32-bit and 64-bit cross-toolchain. That helps detecting
dependencies on USE_WCHAR and USE_LARGEFILE.
> + help
> + E_Dbus is a set of wrappers around DBus APIs by third party, so
I believe the official name is D-Bus.
> + they can be easily used by EFL applications, automatically
> + providing Ecore/main loop integration, as well as Eina data types.
> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
> new file mode 100644
> index 0000000..e2ac836
> --- /dev/null
> +++ b/package/efl/libedbus/libedbus.mk
> @@ -0,0 +1,16 @@
> +#############################################################
> +#
> +# libedbus
> +#
> +#############################################################
> +
> +LIBEDBUS_VERSION = 1.1.0
> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
> +LIBEDBUS_AUTORECONF = YES
> +LIBEDBUS_LIBTOOL_PATCH = YES
Libtool patching is enabled by default.
> +LIBEDBUS_INSTALL_STAGING = YES
> +
> +LIBEDBUS_DEPENDENCIES = host-pkg-config dbus libeina
> +
> +$(eval $(call AUTOTARGETS))
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-23 22:51 ` Arnout Vandecappelle
@ 2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2012-01-24 10:32 UTC (permalink / raw)
To: buildroot
On Mon, Jan 23, 2012 at 10:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> On Monday 23 January 2012 17:36:27 Will Newton wrote:
>> Signed-off-by: Will Newton <will.newton@imgtec.com>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> [snip]
>> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
>> new file mode 100644
>> index 0000000..71e3b50
>> --- /dev/null
>> +++ b/package/efl/libedbus/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_LIBEDBUS
>> + ? ? bool "libedbus"
>> + ? ? select BR2_PACKAGE_LIBEINA
>> + ? ? select BR2_PACKAGE_DBUS
> ?DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
> so you have to repeat that here.
Hmm, would it be better just to add a comment asking the user to
enable dbus rather than adding the select for the XML library? I'm not
sure what the best way to handle that is.
> ?BTW, it's advisable to compile-test your patches against a minimal
> uclibc-based 32-bit and 64-bit cross-toolchain. ?That helps detecting
> dependencies on USE_WCHAR and USE_LARGEFILE.
There is a top-level dependency on WCHAR for all of EFL, I'll test
with LARGEFILE enabled too.
>> + ? ? help
>> + ? ? ? E_Dbus is a set of wrappers around DBus APIs by third party, so
> ?I believe the official name is D-Bus.
>
>> + ? ? ? they can be easily used by EFL applications, automatically
>> + ? ? ? providing Ecore/main loop integration, as well as Eina data types.
>> diff --git a/package/efl/libedbus/libedbus.mk b/package/efl/libedbus/libedbus.mk
>> new file mode 100644
>> index 0000000..e2ac836
>> --- /dev/null
>> +++ b/package/efl/libedbus/libedbus.mk
>> @@ -0,0 +1,16 @@
>> +#############################################################
>> +#
>> +# libedbus
>> +#
>> +#############################################################
>> +
>> +LIBEDBUS_VERSION = 1.1.0
>> +LIBEDBUS_SOURCE = e_dbus-$(LIBEDBUS_VERSION).tar.bz2
>> +LIBEDBUS_SITE = http://download.enlightenment.org/releases/
>> +LIBEDBUS_AUTORECONF = YES
>> +LIBEDBUS_LIBTOOL_PATCH = YES
> ?Libtool patching is enabled by default.
Thanks for the review, I'll fix these.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 14/14] libedbus: Add new package
2012-01-24 10:32 ` Will Newton
@ 2012-01-26 23:40 ` Arnout Vandecappelle
0 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2012-01-26 23:40 UTC (permalink / raw)
To: buildroot
On Tuesday 24 January 2012 11:32:50 Will Newton wrote:
> On Mon, Jan 23, 2012 at 10:51 PM, Arnout Vandecappelle <arnout@mind.be> wrote:
> > On Monday 23 January 2012 17:36:27 Will Newton wrote:
> >> Signed-off-by: Will Newton <will.newton@imgtec.com>
> > Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> >
> > [snip]
> >> diff --git a/package/efl/libedbus/Config.in b/package/efl/libedbus/Config.in
> >> new file mode 100644
> >> index 0000000..71e3b50
> >> --- /dev/null
> >> +++ b/package/efl/libedbus/Config.in
> >> @@ -0,0 +1,8 @@
> >> +config BR2_PACKAGE_LIBEDBUS
> >> + bool "libedbus"
> >> + select BR2_PACKAGE_LIBEINA
> >> + select BR2_PACKAGE_DBUS
> > DBUS depends on BR2_PACKAGE_EXPAT || BR2_PACKAGE_LIBXML2
> > so you have to repeat that here.
>
> Hmm, would it be better just to add a comment asking the user to
> enable dbus rather than adding the select for the XML library? I'm not
> sure what the best way to handle that is.
dbus itself has depends on, not select. So either you take that over
(and libedbus is not available unless one of the two XML packages is
selected). Alternatively, you can use depends on BR2_PACKAGE_DBUS
instead of a select. Or ideally, you add a choice for the XML library
to DBUS itself, so that the dependency is removed completely. Patch
follows.
> > BTW, it's advisable to compile-test your patches against a minimal
> > uclibc-based 32-bit and 64-bit cross-toolchain. That helps detecting
> > dependencies on USE_WCHAR and USE_LARGEFILE.
>
> There is a top-level dependency on WCHAR for all of EFL, I'll test
> with LARGEFILE enabled too.
Oops my bad.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-01-29 22:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-26 17:42 [Buildroot] [PATCH 14/14] libedbus: Add new package Will Newton
2012-01-29 22:22 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2012-01-23 16:36 Will Newton
2012-01-23 22:51 ` Arnout Vandecappelle
2012-01-24 10:32 ` Will Newton
2012-01-26 23:40 ` Arnout Vandecappelle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox