[Buildroot] [PATCH 1/2] Add lpc3250loader to the host tools

[Buildroot] [PATCH 1/2] Add lpc3250loader to the host tools

[Alexandre Belloni]

Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
---
 package/Config.in.host                 |    1 +
 package/lpc3250loader/Config.in.host   |    7 +++++++
 package/lpc3250loader/lpc3250loader.mk |    9 +++++++++
 3 files changed, 17 insertions(+), 0 deletions(-)
 create mode 100644 package/lpc3250loader/Config.in.host
 create mode 100644 package/lpc3250loader/lpc3250loader.mk

diff --git a/package/Config.in.host b/package/Config.in.host
index 1f49e79..861b736 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -1,5 +1,6 @@
 menu "Host utilities"
 
+source "package/lpc3250loader/Config.in.host"
 source "package/openocd/Config.in.host"
 source "package/sam-ba/Config.in.host"
 source "package/uboot-tools/Config.in.host"
diff --git a/package/lpc3250loader/Config.in.host b/package/lpc3250loader/Config.in.host
new file mode 100644
index 0000000..750080b
--- /dev/null
+++ b/package/lpc3250loader/Config.in.host
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_HOST_LPC3250LOADER
+	bool "host lpc3250loader"
+	help
+	  lpc3250loader is a tool to load/burn programs (in particular kickstart
+	  and S1L) on an LPC3250 platform.
+
+	  https://gitorious.org/lpc3250loader
diff --git a/package/lpc3250loader/lpc3250loader.mk b/package/lpc3250loader/lpc3250loader.mk
new file mode 100644
index 0000000..d66cd4a
--- /dev/null
+++ b/package/lpc3250loader/lpc3250loader.mk
@@ -0,0 +1,9 @@
+LPC3250LOADER_SITE = git://gitorious.org/lpc3250loader/lpc3250loader.git
+LPC3250LOADER_VERSION = master
+LPC3250LOADER_SITE_METHOD = git
+
+define HOST_LPC3250LOADER_INSTALL_CMDS
+	cp -a $(@D)/* $(HOST_DIR)/usr/bin/
+endef
+
+$(eval $(call GENTARGETS,host))
-- 
1.7.5.4

[Buildroot] [PATCH 2/2] Add lpc3250loader to lpc3250 configs

[Alexandre Belloni]

Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
---
 configs/ea3250_defconfig  |    6 ++++++
 configs/fdi3250_defconfig |    6 ++++++
 configs/phy3250_defconfig |    6 ++++++
 3 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/configs/ea3250_defconfig b/configs/ea3250_defconfig
index da84c7e..9cd7b34 100644
--- a/configs/ea3250_defconfig
+++ b/configs/ea3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="ea3250"
diff --git a/configs/fdi3250_defconfig b/configs/fdi3250_defconfig
index 505dc8b..1fd0b05 100644
--- a/configs/fdi3250_defconfig
+++ b/configs/fdi3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="fdi3250"
diff --git a/configs/phy3250_defconfig b/configs/phy3250_defconfig
index d46d719..bc17d5c 100644
--- a/configs/phy3250_defconfig
+++ b/configs/phy3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="phy3250"
-- 
1.7.5.4

[Buildroot] [PATCH 1/2] Add lpc3250loader to the host tools

[Arnout Vandecappelle]

On Saturday 04 February 2012 13:21:30 Alexandre Belloni wrote:
[snip]
> diff --git a/package/lpc3250loader/lpc3250loader.mk b/package/lpc3250loader/lpc3250loader.mk
> new file mode 100644
> index 0000000..d66cd4a
> --- /dev/null
> +++ b/package/lpc3250loader/lpc3250loader.mk
> @@ -0,0 +1,9 @@
> +LPC3250LOADER_SITE = git://gitorious.org/lpc3250loader/lpc3250loader.git
> +LPC3250LOADER_VERSION = master
> +LPC3250LOADER_SITE_METHOD = git

 It's a bug in Makefile.package.in that the site method is needed here...
All the ifdefs there are wrong and should be replaced by ?=

 Anyway, since this is a host-only package, I think it should be

HOST_LPC3250LOADER_SITE = git://gitorious.org/lpc3250loader/lpc3250loader.git
HOST_LPC3250LOADER_VERSION = master

which works fine without the site-method.

 And finally, I think we should use a specific tag or sha instead of 'master'.

> +
> +define HOST_LPC3250LOADER_INSTALL_CMDS
> +	cp -a $(@D)/* $(HOST_DIR)/usr/bin/
 There should be an mkdir -p here, or else
for f in $(@D)/*; do $(INSTALL) -D -m 0755 $$f $(HOST_DIR)/usr/bin/$$f; done

> +endef
> +
> +$(eval $(call GENTARGETS,host))
> 

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F