[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Alexandre Belloni]

Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
---
 package/Config.in.host                 |    1 +
 package/lpc3250loader/Config.in.host   |    7 +++++++
 package/lpc3250loader/lpc3250loader.mk |    9 +++++++++
 3 files changed, 17 insertions(+), 0 deletions(-)
 create mode 100644 package/lpc3250loader/Config.in.host
 create mode 100644 package/lpc3250loader/lpc3250loader.mk

diff --git a/package/Config.in.host b/package/Config.in.host
index 1f49e79..861b736 100644
--- a/package/Config.in.host
+++ b/package/Config.in.host
@@ -1,5 +1,6 @@
 menu "Host utilities"
 
+source "package/lpc3250loader/Config.in.host"
 source "package/openocd/Config.in.host"
 source "package/sam-ba/Config.in.host"
 source "package/uboot-tools/Config.in.host"
diff --git a/package/lpc3250loader/Config.in.host b/package/lpc3250loader/Config.in.host
new file mode 100644
index 0000000..750080b
--- /dev/null
+++ b/package/lpc3250loader/Config.in.host
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_HOST_LPC3250LOADER
+	bool "host lpc3250loader"
+	help
+	  lpc3250loader is a tool to load/burn programs (in particular kickstart
+	  and S1L) on an LPC3250 platform.
+
+	  https://gitorious.org/lpc3250loader
diff --git a/package/lpc3250loader/lpc3250loader.mk b/package/lpc3250loader/lpc3250loader.mk
new file mode 100644
index 0000000..e3d5528
--- /dev/null
+++ b/package/lpc3250loader/lpc3250loader.mk
@@ -0,0 +1,9 @@
+HOST_LPC3250LOADER_SITE = git://gitorious.org/lpc3250loader/lpc3250loader.git
+HOST_LPC3250LOADER_VERSION = 1.0
+
+define HOST_LPC3250LOADER_INSTALL_CMDS
+	mkdir -p $(HOST_DIR)/usr/bin/
+	cp -a $(@D)/* $(HOST_DIR)/usr/bin/
+endef
+
+$(eval $(call GENTARGETS,host))
-- 
1.7.5.4

[Buildroot] [PATCHv2 2/2] Add lpc3250loader to lpc3250 configs

[Alexandre Belloni]

Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
---
 configs/ea3250_defconfig  |    6 ++++++
 configs/fdi3250_defconfig |    6 ++++++
 configs/phy3250_defconfig |    6 ++++++
 3 files changed, 18 insertions(+), 0 deletions(-)

diff --git a/configs/ea3250_defconfig b/configs/ea3250_defconfig
index da84c7e..9cd7b34 100644
--- a/configs/ea3250_defconfig
+++ b/configs/ea3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="ea3250"
diff --git a/configs/fdi3250_defconfig b/configs/fdi3250_defconfig
index 505dc8b..1fd0b05 100644
--- a/configs/fdi3250_defconfig
+++ b/configs/fdi3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="fdi3250"
diff --git a/configs/phy3250_defconfig b/configs/phy3250_defconfig
index d46d719..bc17d5c 100644
--- a/configs/phy3250_defconfig
+++ b/configs/phy3250_defconfig
@@ -12,6 +12,12 @@ BR2_ARM_EABI=y
 BR2_GCC_VERSION_4_3_X=y
 
 
+#
+# Host utilities
+#
+BR2_PACKAGE_HOST_LPC3250LOADER=y
+
+
 # Bootloaders
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="phy3250"
-- 
1.7.5.4

[Buildroot] [PATCHv2 2/2] Add lpc3250loader to lpc3250 configs

[Peter Korsgaard]

>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@piout.net> writes:

 Alexandre> Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Thomas De Schampheleire]

On Tue, Feb 7, 2012 at 12:01 PM, Alexandre Belloni
<alexandre.belloni@piout.net> wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
> ---
> ?package/Config.in.host ? ? ? ? ? ? ? ? | ? ?1 +
> ?package/lpc3250loader/Config.in.host ? | ? ?7 +++++++
> ?package/lpc3250loader/lpc3250loader.mk | ? ?9 +++++++++
> ?3 files changed, 17 insertions(+), 0 deletions(-)
> ?create mode 100644 package/lpc3250loader/Config.in.host
> ?create mode 100644 package/lpc3250loader/lpc3250loader.mk
>
> diff --git a/package/Config.in.host b/package/Config.in.host
> index 1f49e79..861b736 100644
> --- a/package/Config.in.host
> +++ b/package/Config.in.host
> @@ -1,5 +1,6 @@
> ?menu "Host utilities"
>
> +source "package/lpc3250loader/Config.in.host"
> ?source "package/openocd/Config.in.host"
> ?source "package/sam-ba/Config.in.host"
> ?source "package/uboot-tools/Config.in.host"
> diff --git a/package/lpc3250loader/Config.in.host b/package/lpc3250loader/Config.in.host
> new file mode 100644
> index 0000000..750080b
> --- /dev/null
> +++ b/package/lpc3250loader/Config.in.host
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_HOST_LPC3250LOADER
> + ? ? ? bool "host lpc3250loader"
> + ? ? ? help
> + ? ? ? ? lpc3250loader is a tool to load/burn programs (in particular kickstart
> + ? ? ? ? and S1L) on an LPC3250 platform.

Does it make sense to have this config depend on an architecture
specific variable?
Although it would still be very broad, depending on BR2_ARCH_arm could
be a possibility...

This way, users of other architectures are not presented with packages
that are irrelevant for them...

> +
> + ? ? ? ? https://gitorious.org/lpc3250loader
> diff --git a/package/lpc3250loader/lpc3250loader.mk b/package/lpc3250loader/lpc3250loader.mk
> new file mode 100644
> index 0000000..e3d5528
> --- /dev/null
> +++ b/package/lpc3250loader/lpc3250loader.mk
> @@ -0,0 +1,9 @@
> +HOST_LPC3250LOADER_SITE = git://gitorious.org/lpc3250loader/lpc3250loader.git
> +HOST_LPC3250LOADER_VERSION = 1.0
> +
> +define HOST_LPC3250LOADER_INSTALL_CMDS
> + ? ? ? mkdir -p $(HOST_DIR)/usr/bin/
> + ? ? ? cp -a $(@D)/* $(HOST_DIR)/usr/bin/
> +endef
> +
> +$(eval $(call GENTARGETS,host))
> --
> 1.7.5.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Alexandre Belloni]

On Tue, Feb 07, 2012 at 03:24:11PM +0100, Thomas De Schampheleire wrote :
> On Tue, Feb 7, 2012 at 12:01 PM, Alexandre Belloni
> <alexandre.belloni@piout.net> wrote:
> > diff --git a/package/lpc3250loader/Config.in.host b/package/lpc3250loader/Config.in.host
> > new file mode 100644
> > index 0000000..750080b
> > --- /dev/null
> > +++ b/package/lpc3250loader/Config.in.host
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_HOST_LPC3250LOADER
> > + ? ? ? bool "host lpc3250loader"
> > + ? ? ? help
> > + ? ? ? ? lpc3250loader is a tool to load/burn programs (in particular kickstart
> > + ? ? ? ? and S1L) on an LPC3250 platform.
> 
> Does it make sense to have this config depend on an architecture
> specific variable?
> Although it would still be very broad, depending on BR2_ARCH_arm could
> be a possibility...
> 
> This way, users of other architectures are not presented with packages
> that are irrelevant for them...
> 

Could be, it wasn't the case for sam-ba though...

-- 
Alexandre Belloni

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Thomas De Schampheleire]

On Tue, Feb 7, 2012 at 3:26 PM, Alexandre Belloni
<alexandre.belloni@piout.net> wrote:
> On Tue, Feb 07, 2012 at 03:24:11PM +0100, Thomas De Schampheleire wrote :
>> On Tue, Feb 7, 2012 at 12:01 PM, Alexandre Belloni
>> <alexandre.belloni@piout.net> wrote:
>> > diff --git a/package/lpc3250loader/Config.in.host b/package/lpc3250loader/Config.in.host
>> > new file mode 100644
>> > index 0000000..750080b
>> > --- /dev/null
>> > +++ b/package/lpc3250loader/Config.in.host
>> > @@ -0,0 +1,7 @@
>> > +config BR2_PACKAGE_HOST_LPC3250LOADER
>> > + ? ? ? bool "host lpc3250loader"
>> > + ? ? ? help
>> > + ? ? ? ? lpc3250loader is a tool to load/burn programs (in particular kickstart
>> > + ? ? ? ? and S1L) on an LPC3250 platform.
>>
>> Does it make sense to have this config depend on an architecture
>> specific variable?
>> Although it would still be very broad, depending on BR2_ARCH_arm could
>> be a possibility...
>>
>> This way, users of other architectures are not presented with packages
>> that are irrelevant for them...
>>
>
> Could be, it wasn't the case for sam-ba though...

In my opinion, the same change could be done for sam-ba then.

What do others think?

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Arnout Vandecappelle]

On Tuesday 07 February 2012 12:01:25 Alexandre Belloni wrote:
> Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Thomas, the dependency on ARCH_arm isn't necessary for me.  But I don't
oppose it either.

 Regards,
 Arnout

-- 
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

[Buildroot] [PATCHv2 1/2] Add lpc3250loader to the host tools

[Peter Korsgaard]

>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@piout.net> writes:

 Alexandre> Signed-off-by: Alexandre Belloni <alexandre.belloni@piout.net>
 Alexandre> ---
 Alexandre>  package/Config.in.host                 |    1 +
 Alexandre>  package/lpc3250loader/Config.in.host   |    7 +++++++
 Alexandre>  package/lpc3250loader/lpc3250loader.mk |    9 +++++++++
 Alexandre>  3 files changed, 17 insertions(+), 0 deletions(-)
 Alexandre>  create mode 100644 package/lpc3250loader/Config.in.host
 Alexandre>  create mode 100644 package/lpc3250loader/lpc3250loader.mk

Committed, thanks.

 Alexandre> +define HOST_LPC3250LOADER_INSTALL_CMDS
 Alexandre> +	mkdir -p $(HOST_DIR)/usr/bin/
 Alexandre> +	cp -a $(@D)/* $(HOST_DIR)/usr/bin/

We normally use install -D for installation, so I changed this.

-- 
Bye, Peter Korsgaard