* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
@ 2012-02-29 23:27 Ismael Luceno
2012-02-29 23:27 ` [Buildroot] [PATCH 2/2] openssl: Add -march and -mcpu flags Ismael Luceno
2012-03-01 5:37 ` [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Baruch Siach
0 siblings, 2 replies; 10+ messages in thread
From: Ismael Luceno @ 2012-02-29 23:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
package/openssl/openssl.mk | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
index cb29fe4..fda935a 100644
--- a/package/openssl/openssl.mk
+++ b/package/openssl/openssl.mk
@@ -9,7 +9,14 @@ OPENSSL_SITE = http://www.openssl.org/source
OPENSSL_INSTALL_STAGING = YES
OPENSSL_DEPENDENCIES = zlib
OPENSSL_TARGET_ARCH = generic32
+
+ifeq ($(BR2_GCC_VERSION_4_6_X)-$(ARCH),y-arm)
+# workaround for gcc issue
+# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308
+OPENSSL_CFLAGS = $(subst -Os,-O2,$(TARGET_CFLAGS))
+else
OPENSSL_CFLAGS = $(TARGET_CFLAGS)
+endif
ifeq ($(BR2_PACKAGE_OPENSSL_OCF),y)
OPENSSL_CFLAGS += -DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS
--
1.7.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] openssl: Add -march and -mcpu flags
2012-02-29 23:27 [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Ismael Luceno
@ 2012-02-29 23:27 ` Ismael Luceno
2012-03-01 5:37 ` [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Baruch Siach
1 sibling, 0 replies; 10+ messages in thread
From: Ismael Luceno @ 2012-02-29 23:27 UTC (permalink / raw)
To: buildroot
Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
---
package/openssl/openssl.mk | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
index fda935a..c228458 100644
--- a/package/openssl/openssl.mk
+++ b/package/openssl/openssl.mk
@@ -18,6 +18,8 @@ else
OPENSSL_CFLAGS = $(TARGET_CFLAGS)
endif
+OPENSSL_CFLAGS += -march=$(BR2_GCC_TARGET_ARCH) -mcpu=$(BR2_GCC_TARGET_TUNE)
+
ifeq ($(BR2_PACKAGE_OPENSSL_OCF),y)
OPENSSL_CFLAGS += -DHAVE_CRYPTODEV -DUSE_CRYPTODEV_DIGESTS
--
1.7.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-02-29 23:27 [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Ismael Luceno
2012-02-29 23:27 ` [Buildroot] [PATCH 2/2] openssl: Add -march and -mcpu flags Ismael Luceno
@ 2012-03-01 5:37 ` Baruch Siach
2012-03-01 7:32 ` Thomas Petazzoni
2012-03-01 17:32 ` Ismael Luceno
1 sibling, 2 replies; 10+ messages in thread
From: Baruch Siach @ 2012-03-01 5:37 UTC (permalink / raw)
To: buildroot
Hi Ismael,
On Wed, Feb 29, 2012 at 09:27:57PM -0200, Ismael Luceno wrote:
>
> Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
> ---
> package/openssl/openssl.mk | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
> index cb29fe4..fda935a 100644
> --- a/package/openssl/openssl.mk
> +++ b/package/openssl/openssl.mk
> @@ -9,7 +9,14 @@ OPENSSL_SITE = http://www.openssl.org/source
> OPENSSL_INSTALL_STAGING = YES
> OPENSSL_DEPENDENCIES = zlib
> OPENSSL_TARGET_ARCH = generic32
> +
> +ifeq ($(BR2_GCC_VERSION_4_6_X)-$(ARCH),y-arm)
> +# workaround for gcc issue
> +# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308
> +OPENSSL_CFLAGS = $(subst -Os,-O2,$(TARGET_CFLAGS))
> +else
> OPENSSL_CFLAGS = $(TARGET_CFLAGS)
> +endif
Will this work for external and ct-ng toolchains?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-01 5:37 ` [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Baruch Siach
@ 2012-03-01 7:32 ` Thomas Petazzoni
2012-03-01 17:32 ` Ismael Luceno
1 sibling, 0 replies; 10+ messages in thread
From: Thomas Petazzoni @ 2012-03-01 7:32 UTC (permalink / raw)
To: buildroot
Le Thu, 1 Mar 2012 07:37:27 +0200,
Baruch Siach <baruch@tkos.co.il> a ?crit :
> Will this work for external and ct-ng toolchains?
No. For the external and ct-ng toolchains, we have no way of testing
the gcc version through BR2_* variables, we could only do it by running
the cross gcc itself and checking its version number.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-01 5:37 ` [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Baruch Siach
2012-03-01 7:32 ` Thomas Petazzoni
@ 2012-03-01 17:32 ` Ismael Luceno
2012-03-01 18:10 ` Baruch Siach
1 sibling, 1 reply; 10+ messages in thread
From: Ismael Luceno @ 2012-03-01 17:32 UTC (permalink / raw)
To: buildroot
On Thu, 1 Mar 2012 07:37:27 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Ismael,
>
> On Wed, Feb 29, 2012 at 09:27:57PM -0200, Ismael Luceno wrote:
> >
> > Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
> > ---
> > package/openssl/openssl.mk | 7 +++++++
> > 1 files changed, 7 insertions(+), 0 deletions(-)
> >
> > diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
> > index cb29fe4..fda935a 100644
> > --- a/package/openssl/openssl.mk
> > +++ b/package/openssl/openssl.mk
> > @@ -9,7 +9,14 @@ OPENSSL_SITE = http://www.openssl.org/source
> > OPENSSL_INSTALL_STAGING = YES
> > OPENSSL_DEPENDENCIES = zlib
> > OPENSSL_TARGET_ARCH = generic32
> > +
> > +ifeq ($(BR2_GCC_VERSION_4_6_X)-$(ARCH),y-arm)
> > +# workaround for gcc issue
> > +# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308
> > +OPENSSL_CFLAGS = $(subst -Os,-O2,$(TARGET_CFLAGS))
> > +else
> > OPENSSL_CFLAGS = $(TARGET_CFLAGS)
> > +endif
>
> Will this work for external and ct-ng toolchains?
>
> baruch
>
As long as you set BR2_GCC_VERSION_4_6_X manually...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120301/c8b6a728/attachment.asc>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-01 17:32 ` Ismael Luceno
@ 2012-03-01 18:10 ` Baruch Siach
2012-03-03 23:13 ` Ismael Luceno
0 siblings, 1 reply; 10+ messages in thread
From: Baruch Siach @ 2012-03-01 18:10 UTC (permalink / raw)
To: buildroot
Hi Ismael,
On Thu, Mar 01, 2012 at 03:32:01PM -0200, Ismael Luceno wrote:
> On Thu, 1 Mar 2012 07:37:27 +0200
> Baruch Siach <baruch@tkos.co.il> wrote:
> > On Wed, Feb 29, 2012 at 09:27:57PM -0200, Ismael Luceno wrote:
> > >
> > > Signed-off-by: Ismael Luceno <ismael.luceno@gmail.com>
> > > ---
> > > package/openssl/openssl.mk | 7 +++++++
> > > 1 files changed, 7 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/package/openssl/openssl.mk b/package/openssl/openssl.mk
> > > index cb29fe4..fda935a 100644
> > > --- a/package/openssl/openssl.mk
> > > +++ b/package/openssl/openssl.mk
> > > @@ -9,7 +9,14 @@ OPENSSL_SITE = http://www.openssl.org/source
> > > OPENSSL_INSTALL_STAGING = YES
> > > OPENSSL_DEPENDENCIES = zlib
> > > OPENSSL_TARGET_ARCH = generic32
> > > +
> > > +ifeq ($(BR2_GCC_VERSION_4_6_X)-$(ARCH),y-arm)
> > > +# workaround for gcc issue
> > > +# http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308
> > > +OPENSSL_CFLAGS = $(subst -Os,-O2,$(TARGET_CFLAGS))
> > > +else
> > > OPENSSL_CFLAGS = $(TARGET_CFLAGS)
> > > +endif
> >
> > Will this work for external and ct-ng toolchains?
> >
> > baruch
>
> As long as you set BR2_GCC_VERSION_4_6_X manually...
But BR2_GCC_VERSION_4_6_X is only available when selecting internal
toolchains. See toolchain/toolchain-buildroot/Config.in.
Doesn't the patch from r183512 fix this bug?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-01 18:10 ` Baruch Siach
@ 2012-03-03 23:13 ` Ismael Luceno
2012-03-05 5:19 ` Baruch Siach
0 siblings, 1 reply; 10+ messages in thread
From: Ismael Luceno @ 2012-03-03 23:13 UTC (permalink / raw)
To: buildroot
On Thu, 1 Mar 2012 20:10:32 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
<...>
> But BR2_GCC_VERSION_4_6_X is only available when selecting internal
> toolchains. See toolchain/toolchain-buildroot/Config.in.
Would setting it (on the command line) produce any side-effect?
> Doesn't the patch from r183512 fix this bug?
What is "r183512" supposed to mean?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120303/0f46aab0/attachment.asc>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-03 23:13 ` Ismael Luceno
@ 2012-03-05 5:19 ` Baruch Siach
2012-03-05 6:45 ` Ismael Luceno
2012-03-06 15:21 ` Gustavo Zacarias
0 siblings, 2 replies; 10+ messages in thread
From: Baruch Siach @ 2012-03-05 5:19 UTC (permalink / raw)
To: buildroot
Hi Ismael,
On Sat, Mar 03, 2012 at 09:13:38PM -0200, Ismael Luceno wrote:
> On Thu, 1 Mar 2012 20:10:32 +0200
> Baruch Siach <baruch@tkos.co.il> wrote:
> > Doesn't the patch from r183512 fix this bug?
>
> What is "r183512" supposed to mean?
This the Subversion commit mentioned in comment #20 of Bugzilla bug #48308
that you linked to (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308).
Comment #21 seems to indicate that this fix hasn't been backported to gcc
4.6.x. Maybe a better solutions would be to add this patch Buildroot's
internal gcc.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-05 5:19 ` Baruch Siach
@ 2012-03-05 6:45 ` Ismael Luceno
2012-03-06 15:21 ` Gustavo Zacarias
1 sibling, 0 replies; 10+ messages in thread
From: Ismael Luceno @ 2012-03-05 6:45 UTC (permalink / raw)
To: buildroot
On Mon, 5 Mar 2012 07:19:37 +0200
Baruch Siach <baruch@tkos.co.il> wrote:
> On Sat, Mar 03, 2012 at 09:13:38PM -0200, Ismael Luceno wrote:
> > On Thu, 1 Mar 2012 20:10:32 +0200
> > Baruch Siach <baruch@tkos.co.il> wrote:
> > > Doesn't the patch from r183512 fix this bug?
> >
> > What is "r183512" supposed to mean?
>
> This the Subversion commit mentioned in comment #20 of Bugzilla bug
> #48308 that you linked to
<...>
Oh, I thought you were talking about buildroot.
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308). Comment #21
> seems to indicate that this fix hasn't been backported to gcc 4.6.x.
Probably not hitting anytime soon.
> Maybe a better solutions would be to add this patch Buildroot's
> internal gcc.
Indeed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120305/16c2119c/attachment.asc>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x
2012-03-05 5:19 ` Baruch Siach
2012-03-05 6:45 ` Ismael Luceno
@ 2012-03-06 15:21 ` Gustavo Zacarias
1 sibling, 0 replies; 10+ messages in thread
From: Gustavo Zacarias @ 2012-03-06 15:21 UTC (permalink / raw)
To: buildroot
On 2012-03-05 02:19, Baruch Siach wrote:
> Hi Ismael,
>
> On Sat, Mar 03, 2012 at 09:13:38PM -0200, Ismael Luceno wrote:
>> On Thu, 1 Mar 2012 20:10:32 +0200
>> Baruch Siach <baruch@tkos.co.il> wrote:
>> > Doesn't the patch from r183512 fix this bug?
>>
>> What is "r183512" supposed to mean?
>
> This the Subversion commit mentioned in comment #20 of Bugzilla bug
> #48308
> that you linked to
> (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48308).
> Comment #21 seems to indicate that this fix hasn't been backported to
> gcc
> 4.6.x. Maybe a better solutions would be to add this patch
> Buildroot's
> internal gcc.
>
> baruch
+1 on fixing gcc, there's no business in touching openssl and possibly
breaking it on some other scenario because of this.
Regards.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2012-03-06 15:21 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-29 23:27 [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Ismael Luceno
2012-02-29 23:27 ` [Buildroot] [PATCH 2/2] openssl: Add -march and -mcpu flags Ismael Luceno
2012-03-01 5:37 ` [Buildroot] [PATCH 1/2] openssl: Fix build on ARM with GCC 4.6.x Baruch Siach
2012-03-01 7:32 ` Thomas Petazzoni
2012-03-01 17:32 ` Ismael Luceno
2012-03-01 18:10 ` Baruch Siach
2012-03-03 23:13 ` Ismael Luceno
2012-03-05 5:19 ` Baruch Siach
2012-03-05 6:45 ` Ismael Luceno
2012-03-06 15:21 ` Gustavo Zacarias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox