* [Buildroot] [PATCH] boost: Add coment when C++ is missing
@ 2012-03-02 18:52 Stephan Thamm
2012-03-03 15:12 ` Arnout Vandecappelle
0 siblings, 1 reply; 4+ messages in thread
From: Stephan Thamm @ 2012-03-02 18:52 UTC (permalink / raw)
To: buildroot
Hi,
a coworker just searched boost in the current release and was not able to find
it. He even found out which section it was in but he was missing C++ support
so he didn't see anything.
This patch would have saved him much time:
---
package/boost/Config.in | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/package/boost/Config.in b/package/boost/Config.in
index 7598d02..eac91dc 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -8,6 +8,9 @@ config BR2_PACKAGE_BOOST
http://www.boost.org/
+comment "boost requires a toolchain with C++ support enabled"
+ depends on !BR2_INSTALL_LIBSTDCPP
+
if BR2_PACKAGE_BOOST
config BR2_PACKAGE_BOOST_MULTITHREADED
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] boost: Add coment when C++ is missing
2012-03-02 18:52 [Buildroot] [PATCH] boost: Add coment when C++ is missing Stephan Thamm
@ 2012-03-03 15:12 ` Arnout Vandecappelle
2012-03-03 20:00 ` Stephan Thamm
0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2012-03-03 15:12 UTC (permalink / raw)
To: buildroot
On Friday 02 March 2012 18:52:03 Stephan Thamm wrote:
> Hi,
> a coworker just searched boost in the current release and was not able to find
> it. He even found out which section it was in but he was missing C++ support
> so he didn't see anything.
>
> This patch would have saved him much time:
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Thank you for this patch. Even small patches like this are much
appreciated!
Please add a Signed-off-by tag on your patch, i.e. a line saying
Signed-off-by: Your Name <your@email.address>
This is a short way for you to assert that you are entitled to contribute
the patch under buildroot's GPL license. See
http://kerneltrap.org/files/Jeremy/DCO.txt for more details.
Also, e-mail conversation that shouldn't be included in the commit
message (like all your text above) should be preceded by a line
containing only three dashes. This allows us to run your mail
through 'git am' without any further manual processing required.
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286540
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] boost: Add coment when C++ is missing
2012-03-03 15:12 ` Arnout Vandecappelle
@ 2012-03-03 20:00 ` Stephan Thamm
2012-03-16 21:43 ` Peter Korsgaard
0 siblings, 1 reply; 4+ messages in thread
From: Stephan Thamm @ 2012-03-03 20:00 UTC (permalink / raw)
To: buildroot
Signed-off-by: Stephan Thamm <thammi@chaossource.net>
---
package/boost/Config.in | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/package/boost/Config.in b/package/boost/Config.in
index 7598d02..eac91dc 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -8,6 +8,9 @@ config BR2_PACKAGE_BOOST
http://www.boost.org/
+comment "boost requires a toolchain with C++ support enabled"
+ depends on !BR2_INSTALL_LIBSTDCPP
+
if BR2_PACKAGE_BOOST
config BR2_PACKAGE_BOOST_MULTITHREADED
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] boost: Add coment when C++ is missing
2012-03-03 20:00 ` Stephan Thamm
@ 2012-03-16 21:43 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2012-03-16 21:43 UTC (permalink / raw)
To: buildroot
>>>>> "Stephan" == Stephan Thamm <thammi@chaossource.net> writes:
Stephan> Signed-off-by: Stephan Thamm <thammi@chaossource.net>
Thanks, committed with a small fix.
Your mailer had converted tabs to spaces, so I had to apply
manually. Consider using 'git send-email' next time to not have those
problems.
Stephan> ---
Stephan> package/boost/Config.in | 3 +++
Stephan> 1 files changed, 3 insertions(+), 0 deletions(-)
Stephan> diff --git a/package/boost/Config.in b/package/boost/Config.in
Stephan> index 7598d02..eac91dc 100644
Stephan> --- a/package/boost/Config.in
Stephan> +++ b/package/boost/Config.in
Stephan> @@ -8,6 +8,9 @@ config BR2_PACKAGE_BOOST
Stephan> http://www.boost.org/
Stephan> +comment "boost requires a toolchain with C++ support enabled"
Stephan> + depends on !BR2_INSTALL_LIBSTDCPP
Stephan> +
Stephan> if BR2_PACKAGE_BOOST
The comment has to go above the main BR2_PACKAGE_BOOST, otherwise
menuconfig won't indent the BR2_PACKAGE_BOOST_* options under boost.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-16 21:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-02 18:52 [Buildroot] [PATCH] boost: Add coment when C++ is missing Stephan Thamm
2012-03-03 15:12 ` Arnout Vandecappelle
2012-03-03 20:00 ` Stephan Thamm
2012-03-16 21:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox