[Buildroot] linphone package

[Buildroot] linphone package

[Choi, David]

Hello everybody,

After seeing a patch submitted during the August last year, I checked out the latest stable version of buildroot last night.
But After uncompressed the buildroot source tree, I could not find the patch applied to the package/Config.in for the linphone.

How can I check out the buildroot source tree including the linphone patch?

Thank you in advance.

Regards,
David J. Choi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20120306/880c9336/attachment.html>

[Buildroot] linphone package

[Thomas Petazzoni]

Hello David,

Le Tue, 6 Mar 2012 00:42:58 +0000,
"Choi, David" <David.Choi@Micrel.Com> a ?crit :

> After seeing a patch submitted during the August last year, I checked
> out the latest stable version of buildroot last night. But After
> uncompressed the buildroot source tree, I could not find the patch
> applied to the package/Config.in for the linphone.

The patch at:

From: Pedro Sanchez <psanchez@fosstel.com>
To: buildroot at busybox.net
Subject: [Buildroot] [PATCH 1/1] New Package: Linphone
Date: Wed, 10 Aug 2011 10:26:34 -0400

has apparently not been applied, even though it looked quite good (but
the contributor hasn't been persistent enough by re-sending updated
versions of the patch).

Can you take the patch, update it and push it again so that we can merge
it?

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] linphone package

[Pedro Sanchez]

Hello,

I'd like to get linphone-nox (console mode) packaged for buildroot. So 
before I start working on it, is there some previous packaging work that 
I could refer to? or is someone else already working on it?

Thanks,

-- 
Pedro

[Buildroot] linphone package

[Peter Korsgaard]

>>>>> "Pedro" == Pedro Sanchez <psanchez@fosstel.com> writes:

 Pedro> Hello,
 Pedro> I'd like to get linphone-nox (console mode) packaged for buildroot. So
 Pedro> before I start working on it, is there some previous packaging work
 Pedro> that I could refer to? or is someone else already working on it?

Not that I'm aware of.

-- 
Bye, Peter Korsgaard

[Buildroot] linphone package

[Pedro Sanchez]

On 08/09/2011 11:21 AM, Peter Korsgaard wrote:
>>>>>> "Pedro" == Pedro Sanchez<psanchez@fosstel.com>  writes:
>
>   Pedro>  Hello,
>   Pedro>  I'd like to get linphone-nox (console mode) packaged for buildroot. So
>   Pedro>  before I start working on it, is there some previous packaging work
>   Pedro>  that I could refer to? or is someone else already working on it?
>
> Not that I'm aware of.
>

OK thanks.

I have now a working version of the linphone.mk file that seems to work 
well in my initial tests:

#############################################################
#
# linphone
#
#############################################################
LINPHONE_VERSION = 3.4.3
LINPHONE_SOURCE = linphone-$(LINPHONE_VERSION).tar.gz
LINPHONE_SITE = 
http://download-mirror.savannah.gnu.org/releases/linphone/3.4.x/sources
LINPHONE_INSTALL_STAGING = YES
LINPHONE_DEPENDENCIES = alsa-lib speex ncurses readline libeXosip2 libosip2
LINPHONE_CONF_OPT = --enable-gnome_ui=no \
		    --enable-gtk_ui=no \
		    --enable-alsa \
		    --disable-manual \
		    --disable-sdl \
		    --disable-theora \
		    --disable-x11 \
		    --disable-shared \
		    --disable-gsm \
		    --disable-jack \
		    --disable-libv4l \
		    --disable-video

$(eval $(call AUTOTARGETS,package,linphone))


I am cross-compiling linphone for ARM and the final executable created 
by buildroot in my target directory is /usr/bin/arm-linux-linphonec. No 
other binaries in the build have this "arm-linux' prefix. I's like the 
binary to be named /usr/bin/linphonec instead? Any suggestions?

Thanks,

-- 
Pedro

[Buildroot] linphone package

[Peter Korsgaard]

>>>>> "Pedro" == Pedro Sanchez <psanchez@fosstel.com> writes:

Hi,

 Pedro> #############################################################
 Pedro> #
 Pedro> # linphone
 Pedro> #
 Pedro> #############################################################
 Pedro> LINPHONE_VERSION = 3.4.3
 Pedro> LINPHONE_SOURCE = linphone-$(LINPHONE_VERSION).tar.gz
 Pedro> LINPHONE_SITE =
 Pedro> http://download-mirror.savannah.gnu.org/releases/linphone/3.4.x/sources
 Pedro> LINPHONE_INSTALL_STAGING = YES
 Pedro> LINPHONE_DEPENDENCIES = alsa-lib speex ncurses readline libeXosip2 libosip2
 Pedro> LINPHONE_CONF_OPT = --enable-gnome_ui=no \
 Pedro> 		    --enable-gtk_ui=no \
 Pedro> 		    --enable-alsa \
 Pedro> 		    --disable-manual \
 Pedro> 		    --disable-sdl \
 Pedro> 		    --disable-theora \
 Pedro> 		    --disable-x11 \
 Pedro> 		    --disable-shared \
 Pedro> 		    --disable-gsm \
 Pedro> 		    --disable-jack \
 Pedro> 		    --disable-libv4l \
 Pedro> 		    --disable-video

We have most of those in BR, so it would be good to optionally enable
them.

 Pedro> $(eval $(call AUTOTARGETS,package,linphone))


 Pedro> I am cross-compiling linphone for ARM and the final executable
 Pedro> created by buildroot in my target directory is
 Pedro> /usr/bin/arm-linux-linphonec. No other binaries in the build
 Pedro> have this "arm-linux' prefix. I's like the binary to be named
 Pedro> /usr/bin/linphonec instead? Any suggestions?

Typically you can pass --program-prefix="" to configure to disable it.

Care to send a real git patch including Config.in once you have it all
working?

-- 
Bye, Peter Korsgaard

[Buildroot] linphone package

[Yann E. MORIN]

Peter, Pedro,

On Tuesday 09 August 2011 20:39:31 Peter Korsgaard wrote:
> >>>>> "Pedro" == Pedro Sanchez <psanchez@fosstel.com> writes:
>  Pedro> I am cross-compiling linphone for ARM and the final executable
>  Pedro> created by buildroot in my target directory is
>  Pedro> /usr/bin/arm-linux-linphonec. No other binaries in the build
>  Pedro> have this "arm-linux' prefix. I's like the binary to be named
>  Pedro> /usr/bin/linphonec instead? Any suggestions?
> 
> Typically you can pass --program-prefix="" to configure to disable it.

Maybe it would make sense to add this to the auto-target infrastructure?
Either it is unconditionally added, or the package can set a variable to
use it, eg. PKG_CONF_PROG_PREFIX = YES

I'll take a shot at it.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] linphone package

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> Peter, Pedro,
 Yann> On Tuesday 09 August 2011 20:39:31 Peter Korsgaard wrote:
 >> >>>>> "Pedro" == Pedro Sanchez <psanchez@fosstel.com> writes:
 Pedro> I am cross-compiling linphone for ARM and the final executable
 Pedro> created by buildroot in my target directory is
 Pedro> /usr/bin/arm-linux-linphonec. No other binaries in the build
 Pedro> have this "arm-linux' prefix. I's like the binary to be named
 Pedro> /usr/bin/linphonec instead? Any suggestions?
 >> 
 >> Typically you can pass --program-prefix="" to configure to disable it.

 Yann> Maybe it would make sense to add this to the auto-target infrastructure?
 Yann> Either it is unconditionally added, or the package can set a variable to
 Yann> use it, eg. PKG_CONF_PROG_PREFIX = YES

Unconditional should be ok, similar to how we do the ipv6 / nls stuff.

 Yann> I'll take a shot at it.

Thanks!

-- 
Bye, Peter Korsgaard

[Buildroot] linphone package

[Yann E. MORIN]

Peter, All,

On Tuesday 09 August 2011 21:25:02 Peter Korsgaard wrote:
>  Yann> Maybe it would make sense to add this to the auto-target infrastructure?
>  Yann> Either it is unconditionally added, or the package can set a variable to
>  Yann> use it, eg. PKG_CONF_PROG_PREFIX = YES
> 
> Unconditional should be ok, similar to how we do the ipv6 / nls stuff.

OK.

I'm also removing it from PKG_CONF_OPT variables. Do you want a single patch
that removes all instances in one go, or do you want one patch per package?
I'm tempted to do the latter, so we can revert only those that break.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] linphone package

[Peter Korsgaard]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:

 Yann> Peter, All,
 Yann> On Tuesday 09 August 2011 21:25:02 Peter Korsgaard wrote:
 Yann> Maybe it would make sense to add this to the auto-target infrastructure?
 Yann> Either it is unconditionally added, or the package can set a variable to
 Yann> use it, eg. PKG_CONF_PROG_PREFIX = YES
 >> 
 >> Unconditional should be ok, similar to how we do the ipv6 / nls stuff.

 Yann> OK.

 Yann> I'm also removing it from PKG_CONF_OPT variables. Do you want a
 Yann> single patch that removes all instances in one go, or do you want
 Yann> one patch per package?  I'm tempted to do the latter, so we can
 Yann> revert only those that break.

Up to you. Seems we have it in 21 files. I'll prefer to only commit
post-2011.08 though.

-- 
Bye, Peter Korsgaard

[Buildroot] linphone package

[Yann E. MORIN]

Peter, All,

On Tuesday 09 August 2011 21:44:59 Peter Korsgaard wrote:
> >>>>> "Yann" == Yann E MORIN <yann.morin.1998@anciens.enib.fr> writes:
>  Yann> I'm also removing it from PKG_CONF_OPT variables. Do you want a
>  Yann> single patch that removes all instances in one go, or do you want
>  Yann> one patch per package?  I'm tempted to do the latter, so we can
>  Yann> revert only those that break.
> 
> Up to you. Seems we have it in 21 files.

Sure! So, one patch per change it will be. :-)

> I'll prefer to only commit post-2011.08 though.

I'm doing it now, `cause I get a bit bored. So, systematicaly editing a
bunch of files, and just do the same thing again-and-again won't get me
more bored than I currently am... ;-]

And then, I can easily rebase later. Hopefully... :-]

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'